From patchwork Tue May 26 12:49:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 48977 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 38B912121F for ; Tue, 26 May 2015 12:52:43 +0000 (UTC) Received: by lbcue7 with SMTP id ue7sf10863948lbc.3 for ; Tue, 26 May 2015 05:52:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :content-type:content-transfer-encoding:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list; bh=IjHJDdt0Ukt1tc63TJv9QOBtAtRKH+vQV5FZSKH/CEk=; b=MuEAjEKhQMeK93Hik7I/otMwxKUJqIQJ4ka4WyrWji+GeduqINKsbIIyWZERoDwHFG U3yilWvew7BtL8UjNTcTu+VvXeqRl57lEA5GKIH8/VkXVBKZNgGvH/dXEyFzLtEdr/L2 k8tE48GTNSyH/0jIhmkdJg4fcy1pw3cVqw0cf0MGTi+zYqVb0sgsvmGNuJor5WliEQrw aP21/DbxqWsV6OQFMduIjbnXKtTO/9BIxkm4kiiuMESlvdnX3X4irCTxakVsjbYzihtH FDYSAjgsJg77d/nOO7OeS1Mc8lHhno54m6xdgU13rmT9AGUiCxYiw4oPP2E5DJ+oI8cT Gt0g== X-Gm-Message-State: ALoCoQk5BnRLVXilFwvUK0mAf4Js49g2FxHounojpo/rxGEIsynXF1I3j5aEgGsgYnZLHte4wmL4 X-Received: by 10.112.84.104 with SMTP id x8mr3659317lby.23.1432644762178; Tue, 26 May 2015 05:52:42 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.116.74 with SMTP id ju10ls886601lab.23.gmail; Tue, 26 May 2015 05:52:42 -0700 (PDT) X-Received: by 10.112.170.167 with SMTP id an7mr12546174lbc.103.1432644762029; Tue, 26 May 2015 05:52:42 -0700 (PDT) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPS id ac10si10882767lbc.134.2015.05.26.05.52.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2015 05:52:42 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) client-ip=209.85.215.50; Received: by laat2 with SMTP id t2so66829642laa.1 for ; Tue, 26 May 2015 05:52:42 -0700 (PDT) X-Received: by 10.112.163.168 with SMTP id yj8mr22609951lbb.36.1432644761934; Tue, 26 May 2015 05:52:41 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp2526265lbb; Tue, 26 May 2015 05:52:40 -0700 (PDT) X-Received: by 10.68.57.239 with SMTP id l15mr29755938pbq.93.1432644760102; Tue, 26 May 2015 05:52:40 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id hn9si20862313pdb.133.2015.05.26.05.52.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2015 05:52:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YxEK4-0004XB-Md; Tue, 26 May 2015 12:51:08 +0000 Received: from mail-pa0-f51.google.com ([209.85.220.51]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YxEJY-0004IK-Gj for linux-arm-kernel@lists.infradead.org; Tue, 26 May 2015 12:50:37 +0000 Received: by padbw4 with SMTP id bw4so92192836pad.0 for ; Tue, 26 May 2015 05:50:15 -0700 (PDT) X-Received: by 10.70.29.164 with SMTP id l4mr48515657pdh.32.1432644615402; Tue, 26 May 2015 05:50:15 -0700 (PDT) Received: from localhost ([180.150.153.56]) by mx.google.com with ESMTPSA id dv9sm12861625pac.4.2015.05.26.05.50.13 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 26 May 2015 05:50:14 -0700 (PDT) From: Hanjun Guo To: Bjorn Helgaas , Arnd Bergmann , Catalin Marinas , Will Deacon , "Rafael J. Wysocki" Subject: [PATCH 02/11] x86, pci: Clean up comment about buggy MMIO config space access for AMD Fam10h CPUs. Date: Tue, 26 May 2015 20:49:15 +0800 Message-Id: <1432644564-24746-3-git-send-email-hanjun.guo@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1432644564-24746-1-git-send-email-hanjun.guo@linaro.org> References: <1432644564-24746-1-git-send-email-hanjun.guo@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150526_055036_614212_9757752F X-CRM114-Status: GOOD ( 10.24 ) X-Spam-Score: -1.8 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.51 listed in list.dnswl.org] -1.1 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.51 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record Cc: Lorenzo Pieralisi , linaro-acpi@lists.linaro.org, linux-pci@vger.kernel.org, Liviu Dudau , linux-kernel@vger.kernel.org, Tomasz Nowicki , linux-acpi@vger.kernel.org, Hanjun Guo , Suravee Suthikulpanit , Mark Salter , Yijing Wang , Thomas Gleixner , Jiang Liu , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: hanjun.guo@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Tomasz Nowicki - fix typo - improve explanation - add reference to the related document Signed-off-by: Tomasz Nowicki Signed-off-by: Hanjun Guo Tested-by: Suravee Suthikulpanit --- arch/x86/include/asm/pci_x86.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h index 164e3f8..eddf8f0 100644 --- a/arch/x86/include/asm/pci_x86.h +++ b/arch/x86/include/asm/pci_x86.h @@ -154,10 +154,13 @@ extern struct list_head pci_mmcfg_list; /* * AMD Fam10h CPUs are buggy, and cannot access MMIO config space - * on their northbrige except through the * %eax register. As such, you MUST - * NOT use normal IOMEM accesses, you need to only use the magic mmio-config + * on their northbridge except through the * %eax register. As such, you MUST + * NOT use normal IOMEM accesses, you need to only use the magic mmio_config_* * accessor functions. - * In fact just use pci_config_*, nothing else please. + * + * Please refer to the following doc: + * "BIOS and Kernel Developer's Guide (BKDG) For AMD Family 10h Processors", + * rev. 3.48, sec 2.11.1, "MMIO Configuration Coding Requirements". */ static inline unsigned char mmio_config_readb(void __iomem *pos) {