From patchwork Fri Sep 4 03:21:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 53064 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by patches.linaro.org (Postfix) with ESMTPS id B6FBE22E3F for ; Fri, 4 Sep 2015 03:22:23 +0000 (UTC) Received: by lbbmp1 with SMTP id mp1sf2571047lbb.2 for ; Thu, 03 Sep 2015 20:22:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=L5a5yA1Si5tHLy+urFkmhI8v4HLDg8316GWWzqlNMss=; b=hsqjximjEDB+TlRr2cpFja1PVOQHlpvMmb7auhTHvGJwa54SpT/uO8u1SvjJQeYEEW ODZvco6OzMvEvITZNi9gFREK7GkG4onsFKfzD3D4zXJruaNaVxfCnEetTNXJN2NBvAvT uxwduQT1IBMxjtqy8sxDY2NHHaZN+H3kNPEk3OdDlI7NwVJ+LesjrEdsAvShNDSD/9Pb hdiTyLcp6omVzVMOBjLj/NSoCxgdayJHVG38fIssJz761INA/2IIXI1SJhaOXXXFQHLH CWzxIiZrNkF973Hc/4VqL5FdzT/YgyQtJ2Ec2IiFdNCxGTvkYog9pjUc8QbKIcEDDtA3 wptw== X-Gm-Message-State: ALoCoQmRkJl0JXbDhDBIv2wywtihxS4l3vP3kiXp+B2QZi+x9stuEBES8fCny3mEV+y8Ilfeb3v7 X-Received: by 10.194.80.69 with SMTP id p5mr355776wjx.2.1441336942442; Thu, 03 Sep 2015 20:22:22 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.204.135 with SMTP id ky7ls300341lac.20.gmail; Thu, 03 Sep 2015 20:22:22 -0700 (PDT) X-Received: by 10.112.158.70 with SMTP id ws6mr1358221lbb.28.1441336942145; Thu, 03 Sep 2015 20:22:22 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com. [209.85.215.53]) by mx.google.com with ESMTPS id b1si927603lbd.146.2015.09.03.20.22.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Sep 2015 20:22:22 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by laeb10 with SMTP id b10so5272936lae.1 for ; Thu, 03 Sep 2015 20:22:22 -0700 (PDT) X-Received: by 10.152.178.165 with SMTP id cz5mr1289242lac.29.1441336942047; Thu, 03 Sep 2015 20:22:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.164.42 with SMTP id yn10csp1660651lbb; Thu, 3 Sep 2015 20:22:21 -0700 (PDT) X-Received: by 10.66.186.141 with SMTP id fk13mr3141779pac.7.1441336941003; Thu, 03 Sep 2015 20:22:21 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id yu5si1768596pbb.32.2015.09.03.20.22.20; Thu, 03 Sep 2015 20:22:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756723AbbIDDWS (ORCPT + 28 others); Thu, 3 Sep 2015 23:22:18 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:34863 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756470AbbIDDWQ (ORCPT ); Thu, 3 Sep 2015 23:22:16 -0400 Received: by lbpo4 with SMTP id o4so4340082lbp.2 for ; Thu, 03 Sep 2015 20:22:14 -0700 (PDT) X-Received: by 10.152.228.135 with SMTP id si7mr1295015lac.77.1441336934779; Thu, 03 Sep 2015 20:22:14 -0700 (PDT) Received: from localhost.localdomain ([46.39.50.164]) by smtp.gmail.com with ESMTPSA id t2sm216126lag.36.2015.09.03.20.22.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Sep 2015 20:22:14 -0700 (PDT) From: Alexey Klimov To: daniel.lezcano@linaro.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com Cc: yingjoe.chen@mediatek.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, klimov.linux@gmail.com, Alexey Klimov Subject: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init Date: Fri, 4 Sep 2015 06:21:39 +0300 Message-Id: <1441336900-15095-2-git-send-email-alexey.klimov@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1441336900-15095-1-git-send-email-alexey.klimov@linaro.org> References: <1441336900-15095-1-git-send-email-alexey.klimov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: alexey.klimov@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , These messages are actually errors and not warnings. Use pr_err() macro for them and add missing \n. Signed-off-by: Alexey Klimov Acked-by: Matthias Brugger --- drivers/clocksource/mtk_timer.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c index ca5ea9e..fbaacbf 100644 --- a/drivers/clocksource/mtk_timer.c +++ b/drivers/clocksource/mtk_timer.c @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node) evt = kzalloc(sizeof(*evt), GFP_KERNEL); if (!evt) { - pr_warn("Can't allocate mtk clock event driver struct"); + pr_err("Can't allocate mtk clock event driver struct\n"); return; } @@ -200,24 +200,24 @@ static void __init mtk_timer_init(struct device_node *node) evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer"); if (IS_ERR(evt->gpt_base)) { - pr_warn("Can't get resource\n"); + pr_err("Can't get resource\n"); return; } evt->dev.irq = irq_of_parse_and_map(node, 0); if (evt->dev.irq <= 0) { - pr_warn("Can't parse IRQ"); + pr_err("Can't parse IRQ\n"); goto err_mem; } clk = of_clk_get(node, 0); if (IS_ERR(clk)) { - pr_warn("Can't get timer clock"); + pr_err("Can't get timer clock\n"); goto err_irq; } if (clk_prepare_enable(clk)) { - pr_warn("Can't prepare clock"); + pr_err("Can't prepare clock\n"); goto err_clk_put; } rate = clk_get_rate(clk); @@ -226,7 +226,7 @@ static void __init mtk_timer_init(struct device_node *node) if (request_irq(evt->dev.irq, mtk_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) { - pr_warn("failed to setup irq %d\n", evt->dev.irq); + pr_err("failed to setup irq %d\n", evt->dev.irq); goto err_clk_disable; }