From patchwork Thu Sep 10 16:00:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 53386 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by patches.linaro.org (Postfix) with ESMTPS id AB4A622B19 for ; Thu, 10 Sep 2015 16:01:04 +0000 (UTC) Received: by lbcao8 with SMTP id ao8sf15546123lbc.1 for ; Thu, 10 Sep 2015 09:01:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=qzLZeQm7nsCHQENZrs9kwQ6YWw62YINUCgLS9A3+tr4=; b=VAk1D6ugnu4Uct1hEQ37kgr+THAN55yQ6P2gOZxaSlGPz969PHWCE4/CoT51BoQ6zd 8M+0IkKH5XO9mN144NnaziOZitOWSyMChG1DO0OxAU9x7v0/i5qlskGm7gER5zPwkaYj H0f36t7qs6eq2LEKFrl+kKDEPzkS27wneAe3KEYe683kgDOGm9GLXrqJGkNt7B/SUDyR 95RZprclpOVojbuCP6oDfcCp9Dt0UHjwhgbhymAZAlTFXLwrmthAqK+qB3FBgHLVqFYV MaZcokz6RdOraVGfu4vEnv57WQ1MektMm5R+3WX5Hbu0UVmbOdaml9PPDVZTMuem+zYa o+PA== X-Gm-Message-State: ALoCoQndL8eUY+bEW9ElXszVUd6mPTzvqpOEuZGaBZrhXi7oMgZpAi6nUsykJFL8gusVRcG3Dtyw X-Received: by 10.194.118.65 with SMTP id kk1mr9965031wjb.5.1441900863604; Thu, 10 Sep 2015 09:01:03 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.28.170 with SMTP id c10ls222646lah.14.gmail; Thu, 10 Sep 2015 09:01:03 -0700 (PDT) X-Received: by 10.152.21.103 with SMTP id u7mr35962041lae.49.1441900863393; Thu, 10 Sep 2015 09:01:03 -0700 (PDT) Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com. [209.85.217.179]) by mx.google.com with ESMTPS id s12si10829238lbp.106.2015.09.10.09.01.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2015 09:01:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) client-ip=209.85.217.179; Received: by lbbmp1 with SMTP id mp1so25781727lbb.1 for ; Thu, 10 Sep 2015 09:01:03 -0700 (PDT) X-Received: by 10.152.26.41 with SMTP id i9mr8568104lag.36.1441900863202; Thu, 10 Sep 2015 09:01:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1062135lbq; Thu, 10 Sep 2015 09:01:01 -0700 (PDT) X-Received: by 10.50.70.34 with SMTP id j2mr8060756igu.54.1441900861411; Thu, 10 Sep 2015 09:01:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gb7si690376igd.85.2015.09.10.09.01.00; Thu, 10 Sep 2015 09:01:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036AbbIJQA7 (ORCPT + 28 others); Thu, 10 Sep 2015 12:00:59 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:36631 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbbIJQAx (ORCPT ); Thu, 10 Sep 2015 12:00:53 -0400 Received: by wicgb1 with SMTP id gb1so30846169wic.1 for ; Thu, 10 Sep 2015 09:00:52 -0700 (PDT) X-Received: by 10.194.205.68 with SMTP id le4mr77356902wjc.74.1441900852486; Thu, 10 Sep 2015 09:00:52 -0700 (PDT) Received: from localhost.localdomain (cag06-7-83-153-85-71.fbx.proxad.net. [83.153.85.71]) by smtp.gmail.com with ESMTPSA id xs1sm16383982wjc.7.2015.09.10.09.00.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Sep 2015 09:00:51 -0700 (PDT) From: Ard Biesheuvel To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, msalter@redhat.com Cc: Ard Biesheuvel Subject: [PATCH] mm/early_ioremap: add explicit #include of asm/early_ioremap.h Date: Thu, 10 Sep 2015 18:00:48 +0200 Message-Id: <1441900848-18527-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ard.biesheuvel@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Commit 6b0f68e32ea8 ("mm: add utility for early copy from unmapped ram") introduces a function copy_from_early_mem() into mm/early_ioremap.c which itself calls early_memremap()/early_memunmap(). However, since early_memunmap() has not been declared yet at this point in the .c file, nor by any explicitly included header files, we are depending on a transitive include of asm/early_ioremap.h to declare it, which is fragile. So instead, include this header explicitly. Signed-off-by: Ard Biesheuvel Acked-by: Mark Salter --- I ran into this by accident when trying to enable to the generic ioremap implementation for 32-bit ARM. mm/early_ioremap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/early_ioremap.c b/mm/early_ioremap.c index 23f744d77ce0..17ae14b5aefa 100644 --- a/mm/early_ioremap.c +++ b/mm/early_ioremap.c @@ -15,6 +15,7 @@ #include #include #include +#include #ifdef CONFIG_MMU static int early_ioremap_debug __initdata;