From patchwork Fri Oct 23 10:43:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Nan X-Patchwork-Id: 55477 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lf0-f69.google.com (mail-lf0-f69.google.com [209.85.215.69]) by patches.linaro.org (Postfix) with ESMTPS id 6D92922A9D for ; Fri, 23 Oct 2015 10:44:29 +0000 (UTC) Received: by lfu67 with SMTP id 67sf20632687lfu.2 for ; Fri, 23 Oct 2015 03:44:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:content-type:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=JIKgbTM48wZEaoUBMw6ZZD0/QIvv8ashbbqQvcwAcZs=; b=F2Dqqi2Arp4H01ELttV2ut5tcYKQqq1Pl+ZPrbHyVUfHZVqpMuJlrBappjalXjnVuP 1K3DbhjlPc0dwJVd6U6FJCNiT9ndR01AUPwIWHJ9Txpr7Ep/QuHHzfqKJ9kIb4PE6Wz+ hiOVyd1I86y+7vtNhXkkqZ5BYi0qKDH6Y0SJaSOS60mBfrNLXxwgX3ESrXji1+ZQNUIl KuxCYOeeV6y5RbKfW1aphaeES4lxClhg8fBkyJKT28+5/opzGglVhgMlQ1WGYa6sX0J6 LD9Qr3AVA+WoPOyEfM9LpxADuyW3u8E5UJFHefspcYPM5oJsIBueXvPEsfBg+pEaXIEA 4PUg== X-Gm-Message-State: ALoCoQmbzT35DUTHsBx+bSzwR3sjn0bUyCQS89XOTA4nqu1m6xtIsL1bE2W3ukx8z3TW0ujiO54h X-Received: by 10.194.2.146 with SMTP id 18mr580406wju.0.1445597068370; Fri, 23 Oct 2015 03:44:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.29.148 with SMTP id d142ls365817lfd.27.gmail; Fri, 23 Oct 2015 03:44:28 -0700 (PDT) X-Received: by 10.25.160.133 with SMTP id j127mr6897946lfe.85.1445597068185; Fri, 23 Oct 2015 03:44:28 -0700 (PDT) Received: from mail-lf0-f42.google.com (mail-lf0-f42.google.com. [209.85.215.42]) by mx.google.com with ESMTPS id jm1si12286877lbc.135.2015.10.23.03.44.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Oct 2015 03:44:28 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.42 as permitted sender) client-ip=209.85.215.42; Received: by lfaz124 with SMTP id z124so78867343lfa.1 for ; Fri, 23 Oct 2015 03:44:28 -0700 (PDT) X-Received: by 10.112.139.201 with SMTP id ra9mr10908670lbb.29.1445597068012; Fri, 23 Oct 2015 03:44:28 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1140004lbq; Fri, 23 Oct 2015 03:44:27 -0700 (PDT) X-Received: by 10.107.130.101 with SMTP id e98mr24459088iod.77.1445597067089; Fri, 23 Oct 2015 03:44:27 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b74si15031000iob.205.2015.10.23.03.44.26; Fri, 23 Oct 2015 03:44:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbbJWKoY (ORCPT + 28 others); Fri, 23 Oct 2015 06:44:24 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:27044 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbbJWKoX (ORCPT ); Fri, 23 Oct 2015 06:44:23 -0400 Received: from 172.24.1.49 (EHLO szxeml425-hub.china.huawei.com) ([172.24.1.49]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CUY44913; Fri, 23 Oct 2015 18:44:05 +0800 (CST) Received: from linux-4hy3.site (10.107.193.248) by szxeml425-hub.china.huawei.com (10.82.67.180) with Microsoft SMTP Server id 14.3.235.1; Fri, 23 Oct 2015 18:43:55 +0800 From: Wang Nan To: CC: , Wang Nan , "Arnaldo Carvalho de Melo" , Alexei Starovoitov , Peter Zijlstra , Li Zefan , Subject: [RFC PATCH] perf tools: Don't set inherit bit for system wide evsel Date: Fri, 23 Oct 2015 10:43:49 +0000 Message-ID: <1445597029-133332-1-git-send-email-wangnan0@huawei.com> X-Mailer: git-send-email 1.8.3.4 MIME-Version: 1.0 X-Originating-IP: [10.107.193.248] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: wangnan0@huawei.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.42 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Inherit bit is useless for a system wide evsel [1]. Further kernel improvements are giving more constrain [2] on inherit events. This patch set inherit bit to 0 to avoid potential constrains. [1] http://lkml.kernel.org/r/20151022124142.GQ17308@twins.programming.kicks-ass.net [2] http://lkml.kernel.org/r/1445559014-4667-1-git-send-email-ast@kernel.org Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov Cc: Peter Zijlstra Cc: Li Zefan Cc: pi3orama@163.com Link: http://lkml.kernel.org/n/ebpf-0tgilipxoo6fiebcxu3ft866@git.kernel.org --- evsel->system_wide doesn't correct reflect whether this evsel is system wide or not, so checks pid when invoking perf_event_open, and it is always correct. --- tools/perf/util/evsel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 5566b16..e2d6c9a 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1337,6 +1337,7 @@ retry_sample_id: for (thread = 0; thread < nthreads; thread++) { int group_fd; + struct perf_event_attr attr; if (!evsel->cgrp && !evsel->system_wide) pid = thread_map__pid(threads, thread); @@ -1346,7 +1347,10 @@ retry_open: pr_debug2("sys_perf_event_open: pid %d cpu %d group_fd %d flags %#lx\n", pid, cpus->map[cpu], group_fd, flags); - FD(evsel, cpu, thread) = sys_perf_event_open(&evsel->attr, + attr = evsel->attr; + if (pid == -1) + attr.inherit = 0; + FD(evsel, cpu, thread) = sys_perf_event_open(&attr, pid, cpus->map[cpu], group_fd, flags);