From patchwork Wed Nov 11 22:18:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 56397 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp75116lbb; Wed, 11 Nov 2015 14:20:19 -0800 (PST) X-Received: by 10.68.95.129 with SMTP id dk1mr18263230pbb.23.1447280418512; Wed, 11 Nov 2015 14:20:18 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ir5si15226884pbb.212.2015.11.11.14.20.15; Wed, 11 Nov 2015 14:20:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbbKKWT4 (ORCPT + 28 others); Wed, 11 Nov 2015 17:19:56 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33784 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112AbbKKWTr (ORCPT ); Wed, 11 Nov 2015 17:19:47 -0500 Received: by pabfh17 with SMTP id fh17so42988610pab.0 for ; Wed, 11 Nov 2015 14:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZveGRFUbK7wsnlmCbRWblmTSGPdv1ppgv9Wh1RwsYmo=; b=jz6DbayIuggwTha5s22s6J1IIIQlnnVBDyMsx9vWZgdXC4jDPNvvcxaxr4HerDprP2 pr0TyXr44AAD3+u6Be0NzZFmV67Z4cG16+8e7dV+Lds7ZCUUBtQ5DjPoxMSnkIEEbob/ 34tirUc43PPnLzBTVrpFZ/ScVldDVAF2+68cXK4cXuMd6rfb56t7/QQ9DvrhDZy6LoQu soTsus6yfQS1RFtR1zPwaDQOXqm+6VQ7ltkovIg7MCa9zGsTbCqVy7K0/9iVRk+b5z/5 Yym+k0Un5pEgq3rQV6DSk+f1YRtU0o7Vd8Er04o40EjBvKUBqfgKLKtwo6xzimGI1EMm KpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZveGRFUbK7wsnlmCbRWblmTSGPdv1ppgv9Wh1RwsYmo=; b=RVlLHNHJ+yGloMBEprZp/0g4tbE0fPz5z6Fh6i9+tYxEzkD77vCO/u15LOeLVVuRT+ nqCtrekG41Wqb3PwyeMJPW8HiHPXmXEYvHM+n1EDUNqpkpLiX0ONjIWDu1LTqGBx4CJN kqmIrV82AnYpFsRHtnDXRxkaLBxExcJ3WUgjS2EZNj0IoAVCHBTFpkvfKRUbyXERv/+i ldpXbk30ivjTeFQFLfu0vRYuUYT3Ae9giFlBqiC5CHZLlvCzbvNqvSEn0wNYNF0dBGlH sDlsSXoB6tDdf/rODM0swQ14UmXrEsj2JbHOq7Z+IKClFVoWf6NBczSB2+JlwoX/HoCQ DgPg== X-Gm-Message-State: ALoCoQn/HP3miND2iSpmaBi8tn4uBXTr2im5qA9P/fgABnNgnGlhMDg4ISwuDwBWu+5rNduCLBbf X-Received: by 10.66.228.3 with SMTP id se3mr17657009pac.75.1447280386876; Wed, 11 Nov 2015 14:19:46 -0800 (PST) Received: from t430.cg.shawcable.net ([184.64.168.246]) by smtp.gmail.com with ESMTPSA id h10sm11156697pat.7.2015.11.11.14.19.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Nov 2015 14:19:46 -0800 (PST) From: Mathieu Poirier To: gregkh@linuxfoundation.org, a.p.zijlstra@chello.nl, alexander.shishkin@linux.intel.com, acme@kernel.org, mingo@redhat.com, corbet@lwn.net, nicolas.pitre@linaro.org Cc: adrian.hunter@intel.com, zhang.chunyan@linaro.org, mike.leach@arm.com, tor@ti.com, al.grant@arm.com, pawel.moll@arm.com, fainelli@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH V3 17/26] coresight: etb10: moving to local atomic operations Date: Wed, 11 Nov 2015 15:18:07 -0700 Message-Id: <1447280296-19147-18-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447280296-19147-1-git-send-email-mathieu.poirier@linaro.org> References: <1447280296-19147-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Moving to use local atomic operations to take advantage of the lockless implementation, something that will come handy when the ETB is accessed from the Perf subsystem. Also changing the name of the variable to something more meaningful. Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etb10.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 1301edc44629..09e306361e4f 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -10,6 +10,7 @@ * GNU General Public License for more details. */ +#include #include #include #include @@ -71,7 +72,7 @@ * @csdev: component vitals needed by the framework. * @miscdev: specifics to handle "/dev/xyz.etb" entry. * @spinlock: only one at a time pls. - * @in_use: synchronise user space access to etb buffer. + * @reading: synchronise user space access to etb buffer. * @buf: area of memory where ETB buffer content gets sent. * @buffer_depth: size of @buf. * @enable: this ETB is being used. @@ -84,7 +85,7 @@ struct etb_drvdata { struct coresight_device *csdev; struct miscdevice miscdev; spinlock_t spinlock; - atomic_t in_use; + local_t reading; u8 *buf; u32 buffer_depth; bool enable; @@ -277,7 +278,7 @@ static int etb_open(struct inode *inode, struct file *file) struct etb_drvdata *drvdata = container_of(file->private_data, struct etb_drvdata, miscdev); - if (atomic_cmpxchg(&drvdata->in_use, 0, 1)) + if (local_cmpxchg(&drvdata->reading, 0, 1)) return -EBUSY; dev_dbg(drvdata->dev, "%s: successfully opened\n", __func__); @@ -313,7 +314,7 @@ static int etb_release(struct inode *inode, struct file *file) { struct etb_drvdata *drvdata = container_of(file->private_data, struct etb_drvdata, miscdev); - atomic_set(&drvdata->in_use, 0); + local_set(&drvdata->reading, 0); dev_dbg(drvdata->dev, "%s: released\n", __func__); return 0;