From patchwork Fri Jan 29 11:39:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101040 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1058659lbb; Fri, 29 Jan 2016 03:41:34 -0800 (PST) X-Received: by 10.66.156.195 with SMTP id wg3mr12649101pab.54.1454067686494; Fri, 29 Jan 2016 03:41:26 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ky14si2885388pab.41.2016.01.29.03.41.26; Fri, 29 Jan 2016 03:41:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932300AbcA2LlW (ORCPT + 30 others); Fri, 29 Jan 2016 06:41:22 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:54047 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755358AbcA2LlR (ORCPT ); Fri, 29 Jan 2016 06:41:17 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0Mg2TZ-1alsxV3WnF-00NO9z; Fri, 29 Jan 2016 12:40:44 +0100 From: Arnd Bergmann To: David Miller Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , netdev@vger.kernel.org, =?utf-8?b?TcOlbnMgUnVsbGfDpXJk?= , linux-kernel@vger.kernel.org Subject: [PATCH v2 6/7] net: nb8800: avoid uninitialized variable warning Date: Fri, 29 Jan 2016 12:39:14 +0100 Message-Id: <1454067557-3546883-7-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1454067557-3546883-1-git-send-email-arnd@arndb.de> References: <1454067557-3546883-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:7tyQwf2yFdOl9jnOV/bq7uEieeYowMo0nJgB9J1c7gg8H7vCb2m QwtfAKhD1qL/jQucwnAjrSvMsSWskH/n5wSFwdDOUp4asp8vOez1gx3VIJfwsJ8WtG6BBAx M2zh3Fx1StGmPfDKi/bp4sQXqXvSePRN/UqpF7S1oj5dGUbYzLOXlvK8ouuuUGxblamWOXn M9XUzSHVyUbpzpkrUideQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:DOaT80U0qmI=:Dksrf2f9+V/Da+pm9yFjbt 4bxkVsFLPyfis2Uu8pMe0uwKpQSjoRtzdeopCnBW5C5ugvsQn4MCzafU4Kfvw1goSbkzKf7gG LOmO6b0yEYB1MooMw2SzolC3IdSRUIQ8++aTlQtrUGgyqthCaR7ffM1tHnQT7REGy83yXhr/S OVNmDcU3dh36dLpdwUvzlUjm+0QWpOW3ggJuc6OZ3DEO/69PF3fEg7gwGjK4s1uzhZcaD2b7I z0bZgrYat1nxjhpmcPTIQChMuvhacrZVS2OxiE5mf/Gz/tAuX8BS5yStYOZVaMcfP5MXJXyKP ZVLrU065DKx801T398xK2m3P/7vQFWS59gxG/jRJWmf0IRLp+XY2a09gWnqawmm5yi8sGru5m wDD79qCdqKt0Qsk1aovhs/zLuoZ0CM8BF81ZaALXHz6NOW4Ko9DUNJo53FYmGEpU7Zn7X1bYU t7oclarkF1vz1FHpD3MYqS8YFpPFKVJ6t1/5rhpICH8EpHiThM2dzJ+2PiUtphfToDHXMPAWl pScmWWW1AmdKI/jXMkip5ZjYFbJTRtAnn8wpPXIZJTlXDSBixMuDX/mIq42zygvl38Hzt8zN0 MHKOWqpkjeWyVGDxu28/b6OBnSE22hI6yYmHFqyoHbeJE3ydNx7SyJLwzBflthvtgC/OqDchZ WA2HDQ08WhXCgYIR/fwUTeFypRWRjH+yD5/vVd7pLqkfTTFQRT42Pov7UNtpDB5SbTHA= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The nb8800_poll() function initializes the 'next' variable in the loop looking for new input data. We know this will be called at least once because 'budget' is a guaranteed to be a positive number when we enter the function, but the compiler doesn't know that and warns when the variable is used later: drivers/net/ethernet/aurora/nb8800.c: In function 'nb8800_poll': drivers/net/ethernet/aurora/nb8800.c:350:21: warning: 'next' may be used uninitialized in this function [-Wmaybe-uninitialized] Changing the 'while() {}' loop to 'do {} while()' makes it obvious to the compiler what is going on so it no longer warns. Signed-off-by: Arnd Bergmann Acked-by: Mans Rullgard --- drivers/net/ethernet/aurora/nb8800.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.0 diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index ecc4a334c507..f71ab2647a3b 100644 --- a/drivers/net/ethernet/aurora/nb8800.c +++ b/drivers/net/ethernet/aurora/nb8800.c @@ -302,7 +302,7 @@ static int nb8800_poll(struct napi_struct *napi, int budget) nb8800_tx_done(dev); again: - while (work < budget) { + do { struct nb8800_rx_buf *rxb; unsigned int len; @@ -330,7 +330,7 @@ again: rxd->report = 0; last = next; work++; - } + } while (work < budget); if (work) { priv->rx_descs[last].desc.config |= DESC_EOC;