From patchwork Mon Feb 8 13:36:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102835 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp1442018lbl; Mon, 8 Feb 2016 05:37:41 -0800 (PST) X-Received: by 10.98.42.213 with SMTP id q204mr42326007pfq.141.1454938661152; Mon, 08 Feb 2016 05:37:41 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9si46656290pas.124.2016.02.08.05.37.40; Mon, 08 Feb 2016 05:37:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbcBHNhi (ORCPT + 30 others); Mon, 8 Feb 2016 08:37:38 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:53434 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753388AbcBHNhd (ORCPT ); Mon, 8 Feb 2016 08:37:33 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue102) with ESMTPA (Nemesis) id 0M4ZiO-1a5aFF2rPA-00yjLA; Mon, 08 Feb 2016 14:36:37 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman , Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Eddie Huang , Sascha Hauer , Paul Gortmaker , Matt Redfearn , Paul Burton , Jiri Slaby , linux-serial@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] 8250: mediatek: mark PM functions as __maybe_unused Date: Mon, 8 Feb 2016 14:36:13 +0100 Message-Id: <1454938591-2743892-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:TGY+M4BhHAf63NIYK4Q4o2xYzO+Wu9cXz5Ucs1v0RMbDa1N8w7q VkxtDU7k8d7kwb8TMir4A28XsArT2CeA6n4YqgYr1xyTgvSgAj759uUEJwENp7bCkyO9XmT mUhi14+7EeIXb2ZINwBGzEpEFC15fvNw/dHpWJBwLzM8UVg3vww6OwseVnFxkzOTpbXhyfx eWZMwZIFjHOPxw6uw77TA== X-UI-Out-Filterresults: notjunk:1; V01:K0:0Ob1NOjkG7Q=:DlUU8uRcBizIRb3ChvTkR2 yjuX8Fgi7TOY+XckixcZwXWqVphajeOnnb1U7pQmtE6YM2Lo0bA8SHHPTep5FKV4SNV7Ld9xb xlgI1fmmES34s6pxlWyh7xvjZnSQdnkHbSA7dQyBZsEUqCtLDCsMRCbFKuA+wZt9Bjx0xQSuo 3j46KQXtDRHU1a7+4GFyLbcK/GfmKCRFhMUoEG6EhxgokRYhRDhN9+C9QAJVwx1N1TV8E0RHQ rvEeFPA+8LJ6ymEXCXJrzUiNlMEU/HfpcyeYtLMUXWJYg1fypbh8b82RwCae1VB7ClO/7ucLG 7ca863olhQYw6MW+T+TSRhPiIRWDckItMNoqfmTE92AqUoZ1uUoVWGQZnz395t7oHupX7MrGm Ej/3V3OCWz4uoS0kpilXNh2CE5DfhdkHtczDJ1L9pCSM+M5iO+f9gnXuOswb0YhVBPsJ/Arbk 9Rkxl4iDCMhb+HXDEbr/ICh8yCC/k0DeISxhkuMPypN0uG0ROp/Wej3iuyWshssPIOJBPdZJ3 WFQ8o/u1IIoqY3IuT8Jo60Q1JHEMXKr5QnvZCYKVBx68/M+PNDMUF6Wsx5RiBez6zg3zXin3n M6+jLAHRTWJGP02STxqoQF2uDIw6yyDmpZ86T6EQ9Nyf8PeGRoFyllHh7ABdRrU+4x80ntmjt 2v8Rxkk7PEtbKnsiQYfzAkOu1lhD8MgshuxkVYB/KxQJ+8yrH7rVz88fXUL7MjjRUPlM= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The mtk8250_runtime_suspend function is not used when runtime PM is disabled, so we get a warning about an unused function: drivers/tty/serial/8250/8250_mtk.c:119:12: error: 'mtk8250_runtime_suspend' defined but not used [-Werror=unused-function] static int mtk8250_runtime_suspend(struct device *dev) This marks all the PM functions as __maybe_unused to avoid the warning, and removes the #ifdef around the PM_SLEEP functions for consistency. Signed-off-by: Arnd Bergmann --- drivers/tty/serial/8250/8250_mtk.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.7.0 diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c index 0e590b233f03..9038843cadc7 100644 --- a/drivers/tty/serial/8250/8250_mtk.c +++ b/drivers/tty/serial/8250/8250_mtk.c @@ -116,7 +116,7 @@ mtk8250_set_termios(struct uart_port *port, struct ktermios *termios, tty_termios_encode_baud_rate(termios, baud, baud); } -static int mtk8250_runtime_suspend(struct device *dev) +static int __maybe_unused mtk8250_runtime_suspend(struct device *dev) { struct mtk8250_data *data = dev_get_drvdata(dev); @@ -126,7 +126,7 @@ static int mtk8250_runtime_suspend(struct device *dev) return 0; } -static int mtk8250_runtime_resume(struct device *dev) +static int __maybe_unused mtk8250_runtime_resume(struct device *dev) { struct mtk8250_data *data = dev_get_drvdata(dev); int err; @@ -245,8 +245,7 @@ static int mtk8250_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP -static int mtk8250_suspend(struct device *dev) +static int __maybe_unused mtk8250_suspend(struct device *dev) { struct mtk8250_data *data = dev_get_drvdata(dev); @@ -255,7 +254,7 @@ static int mtk8250_suspend(struct device *dev) return 0; } -static int mtk8250_resume(struct device *dev) +static int __maybe_unused mtk8250_resume(struct device *dev) { struct mtk8250_data *data = dev_get_drvdata(dev); @@ -263,7 +262,6 @@ static int mtk8250_resume(struct device *dev) return 0; } -#endif /* CONFIG_PM_SLEEP */ static const struct dev_pm_ops mtk8250_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(mtk8250_suspend, mtk8250_resume)