From patchwork Mon Mar 14 22:51:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102575 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp318440lbc; Mon, 14 Mar 2016 15:52:12 -0700 (PDT) X-Received: by 10.66.228.1 with SMTP id se1mr23357821pac.43.1457995931971; Mon, 14 Mar 2016 15:52:11 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r83si13769592pfi.191.2016.03.14.15.52.11; Mon, 14 Mar 2016 15:52:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932867AbcCNWwK (ORCPT + 31 others); Mon, 14 Mar 2016 18:52:10 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:57809 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752964AbcCNWwI (ORCPT ); Mon, 14 Mar 2016 18:52:08 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue004) with ESMTPA (Nemesis) id 0MAASz-1aYlps3nxp-00BKsW; Mon, 14 Mar 2016 23:51:34 +0100 From: Arnd Bergmann To: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman Cc: Arnd Bergmann , Andrew Morton , James Simmons , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: lustre: really make lustre dependent on LNet Date: Mon, 14 Mar 2016 23:51:09 +0100 Message-Id: <1457995886-1592279-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:nRd/phYNsv1z5IiuGMMHP6Rv16sBwjLHTPfuN6LACjzOt/0JujB n7UGQZncNNRQu3/gINoC99/T7W5VO9aUPzrrebuF/B14WJaCMVy5PXdzOH+FTCCvxwdUYqw nyNr058+RwXm9Tq2WXgW11op/pjMOxDO72ATv+kacAC3lW2+ueyzs8cgIuzSh7536SQwZHu uCPbe0QxBS2jzIyv4ugJA== X-UI-Out-Filterresults: notjunk:1; V01:K0:Su8yza2SkeE=:I093cKgjAnFP7zKXuPMYM5 TWWSPT3ApQTFau1eWOaJ0a8Cnp9uHIuHh9t5fAFh9bswWLFyzS78GUY+/qpTcTfh/N18+ip6p MuzSxzYTfXi/6X8Ur5U6JlLWVslP54zsTWzPDULondmhoV03Jn5NHx4lylXSXmRQ3rYr5h2Jl +TMGKBF/HUCqFTpS6NlJBPZsEZP0tGmBuwRhueQhKy32Tb5Jn/BMzGle5eZYwFjkDGq/QMu8Q Q/ur4NgpPOvEaMokxffQLXH/dELgd660URL05NOiemclWPBqL4Np8Jbp+/5EbTDeoJxpk+0JJ qrdPqweLusKMxezWjCjfa8JrfbtVwDFz7d3NheqIgOnJ47eenQbdpjKWj6J5Pu/Eyqypmkvje G50K6fhe0WNxEGge7+b7K5eirYbO5TvpwmpHspPW0B1ZYsK6M8QOnxXUaBK+8xAtF0M6IkZFk Uqr+JNbnP/3wNhzQKGoa9fMjmEVw/EWeiRa9I/Op00w1REBP3A/5L/4Ph3YMMOMmYT3qifpbp vG5dWeLNMtuIGKnNZTLk7w8lKEGXDIgz1GNYGhzHiK5+ZrhRyOZRS0vSU55VGYGKODI2TGwgF ebSoxedmdrnVBAKwFKqqVf/OaeUgACCye8zLzMQLEAREs5aXpR0tnOkOJHSsocvcH5d4NrKI3 VnMYOwwzRxNskJ/Y/Ju2cgcSm6Z+X/dUapkgUmrHL6D0lnrLoR0si4N3CsQtyH24jOZQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A patch intended to add a dependency on LNET for lustre didn't actually do that and instead allowed configurations that contain lustre with lnet but without IPv4 support that subsequently fail to link: warning: (LUSTRE_FS) selects LNET which has unmet direct dependencies (STAGING && INET && m && MODULES) ERROR: "kernel_sendmsg" [drivers/staging/lustre/lnet/lnet/lnet.ko] undefined! ERROR: "sock_create_lite" [drivers/staging/lustre/lnet/lnet/lnet.ko] undefined! ERROR: "sock_release" [drivers/staging/lustre/lnet/lnet/lnet.ko] undefined! ERROR: "release_sock" [drivers/staging/lustre/lnet/klnds/socklnd/ksocklnd.ko] undefined! ERROR: "kernel_sendmsg" [drivers/staging/lustre/lnet/klnds/socklnd/ksocklnd.ko] undefined! ERROR: "tcp_sendpage" [drivers/staging/lustre/lnet/klnds/socklnd/ksocklnd.ko] undefined! This adds the one-line change that was evidently missing from the commit, doing what was intended there to have a correct set of dependencies. Signed-off-by: Arnd Bergmann Fixes: b08bb6bb5af5 ("staging: lustre: make lustre dependent on LNet") --- drivers/staging/lustre/lustre/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig index a09b51ce8265..8ac7cd4d6fdb 100644 --- a/drivers/staging/lustre/lustre/Kconfig +++ b/drivers/staging/lustre/lustre/Kconfig @@ -1,7 +1,7 @@ config LUSTRE_FS tristate "Lustre file system client support" depends on m && !MIPS && !XTENSA && !SUPERH - select LNET + depends on LNET select CRYPTO select CRYPTO_CRC32 select CRYPTO_CRC32_PCLMUL if X86