From patchwork Fri Apr 8 12:58:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 65406 Delivered-To: patch@linaro.org Received: by 10.112.43.237 with SMTP id z13csp53410lbl; Fri, 8 Apr 2016 05:59:15 -0700 (PDT) X-Received: by 10.107.13.65 with SMTP id 62mr9317869ion.186.1460120355811; Fri, 08 Apr 2016 05:59:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ro9si3336179igb.34.2016.04.08.05.59.15; Fri, 08 Apr 2016 05:59:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758430AbcDHM7N (ORCPT + 29 others); Fri, 8 Apr 2016 08:59:13 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:33871 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbcDHM7L (ORCPT ); Fri, 8 Apr 2016 08:59:11 -0400 Received: by mail-pf0-f176.google.com with SMTP id c20so75915242pfc.1 for ; Fri, 08 Apr 2016 05:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=3Qi84GsE091QUXhvy+AJWvIte2JHbwzCIp9j5BGgwS0=; b=iV7nYtybrIsAGcGBQ8xNmG8MMglZ70wpVJQSTIwWpV1Y2iwHGTn5RqfAzqiyRO6D8R GYRa5y3LTpMVycvqYLrNhFyyD01am9Pspuz4dhNFaRwGiiMxHGL/JDXTlgqhyutCyZxA Ln149bEA9TiiHb5q3EyXaOh32J70hcKMmyK1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3Qi84GsE091QUXhvy+AJWvIte2JHbwzCIp9j5BGgwS0=; b=PfIC+iX2ogWlGvMuIIoHo/dJ3oTahVPZZ1rg3gSBbhoQBX89sn2IpDKli+L4h6FHdX 914wECq7ld967HklFiC5N4yy7iT9r877VnfIP08YH3ekeBnBhSxcf175u7x5a5On3hTp Ct/n+2MyLpY/Md37eNOPqLfdCxWVia9maKlUe1IYlWWQ3mkxFo+i3GkJYbGWrQ0kZaJL kRfBQSeQ84M42IxXhNurO4jN6oTPxifwRRVl1EptuwrAxp6eH1zH4ZX/6pPACRprkFT/ vm5wrTZ864jHY69Jo2n4hvlC1vd4qdDZ/Jm8JIwvyOsoKIApPwxTcnFkbbb/CvUWzeGK Cvbg== X-Gm-Message-State: AD7BkJKYgXCyVQmUMP5+f27Jvgwy7XboYR4ZwLUDPhc9KPbWqTp2BqE7NJOu4O3HQdP/SauR X-Received: by 10.98.13.216 with SMTP id 85mr12365628pfn.143.1460120350381; Fri, 08 Apr 2016 05:59:10 -0700 (PDT) Received: from zcy-ubuntu.spreadtrum.com ([175.111.195.49]) by smtp.gmail.com with ESMTPSA id r68sm18798425pfa.33.2016.04.08.05.59.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Apr 2016 05:59:09 -0700 (PDT) From: Chunyan Zhang To: alexander.shishkin@linux.intel.com Cc: linux-kernel@vger.kernel.org, zhang.lyra@gmail.com, mathieu.poirier@linaro.org Subject: [PATCH v2] stm class: correct masterID range in setting via sysfs Date: Fri, 8 Apr 2016 20:58:16 +0800 Message-Id: <1460120296-1794-1-git-send-email-zhang.chunyan@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The type of masterID is defined as 'unsigned int', theoretically one can set masterID with a number larger than 'INT_MAX' as long as 'stm_data::sw_end' is larger than 'INT_MAX'. Also, 'stm_data::start' and 'stm_data::end' is initialized in respective drivers which should be able to use any value less than 'UINT_MAX' for their masterIDs, of course including those values larger than 'INT_MAX', but the current policy is wrongly assuming that masterIDs would not be larger than 'INT_MAX'. This patch just corrected that. Signed-off-by: Chunyan Zhang --- drivers/hwtracing/stm/policy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.9.1 diff --git a/drivers/hwtracing/stm/policy.c b/drivers/hwtracing/stm/policy.c index 1db1896..e8b50b1 100644 --- a/drivers/hwtracing/stm/policy.c +++ b/drivers/hwtracing/stm/policy.c @@ -107,8 +107,7 @@ stp_policy_node_masters_store(struct config_item *item, const char *page, goto unlock; /* must be within [sw_start..sw_end], which is an inclusive range */ - if (first > INT_MAX || last > INT_MAX || first > last || - first < stm->data->sw_start || + if (first > last || first < stm->data->sw_start || last > stm->data->sw_end) { ret = -ERANGE; goto unlock;