From patchwork Tue May 24 16:12:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 68523 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp722053qge; Tue, 24 May 2016 09:12:18 -0700 (PDT) X-Received: by 10.66.183.168 with SMTP id en8mr8068702pac.64.1464106338353; Tue, 24 May 2016 09:12:18 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si5563151pat.170.2016.05.24.09.12.18; Tue, 24 May 2016 09:12:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755689AbcEXQMO (ORCPT + 30 others); Tue, 24 May 2016 12:12:14 -0400 Received: from foss.arm.com ([217.140.101.70]:58459 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbcEXQMM (ORCPT ); Tue, 24 May 2016 12:12:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 94E542F; Tue, 24 May 2016 09:12:34 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.207.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B5E483F557; Tue, 24 May 2016 09:12:10 -0700 (PDT) From: Sudeep Holla To: Lee Jones , Jassi Brar Cc: linux-kernel@vger.kernel.org, Sudeep Holla , Jassi Brar Subject: [PATCH] mailbox: mailbox-test: set tdev->signal to NULL after freeing Date: Tue, 24 May 2016 17:12:04 +0100 Message-Id: <1464106324-25005-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tdev->signal is not set NULL after it's freed. This will cause random exceptions when the stale pointer is accessed after tdev->signal is freed. Also, since tdev->signal allocation is skipped the next time it's written, this leads to continuous fault finally leading to the total death of the system. Cc: Lee Jones Cc: Jassi Brar Fixes: d1c2f87c9a8f ("mailbox: mailbox-test: Prevent memory leak") Signed-off-by: Sudeep Holla --- drivers/mailbox/mailbox-test.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 Acked-by: Lee Jones diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index 58d04726cdd7..9ca96e9db6bf 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -133,6 +133,7 @@ static ssize_t mbox_test_message_write(struct file *filp, out: kfree(tdev->signal); kfree(tdev->message); + tdev->signal = NULL; return ret < 0 ? ret : count; }