From patchwork Thu Jul 7 08:01:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 71508 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp1271333qgy; Thu, 7 Jul 2016 01:03:43 -0700 (PDT) X-Received: by 10.66.83.35 with SMTP id n3mr49482805pay.124.1467878622174; Thu, 07 Jul 2016 01:03:42 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i83si2997187pfk.69.2016.07.07.01.03.41; Thu, 07 Jul 2016 01:03:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933427AbcGGID2 (ORCPT + 30 others); Thu, 7 Jul 2016 04:03:28 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36641 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756274AbcGGIDS (ORCPT ); Thu, 7 Jul 2016 04:03:18 -0400 Received: by mail-wm0-f45.google.com with SMTP id f126so200123680wma.1 for ; Thu, 07 Jul 2016 01:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9xx9ud0jmuaV7LxadLQ0AYjN5rqoVBzHb2jRCUhav0E=; b=TSYpFAQA3GYL6qt4H23sucClwQ5dI1B+WzKNJDa+kBGg/YbL6jxDfDg8IVmRg5PMcg rMq78LrkM718HUA4tN/hfDbZ7PIQZ6hI7NFdSl0cyczWrBuGMzU28+RcVNktRcBvj4Ct /9k7swOJHG/HYAvdDTBlSVNNhenc0Jx/F04NY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9xx9ud0jmuaV7LxadLQ0AYjN5rqoVBzHb2jRCUhav0E=; b=bxejrq0O97OaIGZehdOtZFdKSm9EDsoyJDIr/4i3yNCTfMGUEsN+dw3J9tW7BvA9EH WpSItcoPUjiH8BF9R0jR8zcXXCyvJAR+GhpHMQ4RYkI7yIFk+QO3EPJSAfIaD2A4QImK 3oz4YeGu+gyybOhMbR1QNto9Ki1HbrrGPZkRqMQdPQHUjxUoXQQ85djiom7hrWW7hbkf L3jsi8zpBYyE7/YsY7bMpXdtbTKyC1udfD0YldB2F1czdGkPfFAvas9r8d6LKip0JQuL e5sr23hJBX1+rbOyNTwNKCPortkqKrGUGArlvHYRE/qybFTk7nN9S7LJBSVdeWgq/u0B Yc0g== X-Gm-Message-State: ALyK8tIjuuEBqfK+i0JXqlVDr4bTr6ETW6U+eKNfgwQbphwuYgE7fxGCD0J6vbUWYsAh81ne X-Received: by 10.28.146.9 with SMTP id u9mr26691984wmd.52.1467878596732; Thu, 07 Jul 2016 01:03:16 -0700 (PDT) Received: from localhost.localdomain (lft31-1-88-121-166-205.fbx.proxad.net. [88.121.166.205]) by smtp.gmail.com with ESMTPSA id v70sm51327wmf.18.2016.07.07.01.03.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Jul 2016 01:03:16 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de, daniel.lezcano@linaro.org Cc: linux-kernel@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp Subject: [PATCH 30/93] clocksource/drivers/h8300_timer8: Convert init function to return error Date: Thu, 7 Jul 2016 10:01:03 +0200 Message-Id: <1467878526-1238-30-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1467878526-1238-1-git-send-email-daniel.lezcano@linaro.org> References: <577E0BED.3020608@linaro.org> <1467878526-1238-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller unaware if the state of the system Change that by converting the init functions to return an error conforming to the CLOCKSOURCE_OF_RET prototype. Proper error handling (rollback, errno value) will be changed later case by case, thus this change just return back an error or success in the init function. Signed-off-by: Daniel Lezcano --- drivers/clocksource/h8300_timer8.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) -- 1.9.1 diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c index c151941..0292a19 100644 --- a/drivers/clocksource/h8300_timer8.c +++ b/drivers/clocksource/h8300_timer8.c @@ -164,24 +164,26 @@ static struct timer8_priv timer8_priv = { }, }; -static void __init h8300_8timer_init(struct device_node *node) +static int __init h8300_8timer_init(struct device_node *node) { void __iomem *base; - int irq; + int irq, ret; struct clk *clk; clk = of_clk_get(node, 0); if (IS_ERR(clk)) { pr_err("failed to get clock for clockevent\n"); - return; + return PTR_ERR(clk); } + ret = ENXIO; base = of_iomap(node, 0); if (!base) { pr_err("failed to map registers for clockevent\n"); goto free_clk; } + ret = -EINVAL; irq = irq_of_parse_and_map(node, 0); if (!irq) { pr_err("failed to get irq for clockevent\n"); @@ -205,11 +207,12 @@ static void __init h8300_8timer_init(struct device_node *node) clockevents_config_and_register(&timer8_priv.ced, timer8_priv.rate, 1, 0x0000ffff); - return; + return 0; unmap_reg: iounmap(base); free_clk: clk_put(clk); + return ret; } -CLOCKSOURCE_OF_DECLARE(h8300_8bit, "renesas,8bit-timer", h8300_8timer_init); +CLOCKSOURCE_OF_DECLARE_RET(h8300_8bit, "renesas,8bit-timer", h8300_8timer_init);