From patchwork Tue Aug 23 16:42:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 74507 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2194309qga; Tue, 23 Aug 2016 09:44:37 -0700 (PDT) X-Received: by 10.98.28.142 with SMTP id c136mr54688407pfc.131.1471970677838; Tue, 23 Aug 2016 09:44:37 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x87si4653735pfa.79.2016.08.23.09.44.37; Tue, 23 Aug 2016 09:44:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754817AbcHWQoS (ORCPT + 27 others); Tue, 23 Aug 2016 12:44:18 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:56846 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752931AbcHWQoQ (ORCPT ); Tue, 23 Aug 2016 12:44:16 -0400 Received: from grover.sesame (FL1-119-242-215-193.osk.mesh.ad.jp [119.242.215.193]) (authenticated) by conuserg-07.nifty.com with ESMTP id u7NGhFSY012526; Wed, 24 Aug 2016 01:43:18 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com u7NGhFSY012526 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1471970598; bh=bDqj8a4fEM58vBWmFlr8C2Kdx4fuJVCDrGq9PjFL4Y0=; h=From:To:Cc:Subject:Date:From; b=zB6N++03wNHO7pa4pmcU3qGMXtwSNe4tRU3fAFM3LyojW/7wvPNtiT+14RYLC/2u2 iJBGd1WGgovCWdCMHMrzB/bVTlBdOaA8jo+FkUHrVlIg9mshUt+NC7LSC8W9V1q3XT BuCOVriCWLTj1+/ITdViPB35WL0+LsDu710znZrbrogECozgjt774pem7PQjnZL7sc nbW/wTxvKwY48c2+CtnCrMtXN4RHWuL+3vGm8GqMKh2JpJX552tlj1i5D+2M4JVPh0 Z1xI/zsojsFthyKHTr/nBMtbRf7HVmPwI99RuB4axyEhE6dKYRFogDDh2tS+IiqDA3 N9I39m1a+CNDg== X-Nifty-SrcIP: [119.242.215.193] From: Masahiro Yamada To: Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Patrik Jakobsson , David Airlie , Andrew Morton , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] drm/gma500: remove unnecessary config_enabled() guard Date: Wed, 24 Aug 2016 01:42:54 +0900 Message-Id: <1471970574-23906-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit d112a8163f83 ("gma500/cdv: Add eDP support") replaced the code inside this if-conditional with gma_backlight_set(), which becomes a nop stub if CONFIG_BACKLIGHT_CLASS_DEVICE is disabled. So, there is no need to guard the caller with config_enabled(). Note: This is one of remaining TODOs to deprecate config_enabled() macro. Refer to commit 97f2645f358b ("tree-wide: replace config_enabled() with IS_ENABLED()"). Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/gma500/opregion.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 1.9.1 diff --git a/drivers/gpu/drm/gma500/opregion.c b/drivers/gpu/drm/gma500/opregion.c index ab696ca..eab6d88 100644 --- a/drivers/gpu/drm/gma500/opregion.c +++ b/drivers/gpu/drm/gma500/opregion.c @@ -163,10 +163,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) if (bclp > 255) return ASLE_BACKLIGHT_FAILED; - if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) { - int max = bd->props.max_brightness; - gma_backlight_set(dev, bclp * max / 255); - } + gma_backlight_set(dev, bclp * bd->props.max_brightness / 255); asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID;