From patchwork Wed Aug 31 20:50:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Pallardy X-Patchwork-Id: 75130 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp533718qga; Wed, 31 Aug 2016 13:55:18 -0700 (PDT) X-Received: by 10.98.64.93 with SMTP id n90mr20594208pfa.29.1472676918469; Wed, 31 Aug 2016 13:55:18 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m18si1512806pfg.123.2016.08.31.13.55.18; Wed, 31 Aug 2016 13:55:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760907AbcHaUzN (ORCPT + 27 others); Wed, 31 Aug 2016 16:55:13 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:23898 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933186AbcHaUvN (ORCPT ); Wed, 31 Aug 2016 16:51:13 -0400 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by m0046037.ppops.net (8.16.0.11/8.16.0.11) with SMTP id u7VKnjB8008939; Wed, 31 Aug 2016 22:51:10 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-.pphosted.com with ESMTP id 255btaaqxx-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 31 Aug 2016 22:51:10 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BDDA531; Wed, 31 Aug 2016 20:51:09 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas23.st.com [10.75.90.46]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A44C350E2; Wed, 31 Aug 2016 20:51:09 +0000 (GMT) Received: from localhost (10.129.5.21) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.279.2; Wed, 31 Aug 2016 22:51:08 +0200 From: Loic Pallardy To: , , CC: , , , , Loic Pallardy Subject: [PATCH v2 06/19] remoteproc: core: Add explicit message error if cached table failed Date: Wed, 31 Aug 2016 22:50:09 +0200 Message-ID: <1472676622-32533-7-git-send-email-loic.pallardy@st.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1472676622-32533-1-git-send-email-loic.pallardy@st.com> References: <1472676622-32533-1-git-send-email-loic.pallardy@st.com> MIME-Version: 1.0 X-Originating-IP: [10.129.5.21] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-31_04:, , signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In rproc_fw_boot, add error message if kmemdump failed as done for other errors. Signed-off-by: Loic Pallardy --- drivers/remoteproc/remoteproc_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 1.9.1 diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 96bc8c644..3282a4e 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -1139,8 +1139,10 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw) * cached_table will be copied into device memory. */ rproc->cached_table = kmemdup(table, tablesz, GFP_KERNEL); - if (!rproc->cached_table) + if (!rproc->cached_table) { + dev_err(dev, "Failed to create cached table\n"); goto clean_up; + } rproc->table_ptr = rproc->cached_table;