From patchwork Tue Sep 6 07:37:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 75469 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp411210qgf; Tue, 6 Sep 2016 00:38:20 -0700 (PDT) X-Received: by 10.98.61.25 with SMTP id k25mr11968760pfa.88.1473147500160; Tue, 06 Sep 2016 00:38:20 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si34030060pab.228.2016.09.06.00.38.15; Tue, 06 Sep 2016 00:38:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755238AbcIFHiN (ORCPT + 27 others); Tue, 6 Sep 2016 03:38:13 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:32889 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbcIFHiM (ORCPT ); Tue, 6 Sep 2016 03:38:12 -0400 Received: by mail-pa0-f44.google.com with SMTP id cm16so21124737pac.0 for ; Tue, 06 Sep 2016 00:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Ie1uCB63HWvfYTw0XvO9LLDJBEuXB3jWpt0lMMIGbLo=; b=EVRERcFU/zMTfbWS0REt8vKhkyjlpaBrniJUhdG4GRP7SeVuN6JuJuxZPECAstc9hL FuCOwXXBodIpOfLcrz7AQpLPDGZ3cvOdIAwvTjmCh5d/90JRSnxEv184alZwAZ0J1jJY BmwI+vpvSO38/sLNsHcZ66fuSnWajf3hulgLQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ie1uCB63HWvfYTw0XvO9LLDJBEuXB3jWpt0lMMIGbLo=; b=SXebyLZDqaaT3ZjJBCFmFPgNIurSXearWFBB5vCeerZJqPc7OjIbB8ZStM8mUJdcwV 1ma7+obEab3BmQIFJ0GRnmNxsFzkky4IL0M94YeZytMYx3Yui1BOesDVp8Ntbtn0HoWz Ext/oMmwAw4ie35o4W9YS/x94D1f6Qz5IPLT7HZGbMJpJ69p1fpziXc4PaMJlLlzdM2C Av1sJIAVXlgJ9wbIeqYUA/u3gVqG7qjzQWYeVzlM4FYoHDCjCrr34pobnQfrMqWAtAu8 JEPFMpWnLKODxVlDFQieg87s40Pf1g4T7k1SAlq8blYDGUlrJg6QEcd8qY69m8Z2stBJ 0otA== X-Gm-Message-State: AE9vXwNkxlllaxRW2lpJqdBQWXFzrM8GHLEwje1nsDZNU4gzT/LtKqZKM4fCBfEmjsATPYLl X-Received: by 10.66.254.102 with SMTP id ah6mr71041779pad.59.1473147491261; Tue, 06 Sep 2016 00:38:11 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.17]) by smtp.gmail.com with ESMTPSA id c64sm27325504pfa.51.2016.09.06.00.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Sep 2016 00:38:10 -0700 (PDT) From: Baoyou Xie To: rmk+kernel@armlinux.org.uk, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/armada: mark symbols static where possible Date: Tue, 6 Sep 2016 15:37:55 +0800 Message-Id: <1473147475-24639-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/armada/armada_gem.c:215:27: warning: no previous prototype for 'armada_gem_alloc_object' [-Wmissing-prototypes] drivers/gpu/drm/armada/armada_gem.c:423:1: warning: no previous prototype for 'armada_gem_prime_map_dma_buf' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/armada/armada_gem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c index cb8f034..1beef28 100644 --- a/drivers/gpu/drm/armada/armada_gem.c +++ b/drivers/gpu/drm/armada/armada_gem.c @@ -212,7 +212,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size) return obj; } -struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev, +static struct +armada_gem_object *armada_gem_alloc_object(struct drm_device *dev, size_t size) { struct armada_gem_object *obj; @@ -419,7 +420,7 @@ int armada_gem_pwrite_ioctl(struct drm_device *dev, void *data, } /* Prime support */ -struct sg_table * +static struct sg_table * armada_gem_prime_map_dma_buf(struct dma_buf_attachment *attach, enum dma_data_direction dir) {