From patchwork Wed Sep 7 11:01:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 75631 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp263176qgf; Wed, 7 Sep 2016 04:01:50 -0700 (PDT) X-Received: by 10.66.157.103 with SMTP id wl7mr39165821pab.116.1473246110505; Wed, 07 Sep 2016 04:01:50 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si40708861paw.283.2016.09.07.04.01.50; Wed, 07 Sep 2016 04:01:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757201AbcIGLBr (ORCPT + 27 others); Wed, 7 Sep 2016 07:01:47 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34791 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754337AbcIGLBp (ORCPT ); Wed, 7 Sep 2016 07:01:45 -0400 Received: by mail-pa0-f53.google.com with SMTP id to9so5454299pac.1 for ; Wed, 07 Sep 2016 04:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=vnCTb9wI9+OsCzOiB66F4czkMbF3Y5jBbPodkqLdQ0g=; b=Z6r0I51tlhVyQa2gFjKdThb8Wlo3HiuD3TkRJx3diBBQ7s6ngNY7rk883LeV3MHmuA 20w+z7PPfOM5VRb+fDtqJOsrModLard0dStV3XLct1IGn1RZ9IbFrxdTF/uDS738cbDe 3WrnE/KsWA3RLW6KzCz8Tg0fZ6a0fD7oTbi9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vnCTb9wI9+OsCzOiB66F4czkMbF3Y5jBbPodkqLdQ0g=; b=Ptkh/j+mtFTByJ3rGYVS6mztQhNAtK9MtrFGgOm2P5VDet6yoz3XJBw6vdAjeoZtdS DKr/HUQXZhfYZrVD6ap9gWDH0WslUuAJ0moiMXpnDM+U63lUjQ1l4JsC+58Y+oN9E0/D HwUukB9RZZn9+VvTgaT+FtxX5IXsk9D0h7AQNJHmaTGt4tQpFoqV2mV6+bSZV62imGIm K/1RZDn//0nKqzyvNaLbsxHlNS1nFBjyGfoUw9k0uye96d3MPst7KFOfRkDtyszI286i tRtSHLKe+mVe/rRjWzrcsMd0QSNFYPlbltBTlIeLpKK0Qi0inQkQsULFXGFfu6JOXzSP l34g== X-Gm-Message-State: AE9vXwMBRkD/Ct0dbDkXMHL/HlWUbnKTdZDeFH0Tndl7pRYQdmdMc41BThyqmWKmcIp8VniW X-Received: by 10.66.155.129 with SMTP id vw1mr81017860pab.148.1473246104518; Wed, 07 Sep 2016 04:01:44 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.64]) by smtp.gmail.com with ESMTPSA id u75sm40354889pfa.43.2016.09.07.04.01.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Sep 2016 04:01:43 -0700 (PDT) From: Baoyou Xie To: mark.yao@rock-chips.com, airlied@linux.ie, heiko@sntech.de Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/rockchip: mark symbols static where possible Date: Wed, 7 Sep 2016 19:01:28 +0800 Message-Id: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] drivers/gpu/drm/rockchip/rockchip_drm_drv.c:318:6: warning: no previous prototype for 'rockchip_drm_fb_resume' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index a822d49..3723683 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -306,7 +306,7 @@ static struct drm_driver rockchip_drm_driver = { }; #ifdef CONFIG_PM_SLEEP -void rockchip_drm_fb_suspend(struct drm_device *drm) +static void rockchip_drm_fb_suspend(struct drm_device *drm) { struct rockchip_drm_private *priv = drm->dev_private; @@ -315,7 +315,7 @@ void rockchip_drm_fb_suspend(struct drm_device *drm) console_unlock(); } -void rockchip_drm_fb_resume(struct drm_device *drm) +static void rockchip_drm_fb_resume(struct drm_device *drm) { struct rockchip_drm_private *priv = drm->dev_private;