From patchwork Thu Sep 8 11:29:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 75770 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp791702qgf; Thu, 8 Sep 2016 04:30:04 -0700 (PDT) X-Received: by 10.98.156.212 with SMTP id u81mr19571995pfk.44.1473334204007; Thu, 08 Sep 2016 04:30:04 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p72si46723161pfi.197.2016.09.08.04.30.03; Thu, 08 Sep 2016 04:30:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756591AbcIHLaA (ORCPT + 27 others); Thu, 8 Sep 2016 07:30:00 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33101 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbcIHL36 (ORCPT ); Thu, 8 Sep 2016 07:29:58 -0400 Received: by mail-pa0-f51.google.com with SMTP id cm16so16706976pac.0 for ; Thu, 08 Sep 2016 04:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=Qju3JnoLJpk8hEufIo8q0+ttkagEDG+xi0uNNPjr31I=; b=MRvbBx5u70enJ/vJn18HTc7zpvP83J36FoXUkMWwRfjI0NB1z9EefT6jEqiUHlAWB1 s7Og6NQqgu2dpEKRT/XjddqrKrZKRx5n97r9TaL2Owgx4Qk4coepzxLwvN7jSlZdbEn3 2DP2a43tUnWFgsfr6biQ2G3kYQ/TCjgqa6LKc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=Qju3JnoLJpk8hEufIo8q0+ttkagEDG+xi0uNNPjr31I=; b=lOkbf2K691+Qitc7SvgcqqkOnDTM4bxceDthl+JEVUMnQ7h4kSnCu2aAZddOEpqq/M uiENAeS5IptIJ+G9pQ0imcSgIeg8Y5cnownTBGkXEa0xoFPvZ/vkwJaVYAQnUJ+pdDy9 yBfCE3JO+eDiI6Ng+Agur8fz8FGqGecgzqIr8snl8dTBT8g62yl53G73CkJY5FhOWQtg An6Foo07zUG9FPDc8QlQ/iFobJAWEV1FuS9CKm+tm35KT/nsmgAkbLF0txevzo/crOr5 RAgIaTYFeqiYv04mjAs8GwFyhz2y9X2kj7113TRHVa63bW5w7DWE6zgJVCSWZdzGdCbs avtQ== X-Gm-Message-State: AE9vXwMCcjkjBymiERUaNQ0rjhZSs36QBx8d61BZQdsOubkbDLa1Y84ISzSdsYLvB+IpjsIg X-Received: by 10.66.88.135 with SMTP id bg7mr19605423pab.107.1473334197894; Thu, 08 Sep 2016 04:29:57 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.33]) by smtp.gmail.com with ESMTPSA id az10sm51151824pab.5.2016.09.08.04.29.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 08 Sep 2016 04:29:57 -0700 (PDT) From: Baoyou Xie To: jsarha@ti.com, tomi.valkeinen@ti.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/tilcdc: mark symbols static where possible Date: Thu, 8 Sep 2016 19:29:24 +0800 Message-Id: <1473334164-25882-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 3 warnings when building kernel with W=1: drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:142:29: warning: no previous prototype for 'tilcdc_get_overlay' [-Wmissing-prototypes] drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:198:13: warning: no previous prototype for 'tilcdc_convert_slave_node' [-Wmissing-prototypes] drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:264:12: warning: no previous prototype for 'tilcdc_slave_compat_init' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c index f9c79da..dd8de260 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c @@ -139,7 +139,7 @@ static void __init tilcdc_node_disable(struct device_node *node) of_update_property(node, prop); } -struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft) +static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft) { const int size = __dtb_tilcdc_slave_compat_end - __dtb_tilcdc_slave_compat_begin; @@ -195,7 +195,7 @@ static const char * const tilcdc_slave_props[] __initconst = { NULL }; -void __init tilcdc_convert_slave_node(void) +static void __init tilcdc_convert_slave_node(void) { struct device_node *slave = NULL, *lcdc = NULL; struct device_node *i2c = NULL, *fragment = NULL; @@ -261,7 +261,7 @@ out: of_node_put(fragment); } -int __init tilcdc_slave_compat_init(void) +static int __init tilcdc_slave_compat_init(void) { tilcdc_convert_slave_node(); return 0;