From patchwork Thu Sep 8 11:37:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 75773 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp794837qgf; Thu, 8 Sep 2016 04:37:49 -0700 (PDT) X-Received: by 10.98.31.219 with SMTP id l88mr91418735pfj.155.1473334669429; Thu, 08 Sep 2016 04:37:49 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y187si46818506pfy.250.2016.09.08.04.37.49; Thu, 08 Sep 2016 04:37:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934925AbcIHLhq (ORCPT + 27 others); Thu, 8 Sep 2016 07:37:46 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33147 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933793AbcIHLhp (ORCPT ); Thu, 8 Sep 2016 07:37:45 -0400 Received: by mail-pa0-f48.google.com with SMTP id cm16so16762959pac.0 for ; Thu, 08 Sep 2016 04:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=ylDHH7jgHdzcmK87ImPHpLshglYvTRrkTqYhY5XnAzs=; b=d3haDx2FemwfCb/2S4NUJ6+cInN1OWp0XfnWSjD+Rr48fgvvXNixaerFcaMGEsst8N ZcZL6nok1i9pOlUOwcx0/8Fe/9rP/1AkVrMicTJui3Njm8My5iUeR6N0Sa8JTExQ4yKn luiZPT8MHsdf9DwCd0G8JjTqPWlE/IVlIulHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ylDHH7jgHdzcmK87ImPHpLshglYvTRrkTqYhY5XnAzs=; b=LiE8Tq7mK38VjEWZ2i7PFd3JHiDh1aKPaJp/OZU/8+OzrY4vt7F/zwNDnMiDunSSs6 UYqV50aR2qZ07Pa4DiVNlwCXx14weMetLfhoN2kNzoTZ/xCqNBZKqU6YDZydcWt+AbxS Kqh111PVvpUeMwgCsR1EHiD36FGIHLfehjlwbNgj9INyqLIJDiy+hb8CV3rJRjITi32S cOHfXr+m1FHIoA9Jvn+bhjn3kNtB5u5tg4C6lRVxbcpmDJ65Mc2SeB33D9esWc2OvKxp lkxu8rYmaHfriU7QvUirHG0sLf/SIA/hVehv3Uu8jUQvJpaQdwwviDeJ72y6GQ4H2XgD MBGA== X-Gm-Message-State: AE9vXwNS+smu6yryado5pRD/DbAzqaNMKDo/bckdrNnEdrbF/hzWdUD4nIPo+hSTLVXN3h9S X-Received: by 10.66.151.9 with SMTP id um9mr68031001pab.85.1473334664416; Thu, 08 Sep 2016 04:37:44 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.33]) by smtp.gmail.com with ESMTPSA id x66sm55643051pfb.86.2016.09.08.04.37.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 08 Sep 2016 04:37:43 -0700 (PDT) From: Baoyou Xie To: gregkh@linuxfoundation.org, wsa@the-dreams.de Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] staging: ks7010: mark symbols static where possible Date: Thu, 8 Sep 2016 19:37:24 +0800 Message-Id: <1473334644-26133-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 3 warnings when building kernel with W=1: drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] drivers/staging/ks7010/ks7010_sdio.c:121:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes] drivers/staging/ks7010/ks7010_sdio.c:174:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index b7337fd..466ba07 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -87,7 +87,7 @@ static int ks7010_sdio_write(struct ks_wlan_private *priv, unsigned int address, return rc; } -void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) +static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) { unsigned char rw_data; int retval; @@ -118,7 +118,7 @@ void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) return; } -void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv) +static void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv) { unsigned char rw_data; int retval; @@ -171,7 +171,7 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv) } } -int _ks_wlan_hw_power_save(struct ks_wlan_private *priv) +static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv) { int rc = 0; unsigned char rw_data;