From patchwork Mon Sep 12 18:10:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 76019 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp977702qgf; Mon, 12 Sep 2016 11:11:49 -0700 (PDT) X-Received: by 10.98.58.195 with SMTP id v64mr33313927pfj.97.1473703909873; Mon, 12 Sep 2016 11:11:49 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si22719532pfb.1.2016.09.12.11.11.49; Mon, 12 Sep 2016 11:11:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576AbcILSLk (ORCPT + 27 others); Mon, 12 Sep 2016 14:11:40 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:23417 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcILSLj (ORCPT ); Mon, 12 Sep 2016 14:11:39 -0400 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-07.nifty.com with ESMTP id u8CIApem017710; Tue, 13 Sep 2016 03:10:54 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com u8CIApem017710 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1473703854; bh=4H8KrYbqxbvYn3aimKMqiLRtdLnpUvxFqqSm8+MHu+4=; h=From:To:Cc:Subject:Date:From; b=VPM+Y5j6h47C8mvSgDLkrYrOD+LXucQyj9W4PzFTU1z6Tgeh8zCWPqXRGMI/Y08L5 z4vimndGcdTYrBXsz+o3WXCYsu/VfIbbGcP2830IQczuHH8AhuLD/9hi1mXB24NuAH 3XW3j941/g6N2eYqrkPSh6BTMER36gWTY8Nyc/68mBtqm3TuVr85GsD3ZyyEawmfgy QSbc7LuxLDCUCbQ4Sqor0zzCcLw5Gpuy8wo6TnGLoTBTE/bjhVG6sWLoPWeiCwMgxM HABzWsvm1gqxrQEDb8GCGqq3EdlQ+OiT4St1bPeMMBcPkcplcB/uL/2+DskVqoQtua 1XGtCSyE/sVMQ== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-s390@vger.kernel.org Cc: Masahiro Yamada , Heiko Carstens , Michael Holzheu , linux-kernel@vger.kernel.org, Alexander Kuleshov , Martin Schwidefsky Subject: [PATCH] s390: cleanup with list_first_entry_or_null() Date: Tue, 13 Sep 2016 03:10:39 +0900 Message-Id: <1473703839-1185-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The combo of list_empty() check and return list_first_entry() can be replaced with list_first_entry_or_null(). Signed-off-by: Masahiro Yamada --- arch/s390/kernel/crash_dump.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 1.9.1 diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c index 29df848..621907d 100644 --- a/arch/s390/kernel/crash_dump.c +++ b/arch/s390/kernel/crash_dump.c @@ -71,9 +71,8 @@ struct save_area * __init save_area_alloc(bool is_boot_cpu) */ struct save_area * __init save_area_boot_cpu(void) { - if (list_empty(&dump_save_areas)) - return NULL; - return list_first_entry(&dump_save_areas, struct save_area, list); + return list_first_entry_or_null(&dump_save_areas, struct save_area, + list); } /*