From patchwork Mon Sep 12 18:23:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 76021 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp982882qgf; Mon, 12 Sep 2016 11:24:41 -0700 (PDT) X-Received: by 10.66.193.199 with SMTP id hq7mr17272182pac.70.1473704681524; Mon, 12 Sep 2016 11:24:41 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h184si22747926pfb.176.2016.09.12.11.24.41; Mon, 12 Sep 2016 11:24:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755545AbcILSYh (ORCPT + 27 others); Mon, 12 Sep 2016 14:24:37 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:64010 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbcILSYf (ORCPT ); Mon, 12 Sep 2016 14:24:35 -0400 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-11.nifty.com with ESMTP id u8CINPmB024739; Tue, 13 Sep 2016 03:23:27 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com u8CINPmB024739 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1473704608; bh=AUF75LPZvfIwaVF3judUhqFl/7JHi1VRP4qxYMTvSWw=; h=From:To:Cc:Subject:Date:From; b=QFMfdUJK805FcSvYXN3g+KwQ1OP9OOwistj6ddWciHy2aeZlVxf4Fjs6g3hPOF1+E Wm9N3byi3Mzqb3eBK2+6TivJ1Cv85S40JCT/we7xdrPYDGF0kOPapYSs5Vg0lBkUSl l4I8C/5VkPukODRpujGNDq05SlGdWijehcWMpeUu7cpOD6T7/G3MVfAk1+am0scHOM xH3TOXy6b285/yMVTUHPpHkvfu4XuGOgiYd1dr1CS5YuLxHNxxAVM62lz4Q0tBP7b0 D7jMR5W22STDZh8bh82rklR1wkjsnF0qS9wdUoFTnA9P+wiA6BFbpuOR/keytENl5g gBKSdHG0lm8xQ== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-pm@vger.kernel.org Cc: Masahiro Yamada , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-kernel@vger.kernel.org Subject: [PATCH] power: ab8500: cleanup with list_first_entry_or_null() Date: Tue, 13 Sep 2016 03:23:21 +0900 Message-Id: <1473704601-3217-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The combo of list_empty() check and return list_first_entry() can be replaced with list_first_entry_or_null(). Signed-off-by: Masahiro Yamada --- drivers/power/ab8500_fg.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) -- 1.9.1 diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c index 5a36cf8..84b7fa9 100644 --- a/drivers/power/ab8500_fg.c +++ b/drivers/power/ab8500_fg.c @@ -245,13 +245,8 @@ static LIST_HEAD(ab8500_fg_list); */ struct ab8500_fg *ab8500_fg_get(void) { - struct ab8500_fg *fg; - - if (list_empty(&ab8500_fg_list)) - return NULL; - - fg = list_first_entry(&ab8500_fg_list, struct ab8500_fg, node); - return fg; + return list_first_entry_or_null(&ab8500_fg_list, struct ab8500_fg, + node); } /* Main battery properties */