From patchwork Mon Sep 12 18:35:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 76023 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp987209qgf; Mon, 12 Sep 2016 11:36:04 -0700 (PDT) X-Received: by 10.98.141.219 with SMTP id p88mr35671124pfk.153.1473705363937; Mon, 12 Sep 2016 11:36:03 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si22775696pfe.212.2016.09.12.11.36.03; Mon, 12 Sep 2016 11:36:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755214AbcILSgB (ORCPT + 27 others); Mon, 12 Sep 2016 14:36:01 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:25484 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbcILSgA (ORCPT ); Mon, 12 Sep 2016 14:36:00 -0400 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-11.nifty.com with ESMTP id u8CIZMRd029415; Tue, 13 Sep 2016 03:35:25 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com u8CIZMRd029415 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1473705325; bh=NrbZFD/Y2ZdV4NYU68itQzXLJ1ajF0EduvT0TRSuhZQ=; h=From:To:Cc:Subject:Date:From; b=FldezNNUJVCQaMrlaiHpjFqwFLdRedSki1E6FPmp1ZI769YbTvcw0/PNizNiqAIRy vp9TvIEnksy5cZxi2iWAP5WRASDYKmAzGzMSz15E0hggwHZtTIn8X4B38PRddbcS+i QOxJwGgJ3lR63j7GUBYatvuGGfE2V30XkHaVfreuqJ5C9ZrqNwmwPWKTJ9U82H4oc+ H7Kx10vkm5JKzT6HqunvJQJrR/tj+icKvZMOyDqK4PWxYULt4tcDCcDW/KfkA3Io/x TFm5+OYzXRWqGlj3WYjBQZouthTCx4ToUmUrbeLj4VgkHV1AHLNr+1PLFRNXorzHs4 nPY7DKAZ9f9Vw== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS) Cc: Masahiro Yamada , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/vc4: cleanup with list_first_entry_or_null() Date: Tue, 13 Sep 2016 03:35:20 +0900 Message-Id: <1473705320-6046-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The combo of list_empty() check and return list_first_entry() can be replaced with list_first_entry_or_null(). Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/vc4/vc4_drv.h | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) -- 1.9.1 diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index 428e249..61c1902 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.h +++ b/drivers/gpu/drm/vc4/vc4_drv.h @@ -307,18 +307,15 @@ struct vc4_exec_info { static inline struct vc4_exec_info * vc4_first_bin_job(struct vc4_dev *vc4) { - if (list_empty(&vc4->bin_job_list)) - return NULL; - return list_first_entry(&vc4->bin_job_list, struct vc4_exec_info, head); + return list_first_entry_or_null(&vc4->bin_job_list, + struct vc4_exec_info, head); } static inline struct vc4_exec_info * vc4_first_render_job(struct vc4_dev *vc4) { - if (list_empty(&vc4->render_job_list)) - return NULL; - return list_first_entry(&vc4->render_job_list, - struct vc4_exec_info, head); + return list_first_entry_or_null(&vc4->render_job_list, + struct vc4_exec_info, head); } static inline struct vc4_exec_info *