From patchwork Sun Sep 18 11:30:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76461 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp489852qgf; Sun, 18 Sep 2016 04:31:15 -0700 (PDT) X-Received: by 10.98.89.210 with SMTP id k79mr38123766pfj.43.1474198275494; Sun, 18 Sep 2016 04:31:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t22si42248040pfg.41.2016.09.18.04.31.14; Sun, 18 Sep 2016 04:31:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbcIRLbH (ORCPT + 27 others); Sun, 18 Sep 2016 07:31:07 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33141 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754606AbcIRLa5 (ORCPT ); Sun, 18 Sep 2016 07:30:57 -0400 Received: by mail-pa0-f43.google.com with SMTP id hm5so7294633pac.0 for ; Sun, 18 Sep 2016 04:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=lzN62ujmO2iJ9lg72EiB0U5sNTPh0n+KUabP+L28Gxk=; b=RLhFuKRAJMVFvxeUUan7m2F1n7ytA4HF1b4KJXjKicXzfCQCMM08NNWpP/E2uLsG/I QdhdjtF4dqsGlIuGNrXQgd+DmdxFXynQPf5WeowAxtA8OPYbVobOgp8IuHrOfWpBOcVM nj2TL+elAaecl7zGmsEdnF4UO+hq00v4Am3bc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lzN62ujmO2iJ9lg72EiB0U5sNTPh0n+KUabP+L28Gxk=; b=hmS3zqiKc2kMhlm+uNZOk1yUzGSWghIucnSdRp56io1zVGg1pXy3zCm5/axWqrIzJP rdnS4SzJjmOhd65R++RFodEeEH11c3hiBaiZbNI8YOT83z3tjdyMAzFyIvkpvOLrGFP8 cH0+zCgAKx4ft55QvW2S3wy7dOpFON8ghO7Ym31YeM74PSY56qaAmJseISLrjNEsyipM 0FwWfcw8TpMcbU0lZ1T9gOJ+fmbgaVdLBIdyHPkXC/HEByq/6RnCdqzDhXE+TAtU5DCQ lab6MTey8C9NujKo/fEWwETW/atJjYR0K5zVuuEtUrNKGFq6hnKPU7rFXe2OQuWq7KaD /VHw== X-Gm-Message-State: AE9vXwPVv2JMepouQULEXSHkbgSYUKDxYfvOYaOjRdzCH0vps8bqlWR3uxRqcSGnflxcAz2r X-Received: by 10.67.1.35 with SMTP id bd3mr38347942pad.16.1474198256273; Sun, 18 Sep 2016 04:30:56 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.27]) by smtp.gmail.com with ESMTPSA id cu2sm24037253pad.18.2016.09.18.04.30.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 04:30:55 -0700 (PDT) From: Baoyou Xie To: wsa+renesas@sang-engineering.com, gregkh@linuxfoundation.org, colin.king@canonical.com, hofrat@osadl.org, karniksayli1995@gmail.com, dan.carpenter@oracle.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] staging: ks7010: move ks_wlan_hw_tx() declaration to header file Date: Sun, 18 Sep 2016 19:30:44 +0800 Message-Id: <1474198244-10828-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 1 warning when building kernel with W=1: drivers/staging/ks7010/ks7010_sdio.c:363:5: warning: no previous prototype for 'ks_wlan_hw_tx' [-Wmissing-prototypes] In fact, this function is declared in drivers/staging/ks7010/ks_wlan_net.c and drivers/staging/ks7010/ks_hostif.c, but should be declared in a header file. thus can be recognized in other file. So this patch moves the declaration into drivers/staging/ks7010/ks_wlan.h. Signed-off-by: Baoyou Xie --- drivers/staging/ks7010/ks_hostif.c | 5 ----- drivers/staging/ks7010/ks_wlan.h | 4 ++++ drivers/staging/ks7010/ks_wlan_net.c | 4 ---- 3 files changed, 4 insertions(+), 9 deletions(-) -- 2.7.4 diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index aacb93e..d8ed3db 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -20,11 +20,6 @@ /* Include Wireless Extension definition and check version */ #include /* New driver API */ -extern int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, - unsigned long size, - void (*complete_handler) (void *arg1, void *arg2), - void *arg1, void *arg2); - extern void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv); extern int ks_wlan_hw_power_save(struct ks_wlan_private *priv); diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 936222b..67fd846 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -503,5 +503,9 @@ extern int ks_wlan_net_start(struct net_device *dev); extern int ks_wlan_net_stop(struct net_device *dev); void send_packet_complete(void *, void *); +int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, + unsigned long size, + void (*complete_handler)(void *arg1, void *arg2), + void *arg1, void *arg2); #endif /* _KS_WLAN_H */ diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index a35325e..fe45ba4 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -70,10 +70,6 @@ static const struct iw_handler_def ks_wlan_handler_def; /* * function prototypes */ -extern int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, - unsigned long size, - void (*complete_handler) (void *arg1, void *arg2), - void *arg1, void *arg2); static int ks_wlan_open(struct net_device *dev); static void ks_wlan_tx_timeout(struct net_device *dev); static int ks_wlan_start_xmit(struct sk_buff *skb, struct net_device *dev);