From patchwork Sun Sep 18 13:54:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76472 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp535535qgf; Sun, 18 Sep 2016 06:55:17 -0700 (PDT) X-Received: by 10.66.157.103 with SMTP id wl7mr38806880pab.116.1474206917483; Sun, 18 Sep 2016 06:55:17 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si23010627pau.218.2016.09.18.06.55.17; Sun, 18 Sep 2016 06:55:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935339AbcIRNzO (ORCPT + 27 others); Sun, 18 Sep 2016 09:55:14 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36106 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756101AbcIRNzE (ORCPT ); Sun, 18 Sep 2016 09:55:04 -0400 Received: by mail-pf0-f177.google.com with SMTP id q2so21859980pfj.3 for ; Sun, 18 Sep 2016 06:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=8hfIzRc8Bg1xilZEoCHbKmjPQLkkEDeKN36wVWZwgA4=; b=E47vNvzrvT+PAC43OfpUdrHy1ptyquIpOFw3B5itHzeG9yBUifTvVmrr4cM7jTNHI0 RvBuSjN9QDIPzpUMXlodZ1MTBJKoaqn7o6dJKisxXdbGbmMUKRLiXpJ9N2d0wEwSO9V+ P4lmmfBe4v6lIMqEkxt0ogSuBcRVZ7sh7FMDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8hfIzRc8Bg1xilZEoCHbKmjPQLkkEDeKN36wVWZwgA4=; b=VRy0V414TeaDwD60NaKw34pM25F94XSXh7zXaC1V+54wEAPP5hiBVcuGlPCpskYOOv X7gsCJImK0UCV/eZSxFM0Xvfz0kZEpRGOFoUJwg21uGnI337JPKMca+H4TGrHmsPV1ni i45FkYUwvc2Vr1KnUQ7wKVGsNK/s/IJtoyeRRMWO2LyqTJAlxeTDojBfj76KkeqASlOC 3m1ZE4WailYr0kw7CWpsb3hQ6YDvadaF4HCHkfz+Pj+FPN4tv1Pq5sBdXljRAxs87S+Q lybUz7TjSnEeUo94FIbkBjVTvuUShY6ETgI+AqCFcRQKtsEGQd8F5Phg38ruNAs8JN21 movA== X-Gm-Message-State: AE9vXwMCannkJxVIfqBaZXQwfPJ7Q3H4Fw8xqQrjx5ZJoDS5EXWogHnH0fYA2aQLF1cOnVp7 X-Received: by 10.98.83.130 with SMTP id h124mr38775974pfb.154.1474206903318; Sun, 18 Sep 2016 06:55:03 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.172]) by smtp.gmail.com with ESMTPSA id p4sm64697634pfp.60.2016.09.18.06.54.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 06:55:02 -0700 (PDT) From: Baoyou Xie To: airlied@linux.ie, ykk@rock-chips.com, inki.dae@samsung.com, seanpaul@chromium.org, gustavo.padovan@collabora.co.uk, daniel.vetter@ffwll.ch, ville.syrjala@linux.intel.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm: bridge: analogix/dp: mark symbols static where possible Date: Sun, 18 Sep 2016 21:54:47 +0800 Message-Id: <1474206887-27162-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1053:5: warning: no previous prototype for 'analogix_dp_get_modes' [-Wmissing-prototypes] drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1097:1: warning: no previous prototype for 'analogix_dp_detect' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks both functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index efac8ab..e6f7290 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1050,7 +1050,7 @@ out: return ret; } -int analogix_dp_get_modes(struct drm_connector *connector) +static int analogix_dp_get_modes(struct drm_connector *connector) { struct analogix_dp_device *dp = to_dp(connector); struct edid *edid = (struct edid *)dp->edid; @@ -1093,7 +1093,7 @@ static const struct drm_connector_helper_funcs analogix_dp_connector_helper_func .best_encoder = analogix_dp_best_encoder, }; -enum drm_connector_status +static enum drm_connector_status analogix_dp_detect(struct drm_connector *connector, bool force) { struct analogix_dp_device *dp = to_dp(connector);