From patchwork Sun Sep 18 14:09:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76475 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp541484qgf; Sun, 18 Sep 2016 07:10:47 -0700 (PDT) X-Received: by 10.98.103.193 with SMTP id t62mr36402527pfj.2.1474207847691; Sun, 18 Sep 2016 07:10:47 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bd6si16669163pad.41.2016.09.18.07.10.47; Sun, 18 Sep 2016 07:10:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935780AbcIROKp (ORCPT + 27 others); Sun, 18 Sep 2016 10:10:45 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36665 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756736AbcIROKi (ORCPT ); Sun, 18 Sep 2016 10:10:38 -0400 Received: by mail-pa0-f43.google.com with SMTP id id6so40101634pad.3 for ; Sun, 18 Sep 2016 07:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=GEIbx00kToGDqY+qMPWbjutS1Y7S79b2dEeMEprBLkQ=; b=BW3du84zJkN5/oEcvMJHzFlnIRe2AukMvGNt+/ESIk8W+UChD99Y9Izu0mVTcAHvrH Q0/gEyncMT+3kOsth4h06qZjhJ1RdctP2xzXAxBc/l234OJJW1IjXbTQ4icbdgJjUrX6 y2jO7FiluVH5VvU2+2kfAQLOfK2h1miudCPOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GEIbx00kToGDqY+qMPWbjutS1Y7S79b2dEeMEprBLkQ=; b=gbqWoxjLXxwv5Uezngl2fewCwUBtHyPaY2z2koJm4ApShxvCCSTMUuDtShDYkovSQ1 stOFbxav1iuguWLrjgi/29ukDcWDUlfjDnY8OgYiRqQyZjtfvUMCSvAfZUc0Yr9TvuoM yDyhvrmVcuhPJ/jz+uefy6yPi2w3d1zTylHWpglcvfIm/6MSnnmdZKXKCUWYRHOTC7tL 24jLgS++8d06md8KdGf9esK5NChoxQ5Xy95cfSUJHs2zP7MgcEm+ZSFof9oVzUaznpFA 5oXP5MOAPxZ4hxofthMLvITIYg6T4txjxxhlFF5kmTF5sCZBF3TviaBhYZk3xddWNaE4 holg== X-Gm-Message-State: AE9vXwMb8UBQlEDk8NKBW6BVe8fm/flVgGNIoaQDg6iSPua2wSmuWgfb3QXHomvOYNWNYLKp X-Received: by 10.66.49.130 with SMTP id u2mr8707436pan.172.1474207836890; Sun, 18 Sep 2016 07:10:36 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.172]) by smtp.gmail.com with ESMTPSA id mz4sm24760374pab.21.2016.09.18.07.10.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 07:10:36 -0700 (PDT) From: Baoyou Xie To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, nils.wallmenius@gmail.com, Emily.Deng@amd.com, cpaul@redhat.com, arindam.nath@amd.com, David1.Zhou@amd.com, Monk.Liu@amd.com, Jerry.Zhang@amd.com, dan.carpenter@oracle.com, tom.stdenis@amd.com, michel.daenzer@amd.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/amdgpu: mark symbols static where possible Date: Sun, 18 Sep 2016 22:09:35 +0800 Message-Id: <1474207775-16768-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 7 warnings when building kernel with W=1: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1990:5: warning: no previous prototype for 'amdgpu_pre_soft_reset' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1548:5: warning: no previous prototype for 'amdgpu_connector_virtual_dpms' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1560:5: warning: no previous prototype for 'amdgpu_connector_virtual_set_property' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:330:5: warning: no previous prototype for 'amdgpu_cs_list_validate' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/dce_virtual.c:98:6: warning: no previous prototype for 'dce_virtual_stop_mc_access' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/dce_virtual.c:130:6: warning: no previous prototype for 'dce_virtual_resume_mc_access' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/dce_virtual.c:136:6: warning: no previous prototype for 'dce_virtual_set_vga_render_state' [-Wmissing-prototypes] In fact, all of the functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks both functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 6 ++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 6 +++--- 4 files changed, 9 insertions(+), 7 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c index 319a5e1..decbba5 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c @@ -1545,7 +1545,8 @@ static int amdgpu_connector_virtual_mode_valid(struct drm_connector *connector, return MODE_OK; } -int amdgpu_connector_virtual_dpms(struct drm_connector *connector, int mode) +static int +amdgpu_connector_virtual_dpms(struct drm_connector *connector, int mode) { return 0; } @@ -1557,7 +1558,8 @@ amdgpu_connector_virtual_detect(struct drm_connector *connector, bool force) return connector_status_connected; } -int amdgpu_connector_virtual_set_property(struct drm_connector *connector, +static int +amdgpu_connector_virtual_set_property(struct drm_connector *connector, struct drm_property *property, uint64_t val) { diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index d80e5d3..b408eea 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -327,7 +327,7 @@ retry: return r; } -int amdgpu_cs_list_validate(struct amdgpu_cs_parser *p, +static int amdgpu_cs_list_validate(struct amdgpu_cs_parser *p, struct list_head *validated) { struct amdgpu_bo_list_entry *lobj; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index c38dc47..09b809d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -1987,7 +1987,7 @@ static bool amdgpu_check_soft_reset(struct amdgpu_device *adev) return asic_hang; } -int amdgpu_pre_soft_reset(struct amdgpu_device *adev) +static int amdgpu_pre_soft_reset(struct amdgpu_device *adev) { int i, r = 0; diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c index 00663a7..2d02acd 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c @@ -95,7 +95,7 @@ static bool dce_virtual_is_display_hung(struct amdgpu_device *adev) return false; } -void dce_virtual_stop_mc_access(struct amdgpu_device *adev, +static void dce_virtual_stop_mc_access(struct amdgpu_device *adev, struct amdgpu_mode_mc_save *save) { switch (adev->asic_type) { @@ -127,13 +127,13 @@ void dce_virtual_stop_mc_access(struct amdgpu_device *adev, return; } -void dce_virtual_resume_mc_access(struct amdgpu_device *adev, +static void dce_virtual_resume_mc_access(struct amdgpu_device *adev, struct amdgpu_mode_mc_save *save) { return; } -void dce_virtual_set_vga_render_state(struct amdgpu_device *adev, +static void dce_virtual_set_vga_render_state(struct amdgpu_device *adev, bool render) { return;