From patchwork Sun Sep 18 17:58:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 76486 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp610286qgf; Sun, 18 Sep 2016 11:01:20 -0700 (PDT) X-Received: by 10.98.32.78 with SMTP id g75mr40432564pfg.103.1474221680098; Sun, 18 Sep 2016 11:01:20 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u73si21059434pfg.37.2016.09.18.11.01.19; Sun, 18 Sep 2016 11:01:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757395AbcIRSAy (ORCPT + 27 others); Sun, 18 Sep 2016 14:00:54 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:51987 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbcIRSAq (ORCPT ); Sun, 18 Sep 2016 14:00:46 -0400 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-09.nifty.com with ESMTP id u8IHwqSO002914; Mon, 19 Sep 2016 02:58:56 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com u8IHwqSO002914 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1474221536; bh=GIXo2S+QGysio/ZYVEW+qF1hVktXzlTnO5hJJjLOpAQ=; h=From:To:Cc:Subject:Date:From; b=JP7BoOK8UoL7dbppf1AvZiYNJpoxGsJUsIeSR7AISP3gqAru0Q4CCEgfTThjcVXxB nxlMqzRfAVoQGiSbp/uoDUfqy7SmSD25kMepVjCJMsP05bMYL+T8Qe+PTRopIeVnkq KHob78hlaE769oNJyGcGzrrzsTIj9bi71o/b0fzlWcBuylJBCrLsGQ3dNDY19Qo9Ij 7WnqGJjNQzZ+FWRypSaPaPggZptTstYy6LKlBCWvd7Dsb90uq7mrAfJmIxj3EIIgsy +/1dJiRELhZ1Ddn2fJ6ExMLwiLfajLRvypLsRk5rfUdzmKMaHAtoE+I38HgYeWtcQy a+VKYq6MqyJRQ== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-arm-kernel@lists.infradead.org Cc: Stephen Boyd , Ralf Baechle , Michael Turquette , Masahiro Yamada , Haojian Zhuang , Eric Miao , Russell King , linux-kernel@vger.kernel.org Subject: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL Date: Mon, 19 Sep 2016 02:58:46 +0900 Message-Id: <1474221526-21195-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In many of clk_disable() implementations, it is a no-op for a NULL pointer input, but this is one of the exceptions. Making it treewide consistent will allow clock consumers to call clk_disable() without NULL pointer check. Signed-off-by: Masahiro Yamada --- Changes in v4: - Split into per-arch patches Changes in v3: - Return only when clk is NULL. Do not take care of error pointer. Changes in v2: - Rebase on Linux 4.6-rc1 arch/arm/mach-mmp/clock.c | 3 +++ 1 file changed, 3 insertions(+) -- 1.9.1 diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c index ac6633d..28fe64c 100644 --- a/arch/arm/mach-mmp/clock.c +++ b/arch/arm/mach-mmp/clock.c @@ -67,6 +67,9 @@ void clk_disable(struct clk *clk) { unsigned long flags; + if (!clk) + return; + WARN_ON(clk->enabled == 0); spin_lock_irqsave(&clocks_lock, flags);