From patchwork Sun Sep 18 18:03:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 76489 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp611726qgf; Sun, 18 Sep 2016 11:05:21 -0700 (PDT) X-Received: by 10.98.86.154 with SMTP id h26mr40532437pfj.22.1474221921077; Sun, 18 Sep 2016 11:05:21 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gz6si24015459pac.235.2016.09.18.11.05.20; Sun, 18 Sep 2016 11:05:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757548AbcIRSFS (ORCPT + 27 others); Sun, 18 Sep 2016 14:05:18 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:56332 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755710AbcIRSFM (ORCPT ); Sun, 18 Sep 2016 14:05:12 -0400 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-09.nifty.com with ESMTP id u8II3Rkw007200; Mon, 19 Sep 2016 03:03:30 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com u8II3Rkw007200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1474221811; bh=sh0xkERYGSQ6UuRAcA4YNKNVgsCTl0uz2cpubfU9jp4=; h=From:To:Cc:Subject:Date:From; b=PYL95CUSXmZ5QOYnihyCXZY2Ysfy+TSuPC3QHR+v9nfGGn+HKG6Ru8zNIVsepLVmo qqmNTUUTRF5HcL6UmlR4Hn2r57bStAxFL7vX6Hk2xkaeXK9ZwBbjoKD9/F7zF6eu+v l9XropEHpen/SCaJVa38AJQiEvdIqJEtDyNU08fktqGJ83m14jOZ2dPLH5IFVvLGM+ p0pnDmEmEE1ptM6dKYkKlcrp30IiaQTHGMzoVGLL+D3GUsqxPr2/E1jL9FvxgDAlgt HMF5+A+V/j2jollzVqiT6ivthBZD5f/OBXPtdejZJ3zyLoXrxECFP84DxhsnpZmCsN Un1vWzuXklFNg== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: Steven Miao , adi-buildroot-devel@lists.sourceforge.net Cc: Stephen Boyd , Ralf Baechle , Michael Turquette , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH v4] blackfin: bf609: let clk_disable() return immediately if clk is NULL Date: Mon, 19 Sep 2016 03:03:25 +0900 Message-Id: <1474221805-22599-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In many of clk_disable() implementations, it is a no-op for a NULL pointer input, but this is one of the exceptions. Making it treewide consistent will allow clock consumers to call clk_disable() without NULL pointer check. Signed-off-by: Masahiro Yamada --- Changes in v4: - Split into per-arch patches Changes in v3: - Return only when clk is NULL. Do not take care of error pointer. Changes in v2: - Rebase on Linux 4.6-rc1 arch/blackfin/mach-bf609/clock.c | 3 +++ 1 file changed, 3 insertions(+) -- 1.9.1 diff --git a/arch/blackfin/mach-bf609/clock.c b/arch/blackfin/mach-bf609/clock.c index 3783058..392a59b 100644 --- a/arch/blackfin/mach-bf609/clock.c +++ b/arch/blackfin/mach-bf609/clock.c @@ -97,6 +97,9 @@ EXPORT_SYMBOL(clk_enable); void clk_disable(struct clk *clk) { + if (!clk) + return; + if (clk->ops && clk->ops->disable) clk->ops->disable(clk); }