From patchwork Fri Sep 23 13:38:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76869 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp574982qgf; Fri, 23 Sep 2016 06:38:45 -0700 (PDT) X-Received: by 10.66.188.202 with SMTP id gc10mr12282705pac.104.1474637925569; Fri, 23 Sep 2016 06:38:45 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vw1si7506513pac.278.2016.09.23.06.38.44; Fri, 23 Sep 2016 06:38:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032115AbcIWNim (ORCPT + 27 others); Fri, 23 Sep 2016 09:38:42 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33273 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965055AbcIWNil (ORCPT ); Fri, 23 Sep 2016 09:38:41 -0400 Received: by mail-pf0-f174.google.com with SMTP id 21so42315210pfy.0 for ; Fri, 23 Sep 2016 06:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=7A1E7NpjJWKcKo6czDacJlRhY9nFc3ZMmeyQmDW44tM=; b=GDFDlnCqIySGvnpDObEZ7Pktx3EFUPGJNXcJdvaspkpCNVfD0/eXAlQmkilPhXblAU l9TFoyRBx0k9h2Bu1rpZNpz31PihSZuM1683tiPUDrrNVdM4vu0fhVCPpxPhjpfzn2ve Ti/4m6lUuVPW1RwxvB6SRzjRDVe9jnjXxT9Co= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7A1E7NpjJWKcKo6czDacJlRhY9nFc3ZMmeyQmDW44tM=; b=AJf3/n9fKCRlQVHsOGyZ8vDVSop6uKyedhO32G9OgJVGAc1cTma9pXQrpkms9vTPSl AG6gqH8hqLifh/dVVSbMMMcGHKhwn6wHeECZ0uGUb7p6IKzqHAMAD1MKkHN3AWZWGPIw c/b8ly+BHvJuliS9OOnHB9vbUiPleBGTv1sOpdrwz7dQt8cPEp2XkEAg7vSqfOvLYu69 pbwLVpK+wFsxko/SCUocBkfp5I1POqWMMQthNHi9WGVBSIv5cYT2uFOFCmU7WkSbdlxg +AjsVXWVzR7hcaOK1JdHHSbF9SzpLCWkulFmQv0OP6LueE/XFs5OyyO+40Z587+mFhSg 8jEQ== X-Gm-Message-State: AE9vXwPc8223Cma3QIxjHPEsccRnXiKyv8ioWoFbUuh8/dozDsE+QeJuCQRGJQqryA9IXLID X-Received: by 10.98.152.69 with SMTP id q66mr12337450pfd.176.1474637920835; Fri, 23 Sep 2016 06:38:40 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.27]) by smtp.gmail.com with ESMTPSA id q4sm11877100pfb.18.2016.09.23.06.38.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Sep 2016 06:38:40 -0700 (PDT) From: Baoyou Xie To: martyn@welchs.me.uk, manohar.vanga@gmail.com, gregkh@linuxfoundation.org, arnd@arndb.de Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] vme: fake: mark symbols static where possible Date: Fri, 23 Sep 2016 21:38:28 +0800 Message-Id: <1474637908-20205-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 4 warnings when building kernel with W=1: drivers/vme/bridges/vme_fake.c:384:6: warning: no previous prototype for 'fake_lm_check' [-Wmissing-prototypes] drivers/vme/bridges/vme_fake.c:619:6: warning: no previous prototype for 'fake_vmewrite8' [-Wmissing-prototypes] drivers/vme/bridges/vme_fake.c:649:6: warning: no previous prototype for 'fake_vmewrite16' [-Wmissing-prototypes] drivers/vme/bridges/vme_fake.c:679:6: warning: no previous prototype for 'fake_vmewrite32' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/vme/bridges/vme_fake.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/drivers/vme/bridges/vme_fake.c b/drivers/vme/bridges/vme_fake.c index ebf35d3..29ac74f 100644 --- a/drivers/vme/bridges/vme_fake.c +++ b/drivers/vme/bridges/vme_fake.c @@ -381,8 +381,8 @@ static int fake_master_get(struct vme_master_resource *image, int *enabled, } -void fake_lm_check(struct fake_driver *bridge, unsigned long long addr, - u32 aspace, u32 cycle) +static void fake_lm_check(struct fake_driver *bridge, unsigned long long addr, + u32 aspace, u32 cycle) { struct vme_bridge *fake_bridge; unsigned long long lm_base; @@ -616,8 +616,8 @@ static ssize_t fake_master_read(struct vme_master_resource *image, void *buf, return retval; } -void fake_vmewrite8(struct fake_driver *bridge, u8 *buf, - unsigned long long addr, u32 aspace, u32 cycle) +static void fake_vmewrite8(struct fake_driver *bridge, u8 *buf, + unsigned long long addr, u32 aspace, u32 cycle) { int i; unsigned long long start, end, offset; @@ -646,8 +646,8 @@ void fake_vmewrite8(struct fake_driver *bridge, u8 *buf, } -void fake_vmewrite16(struct fake_driver *bridge, u16 *buf, - unsigned long long addr, u32 aspace, u32 cycle) +static void fake_vmewrite16(struct fake_driver *bridge, u16 *buf, + unsigned long long addr, u32 aspace, u32 cycle) { int i; unsigned long long start, end, offset; @@ -676,8 +676,8 @@ void fake_vmewrite16(struct fake_driver *bridge, u16 *buf, } -void fake_vmewrite32(struct fake_driver *bridge, u32 *buf, - unsigned long long addr, u32 aspace, u32 cycle) +static void fake_vmewrite32(struct fake_driver *bridge, u32 *buf, + unsigned long long addr, u32 aspace, u32 cycle) { int i; unsigned long long start, end, offset;