From patchwork Sun Sep 25 06:03:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76941 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp601436qgf; Sat, 24 Sep 2016 23:04:17 -0700 (PDT) X-Received: by 10.98.130.77 with SMTP id w74mr26873184pfd.5.1474783457116; Sat, 24 Sep 2016 23:04:17 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s75si17681373pfk.56.2016.09.24.23.04.15; Sat, 24 Sep 2016 23:04:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938795AbcIYGEN (ORCPT + 27 others); Sun, 25 Sep 2016 02:04:13 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:36657 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934317AbcIYGEM (ORCPT ); Sun, 25 Sep 2016 02:04:12 -0400 Received: by mail-pf0-f178.google.com with SMTP id q2so54760173pfj.3 for ; Sat, 24 Sep 2016 23:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=IorJ8mFumV/4W+YrFC1iuTkPVoIwMIyZ5sIAGpAbANA=; b=FYGbuizSqdPCgzzWUXKkwkJXyrf5dSvuFFpDcR2mp3Mz9vyLsG7P7Uw9v32yxe5mV7 ktatsBLKV6nS1fobtAwlqht4jwfHRX+xKNg6zKltPMRTwgf5nIja2bqTiXe07iKprbLi vZaarx4QkcVrVNOzKKP/+qONubh8WS6sJM59M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IorJ8mFumV/4W+YrFC1iuTkPVoIwMIyZ5sIAGpAbANA=; b=XURBJ39if4eXin0HVhCQ+nTvOV8qH4ke8w8ioInsjYqOa3tavo38v9ZK06cx+qF0kf pdIVR9m8ZIj08CjItbeSvq+En7jiQNWoboEytjwWMXK+MiilnN/+eBJlb8z8cZBoLyPS GBgP8VOoNZsNEVCXY65JEvkDfmJS1A08VNUOv3XO8BAbbroVOcCPJLXOGjMiaFqOq2Lz LdG9fBYf5YddgoK3DMfhlaA8DgIGvLGRMVf90tyGVQ324eD7+AtTZL7ndYO5MBhVCJGD wF0/glXGqkY6DEQnIfxouPQo6A5qhk4EZCdHK+fA+SWmcqa+euhd/wMrNRXJVnyVXtM1 raLA== X-Gm-Message-State: AE9vXwML+Ywvo8WdZNwbNNHgkgsH1dYppmU7P/NrokclEUc41yfD4ar0k1Baowo12E4BYXJO X-Received: by 10.98.93.85 with SMTP id r82mr27116566pfb.168.1474783451654; Sat, 24 Sep 2016 23:04:11 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.164]) by smtp.gmail.com with ESMTPSA id q25sm21852570pfj.48.2016.09.24.23.04.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 24 Sep 2016 23:04:10 -0700 (PDT) From: Baoyou Xie To: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] ixgbe: mark symbols static where possible Date: Sun, 25 Sep 2016 14:03:58 +0800 Message-Id: <1474783438-7278-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes] In fact, these two functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c index e092a89..dec8b11 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c @@ -2125,7 +2125,7 @@ static s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw) * @hw: pointer to hardware structure * @led_idx: led number to turn on **/ -s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data; @@ -2147,7 +2147,7 @@ s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) * @hw: pointer to hardware structure * @led_idx: led number to turn off **/ -s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data;