From patchwork Sun Sep 25 07:16:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76949 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp621275qgf; Sun, 25 Sep 2016 00:17:35 -0700 (PDT) X-Received: by 10.98.34.66 with SMTP id i63mr27545859pfi.130.1474787855484; Sun, 25 Sep 2016 00:17:35 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ro8si17959306pab.207.2016.09.25.00.17.35; Sun, 25 Sep 2016 00:17:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034158AbcIYHRc (ORCPT + 27 others); Sun, 25 Sep 2016 03:17:32 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34684 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033978AbcIYHR2 (ORCPT ); Sun, 25 Sep 2016 03:17:28 -0400 Received: by mail-pa0-f47.google.com with SMTP id zl8so2479220pac.1 for ; Sun, 25 Sep 2016 00:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=glEA5f5n4pAV3O9KVZjpS8p7AnWAm2+UiV1N+b/DL9U=; b=b1uA9t6f0r0kk16nMSbT492CQsbfPK1KqeLT5aWYiQzUOVpVCaS2oJgTPTXa3A4gQI hUN3t/a0cGHLCPPMrtGAYomI/0zUyLSUjeTgASdJSOICG1iOaPcZVYNlKYMiRifboMgT AgQK0924uWgWCDnn3xLNUg+amKQzaNycjjWxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=glEA5f5n4pAV3O9KVZjpS8p7AnWAm2+UiV1N+b/DL9U=; b=UbKaAbFqkr9Oxzm3miszHkoCcXjSAgj2QnQRgYnr1yP84c5F5lFn1FgDCtRWoAs/KC ktzdxNC3Dnp20IGA1YfsZUZ1jw8rqKLOuYIpywmdaGc/05HjUiCINjm/BhHdtUcASL1O gCtEKOMpSqm6yHvLYT248RYR3IId6xonfJV+b4Q37Ok0NLOwBOykvYUJU0Uo6lfN8f9Z Oe6/2VkWa1oXDaxAck7YZOYv10lX//6fPqdCiNuXSJqQ44aHIIQV5L1vYPC7aEe2JWNc y18OmL4/JIzq5ZoUjb2tdy8UB9k41CvlxbA2Tw+GDQTDwSqHcJXu7HdLtfzirWxm8R75 XTvA== X-Gm-Message-State: AA6/9Rmb6XcFVLRGWtoLSzybxITp6T5NItVwCufmrOgIFlsGD4DXZHvabH91Tx0jGbGGB+zx X-Received: by 10.66.20.104 with SMTP id m8mr10443942pae.11.1474787848106; Sun, 25 Sep 2016 00:17:28 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.164]) by smtp.gmail.com with ESMTPSA id c26sm15078883pfe.20.2016.09.25.00.17.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 25 Sep 2016 00:17:27 -0700 (PDT) From: Baoyou Xie To: jsarha@ti.com, tomi.valkeinen@ti.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 2/2] drm/tilcdc: mark symbols static where possible Date: Sun, 25 Sep 2016 15:16:45 +0800 Message-Id: <1474787805-18154-2-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1474787805-18154-1-git-send-email-baoyou.xie@linaro.org> References: <1474787805-18154-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 4 warnings when building kernel with W=1: drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:142:29: warning: no previous prototype for 'tilcdc_get_overlay' [-Wmissing-prototypes] drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:198:13: warning: no previous prototype for 'tilcdc_convert_slave_node' [-Wmissing-prototypes] drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:264:12: warning: no previous prototype for 'tilcdc_slave_compat_init' [-Wmissing-prototypes] drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: no previous prototype for 'tilcdc_atomic_check' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index f8892e9..562ee7f 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -75,7 +75,7 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev) drm_fbdev_cma_hotplug_event(priv->fbdev); } -int tilcdc_atomic_check(struct drm_device *dev, +static int tilcdc_atomic_check(struct drm_device *dev, struct drm_atomic_state *state) { int ret; diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c index f9c79da..dd8de260 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c @@ -139,7 +139,7 @@ static void __init tilcdc_node_disable(struct device_node *node) of_update_property(node, prop); } -struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft) +static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft) { const int size = __dtb_tilcdc_slave_compat_end - __dtb_tilcdc_slave_compat_begin; @@ -195,7 +195,7 @@ static const char * const tilcdc_slave_props[] __initconst = { NULL }; -void __init tilcdc_convert_slave_node(void) +static void __init tilcdc_convert_slave_node(void) { struct device_node *slave = NULL, *lcdc = NULL; struct device_node *i2c = NULL, *fragment = NULL; @@ -261,7 +261,7 @@ void __init tilcdc_convert_slave_node(void) of_node_put(fragment); } -int __init tilcdc_slave_compat_init(void) +static int __init tilcdc_slave_compat_init(void) { tilcdc_convert_slave_node(); return 0;