From patchwork Sun Sep 25 07:20:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76950 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp622196qgf; Sun, 25 Sep 2016 00:20:42 -0700 (PDT) X-Received: by 10.98.152.138 with SMTP id d10mr27172231pfk.8.1474788042174; Sun, 25 Sep 2016 00:20:42 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g15si17989369pfk.263.2016.09.25.00.20.41; Sun, 25 Sep 2016 00:20:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938838AbcIYHUj (ORCPT + 27 others); Sun, 25 Sep 2016 03:20:39 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33539 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934317AbcIYHUi (ORCPT ); Sun, 25 Sep 2016 03:20:38 -0400 Received: by mail-pa0-f50.google.com with SMTP id hm5so52784773pac.0 for ; Sun, 25 Sep 2016 00:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=95Ob2b4LZ6ucCyGjFi8D9nWUeLmSVqvcTht9fSUt6Jk=; b=d94Ge9Z0upLM1amYkiq39ZrHlet7/GgS3+mN0AwhnfO12VgDkLHbxldFb6m5iL2Q7z XHpnziGFS6jeXq4RMJhiMaVS6ikf+b3J/tCQo46OtEmKN1wVhhWDD4lpAHx2y84ebZ7J qHsdB9hOsiZxl/+JHi78+Y20ZYuSZ0J5MO8Ug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=95Ob2b4LZ6ucCyGjFi8D9nWUeLmSVqvcTht9fSUt6Jk=; b=XGAH21LODRkZMg028WzDBNTvmGQibh7YMS1dcHUt4pDwhRgaWFXsWw8gLrjCaKbDia z3X/QJfx9q20MujSfyj0ETbmRhhknv9wndv/CDJ+iKy+rWoi6j2W1hIpS9hLqPh//Ycf 2+YDugdVI/+qfRtr63mBx7/kUGHaEV6vvs8kVhcLgTCKkviZrTRXAMVaxGgNr7uuoG5Y /qjX00LSfJwFDXNPzyQjQV4Jye+ebxEXDPeGRlOgQx8VniiLKVfo0HLvIqluW4pRplzm XCIbsC3F30rQg2KurxTmrU3nzchIkHS0AzXaJogF9BAnNDa9cAQNpLpcnKL+pr7VAy4F PUGg== X-Gm-Message-State: AE9vXwNcq+t+Ch/3u8qOo8cDdPgnp4+4XJHLUlkrgFsZcAZqGcdmMp4Zkj1iIEw7ox032Sry X-Received: by 10.66.134.51 with SMTP id ph19mr27776053pab.30.1474788037506; Sun, 25 Sep 2016 00:20:37 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.164]) by smtp.gmail.com with ESMTPSA id i8sm22300225paw.25.2016.09.25.00.20.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 25 Sep 2016 00:20:36 -0700 (PDT) From: Baoyou Xie To: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH] drm: arm: mark symbols static where possible Date: Sun, 25 Sep 2016 15:20:24 +0800 Message-Id: <1474788024-30692-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes] drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/arm/malidp_planes.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 725098d..5f8bece 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -46,7 +46,8 @@ static void malidp_de_plane_destroy(struct drm_plane *plane) devm_kfree(plane->dev->dev, mp); } -struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) +static struct +drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) { struct malidp_plane_state *state, *m_state; @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) return &state->base; } -void malidp_destroy_plane_state(struct drm_plane *plane, +static void malidp_destroy_plane_state(struct drm_plane *plane, struct drm_plane_state *state) { struct malidp_plane_state *m_state = to_malidp_plane_state(state);