From patchwork Sun Sep 25 07:22:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76951 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp622725qgf; Sun, 25 Sep 2016 00:22:43 -0700 (PDT) X-Received: by 10.98.149.82 with SMTP id p79mr27490914pfd.150.1474788163567; Sun, 25 Sep 2016 00:22:43 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11si18047535pfd.86.2016.09.25.00.22.43; Sun, 25 Sep 2016 00:22:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938975AbcIYHWk (ORCPT + 27 others); Sun, 25 Sep 2016 03:22:40 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35381 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934317AbcIYHWi (ORCPT ); Sun, 25 Sep 2016 03:22:38 -0400 Received: by mail-pa0-f41.google.com with SMTP id oz2so52732743pac.2 for ; Sun, 25 Sep 2016 00:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Ie1uCB63HWvfYTw0XvO9LLDJBEuXB3jWpt0lMMIGbLo=; b=PLaBqe8m5NE+SAM5yWwKUj3BT193a3Dd7ABtWnzkPAZBQNRgBtA5qMof/LkKUkyKiS /3+HYDCOtVYS09EZoqiqIycpL9YgwT1wpyJSXXkr3DA6Mpn9iDa1bE6tLcpDG7AFRY3k wMSfE3LiODt16O0lGzzA2UA5WGFHUWOo8M8lY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ie1uCB63HWvfYTw0XvO9LLDJBEuXB3jWpt0lMMIGbLo=; b=MEdUiSgzZDI1Jc3ITwJok5pdL+NHgO4KVdONvCIyQjHQSfBgtCbJdpk+0Dy4HPkBlc 9xhI53RPLvziXMxZI79Pg+3EPSlwWatRJJlWjl6hlxE3UFS1k/+rMIyFOvokg3JfD+8b AY+nBT0niEZq22f38Qu2hljabs/jElSypcjCG88UIYfC1KE6d15f9jtpy2CV7kgCZQVm zcHVWToTbuTwa+fGCErPE+fxQpJjWCkcbwiAdzhzy5GdIvafmu750UvsHMeGPZXJm0YS SN6GpS1j6oA3Y/qYVFglWvxkRBVZ4WOgmSL5dnw+mvySTc3TsNp6bY4GPPrb/IYsMO8u dBag== X-Gm-Message-State: AE9vXwOwf4nQp/eUeXoL1vUEuHNeYh69GzFSrGJlFbQAa5cMSR0akm/nT41bKiIG0N+tbDny X-Received: by 10.66.23.69 with SMTP id k5mr27367089paf.144.1474788157676; Sun, 25 Sep 2016 00:22:37 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.164]) by smtp.gmail.com with ESMTPSA id i62sm22217976pfe.70.2016.09.25.00.22.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 25 Sep 2016 00:22:37 -0700 (PDT) From: Baoyou Xie To: rmk+kernel@armlinux.org.uk, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH] drm: armada: mark symbols static where possible Date: Sun, 25 Sep 2016 15:22:25 +0800 Message-Id: <1474788145-3068-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/armada/armada_gem.c:215:27: warning: no previous prototype for 'armada_gem_alloc_object' [-Wmissing-prototypes] drivers/gpu/drm/armada/armada_gem.c:423:1: warning: no previous prototype for 'armada_gem_prime_map_dma_buf' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/armada/armada_gem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c index cb8f034..1beef28 100644 --- a/drivers/gpu/drm/armada/armada_gem.c +++ b/drivers/gpu/drm/armada/armada_gem.c @@ -212,7 +212,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size) return obj; } -struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev, +static struct +armada_gem_object *armada_gem_alloc_object(struct drm_device *dev, size_t size) { struct armada_gem_object *obj; @@ -419,7 +420,7 @@ int armada_gem_pwrite_ioctl(struct drm_device *dev, void *data, } /* Prime support */ -struct sg_table * +static struct sg_table * armada_gem_prime_map_dma_buf(struct dma_buf_attachment *attach, enum dma_data_direction dir) {