From patchwork Mon Oct 24 08:00:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 78870 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp2440293qge; Mon, 24 Oct 2016 00:59:55 -0700 (PDT) X-Received: by 10.98.67.133 with SMTP id l5mr26179474pfi.170.1477295994977; Mon, 24 Oct 2016 00:59:54 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12si14190378pfd.37.2016.10.24.00.59.54; Mon, 24 Oct 2016 00:59:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934922AbcJXH7d (ORCPT + 27 others); Mon, 24 Oct 2016 03:59:33 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:26515 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933460AbcJXH70 (ORCPT ); Mon, 24 Oct 2016 03:59:26 -0400 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id u9O7w6Hn008639; Mon, 24 Oct 2016 16:58:08 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com u9O7w6Hn008639 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1477295888; bh=LtcjeDu119Mpc7+Wu4XwyHpv7kx9RI/T4ABGPKTWq4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rRWPw9dc93TW8vdiSLuhXmMnBS+CuiQUcYuiHHGHoOzqRHRHwx/QfkMLzRxsyVO9n Of+X553p7nKX+2rWNBvM5UC5hi6fh+B11+JsMS3fzb9EMSVUNA1NTtmfUEnHq/BlJI 8bah1sRj/Rvtx3KKRtfp8QBZoW4LhjipBcRcgWJJFqAh6ps71YcblVsG793wtwxa/w CPPV4Sh2mKaVT+QkgMZZo6MpSj1mMzK4MVGBE1aaRMda6QHZiP8iRpAjtsBVE+mb9i UQHxlTNZWguuxbwqyymK+xQNNYNxDPbxMr2TPStnfRE/sJy3WWFRRvoSjVy/6LQBjY l8l2krc1We2iw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-serial@vger.kernel.org Cc: Denys Vlasenko , Masahiro Yamada , Jiri Slaby , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] serial: 8250_uniphier: fix clearing divisor latch access bit Date: Mon, 24 Oct 2016 17:00:28 +0900 Message-Id: <1477296030-7517-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1477296030-7517-1-git-send-email-yamada.masahiro@socionext.com> References: <1477296030-7517-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At this point, 'value' is always a byte, then this code is clearing bit 15, which is already clear. I meant to clear bit 7. Signed-off-by: Masahiro Yamada Reported-by: Denys Vlasenko --- drivers/tty/serial/8250/8250_uniphier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c index a8babb0..417d9e7 100644 --- a/drivers/tty/serial/8250/8250_uniphier.c +++ b/drivers/tty/serial/8250/8250_uniphier.c @@ -99,7 +99,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value) case UART_LCR: valshift = UNIPHIER_UART_LCR_SHIFT; /* Divisor latch access bit does not exist. */ - value &= ~(UART_LCR_DLAB << valshift); + value &= ~UART_LCR_DLAB; /* fall through */ case UART_MCR: offset = UNIPHIER_UART_LCR_MCR;