From patchwork Fri Nov 4 10:49:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 80829 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1080702qge; Fri, 4 Nov 2016 03:48:07 -0700 (PDT) X-Received: by 10.98.196.89 with SMTP id y86mr25312713pff.172.1478256487175; Fri, 04 Nov 2016 03:48:07 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 129si15737016pfx.1.2016.11.04.03.48.06; Fri, 04 Nov 2016 03:48:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761702AbcKDKsC (ORCPT + 27 others); Fri, 4 Nov 2016 06:48:02 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:60564 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761280AbcKDKr7 (ORCPT ); Fri, 4 Nov 2016 06:47:59 -0400 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id uA4Akuxx012227; Fri, 4 Nov 2016 19:46:56 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com uA4Akuxx012227 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1478256416; bh=VaXAxlkAnXYbLqlxsWjb4sOtmfLB31niWiPto6A82aU=; h=From:To:Cc:Subject:Date:From; b=A0QtQeHd1Nb8JEk8XLihYpvFeAEIHsAxZowYpXVOfrRF36IdDSQH3Gn+IE34eRUVX VOSXXw3ajYe3rZOc+n6vzEsBuA051Ghvcd3xLhuvGlDnz91ypB9/rnb3djjwE10Q/R Qk17wYtDCFfUUbt63NEW19+NFmG5IIleoHOF9TgGXzhEayz8il4KNyMxl20wjxCZVn Uh2l4ohhnyL7qftyINJfS+Kdy/6gDtdaQQiRfp/NT+z70i/X5T2WFhw8RNSRBojt98 zDEqZxbVoITDMteqV4DLna5KqIet4IHfCVoFEgebWZawwjg+C5jgV4xLv9OM2308ZT QyAWhieMp7InQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-i2c@vger.kernel.org Cc: Masahiro Yamada , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Wolfram Sang Subject: [PATCH 1/2] i2c: uniphier: rename jump label to follow coding style guideline Date: Fri, 4 Nov 2016 19:49:20 +0900 Message-Id: <1478256561-7709-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Documentation/CodingStyle recommends to use label names which say what the goto does or why the goto exists. Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.9.1 diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c index cc80bb2..abc6770 100644 --- a/drivers/i2c/busses/i2c-uniphier.c +++ b/drivers/i2c/busses/i2c-uniphier.c @@ -373,7 +373,7 @@ static int uniphier_i2c_probe(struct platform_device *pdev) if (!clk_rate) { dev_err(dev, "input clock rate should not be zero\n"); ret = -EINVAL; - goto err; + goto disable_clk; } init_completion(&priv->comp); @@ -392,11 +392,11 @@ static int uniphier_i2c_probe(struct platform_device *pdev) priv); if (ret) { dev_err(dev, "failed to request irq %d\n", irq); - goto err; + goto disable_clk; } ret = i2c_add_adapter(&priv->adap); -err: +disable_clk: if (ret) clk_disable_unprepare(priv->clk);