From patchwork Thu Feb 9 14:17:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 93712 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp23370qgi; Thu, 9 Feb 2017 06:19:55 -0800 (PST) X-Received: by 10.84.217.18 with SMTP id o18mr4506693pli.51.1486649995435; Thu, 09 Feb 2017 06:19:55 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si10165159plm.293.2017.02.09.06.19.55; Thu, 09 Feb 2017 06:19:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbdBIOTF (ORCPT + 25 others); Thu, 9 Feb 2017 09:19:05 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:32844 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbdBIOSI (ORCPT ); Thu, 9 Feb 2017 09:18:08 -0500 Received: by mail-lf0-f43.google.com with SMTP id x1so3181213lff.0 for ; Thu, 09 Feb 2017 06:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=qd6NTr4r6zCBwlDzp6UKWJCFXHaB/7jhZ7tRrLuar98=; b=W6GFzTYGdm4Ljel82W9kwjKEvmPMyIDVAlDvEpRip4abm2sgxQn9SVMi9KS1ouwCSa sJkdI1yFcyr2OZT+nnWkXud2OA5+xp2gCRX4gHAAvpaB7bCNUnr5mICzuVpAt1UJkD6Z S0ikK7LdqMUsaiqH868taG6h/OUKuxuMPpzrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qd6NTr4r6zCBwlDzp6UKWJCFXHaB/7jhZ7tRrLuar98=; b=UG7COy33GOrQkaWZqoJpGjgwnZB0LSFnB8cCPv2cW8Yb4w68LdZ11NTYyZ0ESfv+Mf x1dD7r8QAHAEraDFpTLp+pWzhCQ4BAUhgVSE7Bd3nsUan7TJIxEN9K5BiAMYnFS8xHOK 0/+sXsHZzmgmUfdw7tO/j4CJGkI/kofigb/CJPYn4qkDaJRgEwMZFqtVkoFe4la7x5AV OJ9UQa95kXDguahiz1UX+k+t/e3/EbN32wQrmm46h1AsY0AtxLzfXOptsg4Z7RpGuG5r v89mNAB0EtkMXEA8Bm/igxliT8MA2CCOQF/dEW4ZoQl7RWpD/pJtx2vZSKsEcGCNP7ii P1zg== X-Gm-Message-State: AMke39kXOZlmLRxY6LWTOKmoOObuXV8th4YryPSreJFMdvzGbCcrjG5MlcviEwTA6LCkSj8o X-Received: by 10.46.14.1 with SMTP id 1mr1376269ljo.60.1486649866847; Thu, 09 Feb 2017 06:17:46 -0800 (PST) Received: from khorivan.synapse.com ([2001:67c:2e5c:2011::caa1]) by smtp.gmail.com with ESMTPSA id j11sm3502518lfd.23.2017.02.09.06.17.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Feb 2017 06:17:45 -0800 (PST) From: Ivan Khoronzhuk To: w-kwok2@ti.com, m-karicheri2@ti.com, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update Date: Thu, 9 Feb 2017 16:17:40 +0200 Message-Id: <1486649860-8824-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to update jiffies in txq->trans_start twice and only for tx 0, it's supposed to be done in netdev_start_xmit() and per tx queue. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/netcp_core.c | 2 -- 1 file changed, 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c index ebab1473..7c7ae08 100644 --- a/drivers/net/ethernet/ti/netcp_core.c +++ b/drivers/net/ethernet/ti/netcp_core.c @@ -1316,8 +1316,6 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev) if (ret) goto drop; - netif_trans_update(ndev); - /* Check Tx pool count & stop subqueue if needed */ desc_count = knav_pool_count(netcp->tx_pool); if (desc_count < netcp->tx_pause_threshold) {