From patchwork Thu Mar 30 21:01:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 96331 Delivered-To: patches@linaro.org Received: by 10.140.89.233 with SMTP id v96csp425848qgd; Thu, 30 Mar 2017 14:01:42 -0700 (PDT) X-Received: by 10.98.194.88 with SMTP id l85mr1122627pfg.55.1490907702561; Thu, 30 Mar 2017 14:01:42 -0700 (PDT) Return-Path: Received: from mail-pg0-x235.google.com (mail-pg0-x235.google.com. [2607:f8b0:400e:c05::235]) by mx.google.com with ESMTPS id e13si2948789pln.78.2017.03.30.14.01.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 14:01:42 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c05::235 as permitted sender) client-ip=2607:f8b0:400e:c05::235; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c05::235 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by mail-pg0-x235.google.com with SMTP id 81so50248919pgh.2 for ; Thu, 30 Mar 2017 14:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oTLjDdzXbH4hb7snV/iMtvIPyl82IRQQEWYW0uXRMYI=; b=NEULY3Zevif2yEbaNqbK6+b1XTJDyJzBHD9ote5kb7jbD0ggtv2ePAMaXQTWpvrpKy 4bV6Jm/KUcl7rstzSsU0TOIJ/arBH8JHEkZgZi4nwoxiB9F2ox0D/yMWpnEfV5gqY1mj 4zpXz++dJscfPt4FZxOI2DsPDYqeJHvWi/JHQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oTLjDdzXbH4hb7snV/iMtvIPyl82IRQQEWYW0uXRMYI=; b=CsdP0xy5H0G/yYYLGcB0KPkSWUQR1Ai+eUdJYMmFaxNXGdo/JtW08LlMJ+EOMl9ZS6 O/3NXZJTCtTQCzBgRPkx3fw3rhzC5MCE9DlzuoQQg/sng7ZdQurMZlNcDQ/UuhZhUf6x w/6h9Q5oAUxAu57c3Yzk047Fc6B9ZcAeAllBGt9qWKEll82R3V4mQhlofcPZPRdqJhnK taUBaQl+y89ZhsYQnGY7WvxXdCO9IugSl07WEiB3UbTo0don3sSzcp4KOaU9W/8XGvTa zuRIyo3SdWqlTNluD6C1gDQryslsMWun36nC5B0tjvNqr3NzlVsAz4NbjBa3/T362jTK o5xQ== X-Gm-Message-State: AFeK/H0O/4/iMfmvnLkP6hxf3DJpDdNNne70v3qB8kCOWDxGtlcYc9m5vXNErBVCqFbNOZM8C6A= X-Received: by 10.99.107.72 with SMTP id g69mr1117557pgc.149.1490907702269; Thu, 30 Mar 2017 14:01:42 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id y7sm6162626pfk.93.2017.03.30.14.01.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Mar 2017 14:01:41 -0700 (PDT) From: John Stultz To: lkml Cc: Nicolai Stange , Ingo Molnar , Thomas Gleixner , Daniel Lezcano , Richard Cochran , Prarit Bhargava , Stephen Boyd , John Stultz Subject: [PATCH 6/9] clockevents: Make clockevents_config() static Date: Thu, 30 Mar 2017 14:01:21 -0700 Message-Id: <1490907684-11186-7-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490907684-11186-1-git-send-email-john.stultz@linaro.org> References: <1490907684-11186-1-git-send-email-john.stultz@linaro.org> From: Nicolai Stange A clockevent device's rate should be configured before or at registration and changed afterwards through clockevents_update_freq() only. For the configuration at registration, we already have clockevents_config_and_register(). Right now, there are no clockevents_config() users outside of the clockevents core. To mitigiate the risk of drivers errorneously reconfiguring their rates through clockevents_config() *after* device registration, make clockevents_config() static. Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Daniel Lezcano Cc: Richard Cochran Cc: Prarit Bhargava Cc: Stephen Boyd Signed-off-by: Nicolai Stange Signed-off-by: John Stultz --- include/linux/clockchips.h | 1 - kernel/time/clockevents.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) -- 2.7.4 diff --git a/include/linux/clockchips.h b/include/linux/clockchips.h index 5d3053c..eef1569 100644 --- a/include/linux/clockchips.h +++ b/include/linux/clockchips.h @@ -182,7 +182,6 @@ extern u64 clockevent_delta2ns(unsigned long latch, struct clock_event_device *e extern void clockevents_register_device(struct clock_event_device *dev); extern int clockevents_unbind_device(struct clock_event_device *ced, int cpu); -extern void clockevents_config(struct clock_event_device *dev, u32 freq); extern void clockevents_config_and_register(struct clock_event_device *dev, u32 freq, unsigned long min_delta, unsigned long max_delta); diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 97ac095..4237e07 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -468,7 +468,7 @@ void clockevents_register_device(struct clock_event_device *dev) } EXPORT_SYMBOL_GPL(clockevents_register_device); -void clockevents_config(struct clock_event_device *dev, u32 freq) +static void clockevents_config(struct clock_event_device *dev, u32 freq) { u64 sec;