From patchwork Thu May 18 11:26:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 100086 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp670048qge; Thu, 18 May 2017 04:27:37 -0700 (PDT) X-Received: by 10.99.158.26 with SMTP id s26mr4061198pgd.132.1495106857221; Thu, 18 May 2017 04:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495106857; cv=none; d=google.com; s=arc-20160816; b=0nqdsrTP3ofaK1sqdPeFaEahL8jKoC3qGbb0kCKYrCtQ9TJZy+KDO/wWWe+4mGmz/7 6BQg+JIzvAXLxZX707BorN9i9k42A03lvCZ58dPKOnNoF3xbYvo60Z2NaCHRuF16VMbH jqtm1D7+UGAKS/W7RKsN241AdZAJjCzN3NxCX7pdIx8A++THrsHP+gqltD+VzCBwYOcb AiekhuXvALZSAx5d4IrvHB3EKftrouLKrLrSL7jDNMltHTLov0xO32bUITa3K1xNOwyV pXk3cS0OKGK4Mft5WyvuACX+AHJALF5JcXSqFsV0SzvXnLx5e4XFbKBtBN9+VcRbRWcp QMcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=H4Oa5yGQHLP2xIRjq3lq1JBMkgjUYBZWe/kerarE91s=; b=Q/77RwIyF/DKFcesDn0T3YCZ93Wv3XQZYMoFu5N/9UusG+syVVumvFxd4QY2tBhVfi kd+AimZX+G1bwJfWeM0Xg4G5Px4T0jB6LCBjctsSUwKGPI08YukavRvaC30vGot/VcnY p3GBkFzjK9rH/YC52DDkVyUuY2LpvjOpmMPjAgvikI5gEg2feLdDCFIGv5tJm1ahVNfN Z06A+usYOCEXbJ5ZcNX1k7bEWaoxRJpEFligreS7365UV0bVI6NlVaWgKmP6hsfavAtn /ZQiGaS+qEGNEr7JNi1wnkMFYeUUmQLE3Iram3Hh0OAPb1+XvM5RVLYnf7J+k+JZy9KX 0dRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91si4955098pla.131.2017.05.18.04.27.36; Thu, 18 May 2017 04:27:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934130AbdERL1b (ORCPT + 25 others); Thu, 18 May 2017 07:27:31 -0400 Received: from foss.arm.com ([217.140.101.70]:58704 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934111AbdERL1G (ORCPT ); Thu, 18 May 2017 07:27:06 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DBE10165C; Thu, 18 May 2017 04:27:05 -0700 (PDT) Received: from gby.emea.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23A223F3E1; Thu, 18 May 2017 04:27:03 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells Cc: Ofir Drang , linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org Subject: [PATCH v2 4/4] crypto: Documentation: fix none signal safe sample Date: Thu, 18 May 2017 14:26:46 +0300 Message-Id: <1495106806-2292-5-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1495106806-2292-1-git-send-email-gilad@benyossef.com> References: <1495106806-2292-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sample code was showing use of wait_for_completion_interruptible() for waiting for an async. crypto op to finish. However, if a signal arrived it would free the buffers used even while crypto HW might still DMA from/into the buffers. Resolve this by using wait_for_completion() instead. Reported-by: Eric Biggers Signed-off-by: Gilad Ben-Yossef --- Documentation/crypto/api-samples.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 diff --git a/Documentation/crypto/api-samples.rst b/Documentation/crypto/api-samples.rst index d021fd9..944f08b 100644 --- a/Documentation/crypto/api-samples.rst +++ b/Documentation/crypto/api-samples.rst @@ -48,7 +48,7 @@ Code Example For Symmetric Key Cipher Operation break; case -EINPROGRESS: case -EBUSY: - rc = wait_for_completion_interruptible( + rc = wait_for_completion( &sk->result.completion); if (!rc && !sk->result.err) { reinit_completion(&sk->result.completion);