From patchwork Thu Jun 22 07:07:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 106154 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp2316768qgd; Thu, 22 Jun 2017 00:09:19 -0700 (PDT) X-Received: by 10.98.1.72 with SMTP id 69mr1166235pfb.124.1498115359827; Thu, 22 Jun 2017 00:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498115359; cv=none; d=google.com; s=arc-20160816; b=avm5tg4nnqaVsVIQBfSGpp8SFzV9KAn74NJ3bkQjwbw/uebIJBEEnyGzR22c+F7A79 hcwvii4Ru+Y7ICFAzOudKis7Rd5wepBObYCs70o+6EmvMpzCpbWtCTfY17iWPDgUcTOb 1Nuj0hXmc+agSCJOTdEFTGMkkAO3QgXAOIuYIqMCpsHbtHwkEg28/WqoOW3qkiR3vmk6 xhY1fYGPKrvx1tNjyLeHartSIhd6353ce4oL4tDR3cNRLXayPBRVdu2DOOZH0a2snT9X Qmkf+l7QPLQMe2YyJUmws7TPyYgVZQvGBDu8bfhHTs86oDIwK2m5csGGFdvRFtzjWv9O cp2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=PbPmyjhJr7299xtQRFvB8DfEY/XV7BxUnve2Z3+PyHU=; b=Oh2wfaqlF1a3ESsjb3TbAp+DM2Br2qlVLHpacru4oLEYFBRioNOOdI/HIQHhSVU6wu xS8aSk3uVtRXpoqBsJjC9NO8UIxfKpexK55KLlEVbkcYinu6GNW7n3XNc86fBcZyj2Is MFFUtfhIOSqGGa2fRBrD48nQITz+BXchmNiXW/nzBRjXySslJ/A6lENJV/lohjkuFWCj Z85zCGeSx/6NUVQvGoJJbUgsE5ghZC98JJ2qWyVr2oeks9wyK90yPkIZlMEYRO/+wU8b 3sbti3LfLovjlFPxGgtgjx6VkGAI/5FJFU01gcy7NoEny+RTOY8sKnAEdEFcAT1eZM/c qmSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l20si544151pgu.585.2017.06.22.00.09.19; Thu, 22 Jun 2017 00:09:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbdFVHI4 (ORCPT + 25 others); Thu, 22 Jun 2017 03:08:56 -0400 Received: from foss.arm.com ([217.140.101.70]:33404 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbdFVHIx (ORCPT ); Thu, 22 Jun 2017 03:08:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15B9215AD; Thu, 22 Jun 2017 00:08:38 -0700 (PDT) Received: from gby.kfn.arm.com (unknown [10.45.48.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16DC73F587; Thu, 22 Jun 2017 00:08:35 -0700 (PDT) From: Gilad Ben-Yossef To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org Cc: Ofir Drang Subject: [PATCH 7/7] staging: ccree: use signal safe completion wait Date: Thu, 22 Jun 2017 10:07:53 +0300 Message-Id: <1498115276-1601-8-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1498115276-1601-1-git-send-email-gilad@benyossef.com> References: <1498115276-1601-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We were waiting for a completion notification of HW DMA operation using an interruptible wait which can result in data corruption if a signal interrupted us while DMA was not yet completed. Fix this by moving to uninterrupted wait. Fixes: abefd6741d ("staging: ccree: introduce CryptoCell HW driver"). Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.1.4 diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c index cffc8de..87f5ab6 100644 --- a/drivers/staging/ccree/ssi_request_mgr.c +++ b/drivers/staging/ccree/ssi_request_mgr.c @@ -382,7 +382,8 @@ int send_request( /* Wait upon sequence completion. * Return "0" -Operation done successfully. */ - return wait_for_completion_interruptible(&ssi_req->seq_compl); + wait_for_completion(&ssi_req->seq_compl); + return 0; } else { /* Operation still in process */ return -EINPROGRESS;