From patchwork Mon Aug 14 15:21:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 110032 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp4477532qge; Mon, 14 Aug 2017 08:22:49 -0700 (PDT) X-Received: by 10.99.114.7 with SMTP id n7mr21235676pgc.139.1502724169441; Mon, 14 Aug 2017 08:22:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502724169; cv=none; d=google.com; s=arc-20160816; b=CYdhYCZQ8626Fq0FoX1tBGLwd0GcI5ZYwgkGmbROL1oS7kMlc9/8Gbehj4pHNnPynq v0sxnz3XE4as0ByKz27WeS901KFm9x+xaV3+N+2k4hz6TcwD0WQ0ugR1U0D4M6FR17xG JzknNQjy1BljtaA8SOnBhTQeu4SwMBfAA3aSSihWdd53293bdoo3JijvnQLY6r1Hpw/7 KbPedEb3mUhFgI/uiYe6ptSrPcICES++xgyLDoVz9MTUrttKy+1bSfAZz6Ia1aUCVODq kloor3qsJEJlM4066lCbVdnlyfcWfasejgQtO8orVJS4XAn5Hybm3N4RXEsFnmIrEcyo 7i0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=MkxA8W48MV7k48NGoJLxibZ3RRBf5zXHPa/E/3CqHN0=; b=gzcymm+b4Eg0zQCtafC8Op3yiz2439KKByCWLdlVgX8HxXPTXH5J440kl4tpD9wOYu Z7rL2S7NBSTiPGcUulWjX35hkLlk2BdOQkhVMDP/ia/isIc3fhw/0FLz2MTHhauF4q35 /iKHaaY0Uasvh3je8Tbr+nHVFLqRyHk4pfP1PZSUejpzK40PWZDQ22DL4p9lKpYNBqbf 1shVQDxX4DsXHo0lJov6pwOcUSD7My40pA/Bre0SfGW0uY9TTKGE7brKIslh65wExB2A 9HqZwrPbga4j0pEBOkY/DtmPBGL1JjhkkDIfQVf7rXEFAH2hdJk1RNfk1Tv/tQ81OYzS DdCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v22si4251102pgo.442.2017.08.14.08.22.49; Mon, 14 Aug 2017 08:22:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753115AbdHNPWo (ORCPT + 25 others); Mon, 14 Aug 2017 11:22:44 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39710 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314AbdHNPWk (ORCPT ); Mon, 14 Aug 2017 11:22:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 20FAA80D; Mon, 14 Aug 2017 08:22:40 -0700 (PDT) Received: from gby.kfn.arm.com (unknown [10.45.48.148]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 85B783F483; Mon, 14 Aug 2017 08:22:31 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells , Tom Lendacky , Gary Hook , Boris Brezillon , Arnaud Ebalard , Matthias Brugger , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Shaohua Li , Steve French , "Theodore Y. Ts'o" , Jaegeuk Kim , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fscrypt@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-security-module@vger.kernel.org Cc: Ofir Drang Subject: [PATCH v5 04/19] crypto: marvell/cesa: remove redundant backlog checks on EBUSY Date: Mon, 14 Aug 2017 18:21:14 +0300 Message-Id: <1502724094-23305-5-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1502724094-23305-1-git-send-email-gilad@benyossef.com> References: <1502724094-23305-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/marvell/cesa.c | 3 +-- drivers/crypto/marvell/cesa.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) -- 2.1.4 diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c index 6e7a5c7..269737f 100644 --- a/drivers/crypto/marvell/cesa.c +++ b/drivers/crypto/marvell/cesa.c @@ -183,8 +183,7 @@ int mv_cesa_queue_req(struct crypto_async_request *req, spin_lock_bh(&engine->lock); ret = crypto_enqueue_request(&engine->queue, req); if ((mv_cesa_req_get_type(creq) == CESA_DMA_REQ) && - (ret == -EINPROGRESS || - (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG))) + (ret == -EINPROGRESS || ret == -EBUSY) mv_cesa_tdma_chain(engine, creq); spin_unlock_bh(&engine->lock); diff --git a/drivers/crypto/marvell/cesa.h b/drivers/crypto/marvell/cesa.h index b7872f6..63c8457 100644 --- a/drivers/crypto/marvell/cesa.h +++ b/drivers/crypto/marvell/cesa.h @@ -763,7 +763,7 @@ static inline int mv_cesa_req_needs_cleanup(struct crypto_async_request *req, * the backlog and will be processed later. There's no need to * clean it up. */ - if (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG) + if (ret == -EBUSY) return false; /* Request wasn't queued, we need to clean it up */