From patchwork Mon Oct 9 14:35:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 115254 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2629148qgn; Mon, 9 Oct 2017 07:35:55 -0700 (PDT) X-Google-Smtp-Source: AOwi7QB2PGecxFW1cVPqTyTSbzkkUuP2hm+cuedcCGx6Bf4fhlb64RS+NehKf8eMuvuTDnI16olM X-Received: by 10.98.104.198 with SMTP id d189mr10624174pfc.55.1507559755265; Mon, 09 Oct 2017 07:35:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507559755; cv=none; d=google.com; s=arc-20160816; b=F+JXiNX88v9uTDN2ikohxdNCSSum+ClJsjfq20LMD4Jmc9ZfwT+C2hgxAEG2dkXTKP yE0hcbWWtBJk9G62q1PYLRWqGRCDzcDwkwDBNjPgt08G4cQqFdaaoohEadOctITj7MXr PiFrt+5RCqnM06I9/DaFVm897K65tDw8yVX0XFEXixLU/lB8gjt/uvSoN+RlHfCObfoW RHsoXGsbULRNCd0IjOtYs5c5629Qq8a4c78cRr7acy4RKouEBLQrhzudfUqrNvg8kbZQ U99OWHdePQ4apxMxsVQRt4ApjL/IEzHUxj3nXlycbXU1tbdRRfag1LLGLlTcLXPrsRYS K5OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=UsZH4SJbRn2VBEhLQA/xUCVRwLc1HbN7wd8EuVpqrCY=; b=wtZsrR3fNrYio20DvTXXq33CsfcfIRe3j2XAQlItFgGttPwuZgsmx0z5MimH4RDLp2 vx2s0gNcmtC9mM0A6W37ofzwWpxPj3EA7OCPuMsrJzM/leEDOJBfZ3GWbZYTtGbGGDsS yhwVZi7VlcreP7ghLNmUufQ5wZYjH20tVgyjRhy8+TJRLFpMfPWEhGkM88wjku7CRxds l8YP0hgRqAkcxKtQYxY2MavxUhMofQyobRPHy9Ev+9NSA4QsGKxvIs7FA4YYQ+j03oQu 0biu6aNrfXBJw+04FLZ8ICDJrO2wzaItAEEWKcRYz/ROQQsVID8kZhePLCBwOEHOvPpL PzXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=0i44Cre7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o62si6314534pga.317.2017.10.09.07.35.54; Mon, 09 Oct 2017 07:35:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=0i44Cre7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754594AbdJIOfw (ORCPT + 26 others); Mon, 9 Oct 2017 10:35:52 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:32037 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754212AbdJIOfu (ORCPT ); Mon, 9 Oct 2017 10:35:50 -0400 X-Greylist: delayed 576 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Oct 2017 10:35:49 EDT Received: from grover.sesame (FL1-122-131-185-176.osk.mesh.ad.jp [122.131.185.176]) (authenticated) by conuserg-11.nifty.com with ESMTP id v99EZVZF018442; Mon, 9 Oct 2017 23:35:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com v99EZVZF018442 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1507559733; bh=UsZH4SJbRn2VBEhLQA/xUCVRwLc1HbN7wd8EuVpqrCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0i44Cre774G5H218p40rQJsU5QO5zybOBMG4XDgjBbCTc6Km+nPA/YZHLej9lVn4z 3uYdDsuPhGSLm6GZESWHQxtzc2xO8HizZzYMFt5/IL6MH3gT5ZGdBsyZWP59ZVxOXL Gx/pARwuHizn3w6OG0TfPvR7IqZWUWbRxfCgIMZcd5SOOcJV2dcsDi4Vq0F/DQX4Pe F0gehvU/stw7xTYBeqU58NDuCX5aTTgi1BbVQ7oeEwW5wR4OSkKczcFz/bhF9wfvL6 J6NzKLsiJetY6x1no2CUPJyBFYcW/W11jpfh9ILl7cF0x+SvoB4OvdJWNFOR1f2KF1 TMpTL+wFqrKXg== X-Nifty-SrcIP: [122.131.185.176] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Richard Kuo , linux-kernel@vger.kernel.org, linux-hexagon@vger.kernel.org Subject: [PATCH 2/3] hexagon: add KBUILD_ prefix to CFLAGS_MODULE, LDFLAGS_MODULE Date: Mon, 9 Oct 2017 23:35:14 +0900 Message-Id: <1507559715-30918-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507559715-30918-1-git-send-email-yamada.masahiro@socionext.com> References: <1507559715-30918-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org {CFLAGS,LDFLAGS}_MODULE are supposed to be set by users, not by in-kernel makefiles. Documentation/kbuild/makefiles.txt clearly explains the difference: KBUILD_CFLAGS_MODULE Options for $(CC) when building modules $(KBUILD_CFLAGS_MODULE) is used to add arch-specific options that are used for $(CC). From commandline CFLAGS_MODULE shall be used (see kbuild.txt). KBUILD_LDFLAGS_MODULE Options for $(LD) when linking modules $(KBUILD_LDFLAGS_MODULE) is used to add arch-specific options used when linking modules. This is often a linker script. From commandline LDFLAGS_MODULE shall be used (see kbuild.txt). Signed-off-by: Masahiro Yamada --- arch/hexagon/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile index 207711a0..4f5c84c 100644 --- a/arch/hexagon/Makefile +++ b/arch/hexagon/Makefile @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums # Modules must use either long-calls, or use pic/plt. # Use long-calls for now, it's easier. And faster. -# CFLAGS_MODULE += -fPIC -# LDFLAGS_MODULE += -shared -CFLAGS_MODULE += -mlong-calls +# KBUILD_CFLAGS_MODULE += -fPIC +# KBUILD_LDFLAGS_MODULE += -shared +KBUILD_CFLAGS_MODULE += -mlong-calls cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})