From patchwork Sun Dec 3 13:58:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 120466 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3363579qgn; Sun, 3 Dec 2017 06:01:46 -0800 (PST) X-Google-Smtp-Source: AGs4zMbKpAkZVi46I9IpNDW3cjX+JFAAYGgmEumGW99Jvt6MEk9B+fxA86QJo8ZzitbedDAv19nq X-Received: by 10.98.222.197 with SMTP id h188mr16461375pfg.132.1512309706863; Sun, 03 Dec 2017 06:01:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512309706; cv=none; d=google.com; s=arc-20160816; b=MUh05dlpVSWVSIeWvrq5gbpwgIvFppx5Es0Ca56pSWbkkxHpP7kr2pADbCqep36z51 mLDUYDSiagLImtH1wGGNUehCSVwafpqZNdWiG4cBs+0GeU1oThE3jAlLhUqMpALCWtUc fT/QAy6q72RNAsYU9/FgXgMjVkKJxRLKLoSlT0QVaokHXPlhBbFGShOEAcmVywiWDPFV K/GuV+jCSqk5nXsA4p+GSB/V2GkYgNaCahI6+m/Jdu9J/hcSxsFmudtG6+G/+JWytzc7 zP+rUFEBr/NUUC3Iyjdx2JNVXCz4bAOdl/LoAkueLkRJu4mmbkS/UmKdQqmhJdpYjXrl UCgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=USYFzZYqVBoqQCNzayYPBscsAXb9fXkMvBb45gaoAlM=; b=qMizewlxO+4Q1oBpHX8EA+lZWXgspWxYLKcGX9WW9VQ9KKNgZO7x11K7/BArHF6PQx ZCY/Ddbu2FpfLdy0NHD8znyXEXWY/kLtUPWCxe3voLG1hp4XNQj3Hw4z5Hw0SQwbsdP+ b0+ZMl6padyIaTKdX8OczPwE2inR+x7u+dKzdioCXkw4xjZE94Z0r7gP83Z3PdEMDi1g DWOzYwaymTS0Ki5L0ldOtnfCgf/zL81Un+YuUKVsWtstSEFPOsSCp7ghBWsST25+tZcX 7sLg/k8eMasNolFy3w2ezi5y6hO5ycReyAn1DT14EdusMsCFw5XhVAtQ3JuPOP0Z1dmQ OAmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t8si7948490plz.487.2017.12.03.06.01.46; Sun, 03 Dec 2017 06:01:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695AbdLCOBp (ORCPT + 28 others); Sun, 3 Dec 2017 09:01:45 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:55162 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbdLCN7b (ORCPT ); Sun, 3 Dec 2017 08:59:31 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9F9E41529; Sun, 3 Dec 2017 05:59:30 -0800 (PST) Received: from localhost.localdomain (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E059C3F24A; Sun, 3 Dec 2017 05:59:27 -0800 (PST) From: Gilad Ben-Yossef To: Greg Kroah-Hartman Cc: Ofir Drang , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org Subject: [PATCH 03/10] staging: ccree: remove more unnecessary parentheses Date: Sun, 3 Dec 2017 13:58:14 +0000 Message-Id: <1512309503-29766-4-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512309503-29766-1-git-send-email-gilad@benyossef.com> References: <1512309503-29766-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The removal of likely/unlikely unearthed some more unnecessary parentheses. Remove them for better readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 4 ++-- drivers/staging/ccree/ssi_driver.c | 6 +++--- drivers/staging/ccree/ssi_request_mgr.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.7.4 diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c index 7ceee91..bac9d12 100644 --- a/drivers/staging/ccree/ssi_buffer_mgr.c +++ b/drivers/staging/ccree/ssi_buffer_mgr.c @@ -882,7 +882,7 @@ static int cc_aead_chain_assoc( else areq_ctx->assoc_buff_type = SSI_DMA_BUF_MLLI; - if ((do_chain) || areq_ctx->assoc_buff_type == SSI_DMA_BUF_MLLI) { + if (do_chain || areq_ctx->assoc_buff_type == SSI_DMA_BUF_MLLI) { dev_dbg(dev, "Chain assoc: buff_type=%s nents=%u\n", cc_dma_buf_type(areq_ctx->assoc_buff_type), areq_ctx->assoc.nents); @@ -1656,7 +1656,7 @@ void cc_unmap_hash_request(struct device *dev, void *ctx, areq_ctx->mlli_params.mlli_dma_addr); } - if ((src) && areq_ctx->in_nents) { + if (src && areq_ctx->in_nents) { dev_dbg(dev, "Unmapped sg src: virt=%pK dma=%pad len=0x%X\n", sg_virt(src), &sg_dma_address(src), sg_dma_len(src)); dma_unmap_sg(dev, src, diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c index 6282c37..0b2593f 100644 --- a/drivers/staging/ccree/ssi_driver.c +++ b/drivers/staging/ccree/ssi_driver.c @@ -111,7 +111,7 @@ static irqreturn_t cc_isr(int irq, void *dev_id) drvdata->irq = irr; /* Completion interrupt - most probable */ - if ((irr & SSI_COMP_IRQ_MASK)) { + if (irr & SSI_COMP_IRQ_MASK) { /* Mask AXI completion interrupt - will be unmasked in * Deferred service handler */ @@ -121,7 +121,7 @@ static irqreturn_t cc_isr(int irq, void *dev_id) } #ifdef CC_SUPPORT_FIPS /* TEE FIPS interrupt */ - if ((irr & SSI_GPR0_IRQ_MASK)) { + if (irr & SSI_GPR0_IRQ_MASK) { /* Mask interrupt - will be unmasked in Deferred service * handler */ @@ -131,7 +131,7 @@ static irqreturn_t cc_isr(int irq, void *dev_id) } #endif /* AXI error interrupt */ - if ((irr & SSI_AXI_ERR_IRQ_MASK)) { + if (irr & SSI_AXI_ERR_IRQ_MASK) { u32 axi_err; /* Read the AXI error ID */ diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c index 7a653f6..e890cb6 100644 --- a/drivers/staging/ccree/ssi_request_mgr.c +++ b/drivers/staging/ccree/ssi_request_mgr.c @@ -221,7 +221,7 @@ static int request_mgr_queues_status_check( return -EBUSY; } - if ((req_mgr_h->q_free_slots >= total_seq_len)) + if (req_mgr_h->q_free_slots >= total_seq_len) return 0; /* Wait for space in HW queue. Poll constant num of iterations. */