From patchwork Wed Dec 6 10:32:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 120803 Delivered-To: patch@linaro.org Received: by 10.80.152.193 with SMTP id j59csp3279676edb; Wed, 6 Dec 2017 02:33:36 -0800 (PST) X-Google-Smtp-Source: AGs4zMYMjcGVwdbmtXyZMIQFGB26VdOLr6gBPoz+FEYAaOVa+PPNPHEUAikdzCgO0z3vtTHNYi0B X-Received: by 10.84.234.199 with SMTP id i7mr21612564plt.377.1512556416247; Wed, 06 Dec 2017 02:33:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512556416; cv=none; d=google.com; s=arc-20160816; b=LK5oNzkYYpJfwxkSgEvXQXJbA39CpvNvHB59Nvp8E2+6JM0cOtdCFNoef+I+YnA94Q /7N6Oh28Qbf3A665XJiM7lp3CnWweHQQrJzz1Q5d1d5TiY21sIwNozsYLt59hRFutxJm 4fN0bAo7vDSS5jNg3Z5QJzbAQHbyA9H5Ntdcz9AjFwsMLn6Kx91n1Jj9qkwxQLvQjAg3 Q5qXYERoJvJ8xu+ZbPrNKhQP1QYzOWMl8aG2NwFtg7ZO3kkgAndlvbsNIdJwrTADmlbX /SF/YtWt3M/lrnxza2IgQk5+VMLtaRmO37Icpw54QP3FbJzBIjfXyyaOtwC+IDhYBqxx VEGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=lK1dl/EwoL9aUtr8wnwc1JC9oBAB2OClWpGzCFGYA4U=; b=JkMDHNcHuPqbaBlhMeGBhT6PAe91B+r/P5YJIBLUbTj3M0q3Ite2n6lPtrhK28BUip ktguLpX0zXUwlsSMTTMzyJfrNTe8It9+e+gq8KghbjgCMfq8J7YJ9hEV07FqEGuo4uS+ cBsnSZe4lAtbnzlNbIhjcHuXoq6a22IaiXGY/4BWhBkeHwqHyHhazwNAWK3GTWpdAfiQ KiVcNNZhHuzkLgAcyQDWZBA75xiYspKXN0T1oJ9wywOD0Gz1sV4301Lx2qjJwq4dpssz AYMOnPUmraND0jXVmrxy0BvQ0fTf+N16vC2J1nqlU88hkTpFjD3blDZNt8O/QVnvTU55 kYmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JDocqYYW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si1637283pgo.729.2017.12.06.02.33.35; Wed, 06 Dec 2017 02:33:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JDocqYYW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755028AbdLFKdf (ORCPT + 28 others); Wed, 6 Dec 2017 05:33:35 -0500 Received: from conuserg-07.nifty.com ([210.131.2.74]:48266 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754867AbdLFKdb (ORCPT ); Wed, 6 Dec 2017 05:33:31 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id vB6AX4KB025983; Wed, 6 Dec 2017 19:33:04 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com vB6AX4KB025983 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1512556384; bh=lK1dl/EwoL9aUtr8wnwc1JC9oBAB2OClWpGzCFGYA4U=; h=From:To:Cc:Subject:Date:From; b=JDocqYYWzUImF3z0WB4GqkcK19lDWosvO5rBPccq7ImxIRjQpTYNiglgIlfuKcfTR DerrTTtEnu/6jvz6wbOvpMTfrvtdjun0vFVz/Byf4xQeBSJnx96fAj0w5CmT1AwtJu IrS1JLXLiiZEVkMtD1YcxLyVCz5GbyGxZ1obt8QYVFqxjqPsqJIrvSOKmMnjhEN79i +5RVpA4xKsYF/nl9Eht4bkw3Q2xdXaZMrP+XbTYnFSLOwf1ObDPQb8If0wlgxI89G6 4/F+4OwMPOj2I2tNJiHxPSjSVW135jAqJmAP3X3rZ7F3EsTfZRZ/mfi7OfTl9rG34Y ByjfzJqq4REzg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH] kbuild: pkg: make out-of-tree rpm/deb-pkg build immediately fail Date: Wed, 6 Dec 2017 19:32:57 +0900 Message-Id: <1512556378-13310-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We do not support out-of-tree building of rpm-pkg / deb-pkg. If O= is given, the build should be terminated, but the "false" command is not effective because it is not the last command in the cmd_src_tar. Then, rpm-pkg / deb-pkg tries to continue building, and fails for a different reason. Set -e option so that the "false" terminates the building immediately. I also put the error messages to stderr, and made it stand out more. For example, "make O=foo rpm-pkg" will fail as follows: /bin/bash ../scripts/package/mkspec >./kernel.spec TAR kernel-4.15.0_rc2+.tar.gz ERROR: Building source tarball is not possible outside the kernel source tree. Don't set KBUILD_OUTPUT, or use the binrpm-pkg or bindeb-pkg target instead. ../scripts/package/Makefile:53: recipe for target 'rpm-pkg' failed Signed-off-by: Masahiro Yamada --- scripts/package/Makefile | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.7.4 Tested-by: Jim Davis diff --git a/scripts/package/Makefile b/scripts/package/Makefile index 61e29da..9fbcf5e 100644 --- a/scripts/package/Makefile +++ b/scripts/package/Makefile @@ -32,10 +32,14 @@ MKSPEC := $(srctree)/scripts/package/mkspec quiet_cmd_src_tar = TAR $(2).tar.gz cmd_src_tar = \ +set -e; \ if test "$(objtree)" != "$(srctree)"; then \ - echo "Building source tarball is not possible outside the"; \ - echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \ - echo "binrpm-pkg or bindeb-pkg target instead."; \ + echo >&2; \ + echo >&2 " ERROR:"; \ + echo >&2 " Building source tarball is not possible outside the"; \ + echo >&2 " kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \ + echo >&2 " binrpm-pkg or bindeb-pkg target instead."; \ + echo >&2; \ false; \ fi ; \ $(srctree)/scripts/setlocalversion --save-scmversion; \