From patchwork Fri Dec 8 17:16:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 121213 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp869001qgn; Fri, 8 Dec 2017 08:36:29 -0800 (PST) X-Google-Smtp-Source: AGs4zMbVV0T3HSDavskTWkRPLZKmw5r3HJhVUj2a3x6vcaMaUkx2jBXAFQWfWQbCVXWJOpHthFn+ X-Received: by 10.84.169.4 with SMTP id g4mr30837108plb.393.1512750988954; Fri, 08 Dec 2017 08:36:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512750988; cv=none; d=google.com; s=arc-20160816; b=vSk0xJ3PgrEPOpaaX1me4EfOIPUF1zJio6ft75hNc061NbDAgapxJCaDWLxDDP+xrY Kk5u/nTZ3fRon7G2ywu2AQ+WeOt1fVzZjsQ7SJOC+zy7HpB85uwrDBnEntihjNyUYXiw ttOXuLPawQwf9E1dCKcFOV6G9IUBaTjP7M8RMmHH/kEAZywHTONJmmBcKYhTMnlu6NP+ qaTQnhP1Yy9nUxqXiIQAUpGtVynAwX3eoXZiLQh/vUyfQPu+PoNvd44AijAb73cd3tX3 yXBoF/Zwcq5ocCTxq5Xs3vAJ81pzB6tfhZINcoYPrQMlPaTKKLlayNzF7bSGOGU46rHq K9Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=l9C21YW5kszpNZ8l1+xjxePzh0K42MFxyALEMqVxkpw=; b=tSIYjIFEstnd0Cbkvau22WnHBClUZAhI4KW89VWglfLWmZlnKr3+xGHjqnu8Wir93A 1mVc2fM0aLNrE9DRL8HxPQzfNkMrvJZUViiZM2aXUfR8/TPd68Md527wCvYA5sQ7h8Ci 5y2WUdOSbEwgnHckXO0mQ63ewTPvgNJ5v8X8+rU72VAHMx7LmZdbzOzsNtzDREYDladT g+KjNhUAI17BDRdVsyzc8/PSc3iIzyGdeBSTjFR1Oy0aJo82SjM5HxwiJuvULX3YwZ/G /Q8pw25xW9trw0tCQBzjLJ1lpwqkxhBbG1qz+gNZQDLU1ACjiXeO/O9yDlaxVVPlMmsz 7Hlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si5704222pgt.705.2017.12.08.08.36.28; Fri, 08 Dec 2017 08:36:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbdLHQgZ (ORCPT + 18 others); Fri, 8 Dec 2017 11:36:25 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2223 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752606AbdLHQa7 (ORCPT ); Fri, 8 Dec 2017 11:30:59 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 965D4E2153176; Sat, 9 Dec 2017 00:30:44 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.361.1; Sat, 9 Dec 2017 00:30:35 +0800 From: John Garry To: , CC: , , , Xiang Chen , "John Garry" Subject: [PATCH 01/19] scsi: hisi_sas: initialize dq spinlock before use Date: Sat, 9 Dec 2017 01:16:32 +0800 Message-ID: <1512753410-50924-2-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1512753410-50924-1-git-send-email-john.garry@huawei.com> References: <1512753410-50924-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiang Chen It is required to initialize the dq spinlock before use, which was not being done, so fix it. This issue can be detected when CONFIG_DEBUG_SPINLOCK is enabled. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 5f503cb..359ec52 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -1657,6 +1657,7 @@ int hisi_sas_alloc(struct hisi_hba *hisi_hba, struct Scsi_Host *shost) cq->hisi_hba = hisi_hba; /* Delivery queue structure */ + spin_lock_init(&dq->lock); dq->id = i; dq->hisi_hba = hisi_hba;