From patchwork Tue Jan 9 12:23:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 123901 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3951003qgn; Tue, 9 Jan 2018 04:18:29 -0800 (PST) X-Google-Smtp-Source: ACJfBosBoi3xxFz+WPfK+RWIn4uF2gOwAVp8tMUmpk3hDSoNaXQl43sEt4fr0x/iyZLV6G3GUQqU X-Received: by 10.98.64.219 with SMTP id f88mr13804576pfd.197.1515500309467; Tue, 09 Jan 2018 04:18:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515500309; cv=none; d=google.com; s=arc-20160816; b=PqTTHH4kMo7oqo3SRrE+SydXRDygjuzmbJlt7J43q5FHVTNSFVcoNEKP2vdOsp0hFa bf62r1HTTH8IiAkVoLBx0c/cBhwqAPj4vXDWeMc16hE5q+RPg6FDUUbZ4fHHFp3jcdVo bwEDiO9ygnUsPti84DYulRyi8DNETFi105QgHE4AJ78GLvu07HfbLNCkrPBSDwu/FNb5 HFxBOF9l/qAk22c6mhjp/DYEVCaNKaZXJc3P4+07cwOmPgRoGd3qn2O1e4vv2gSX48ou Jf+rSSePw3URZ6vbmHQFZlCnHJ9azs1IaaXCbob13QkzELzZoMm3/e9zLwWiZN0Rkmcm /d8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=fw7g0vxVIb4bf5eOFbISPLPmisQ3epZlbHB5qvmDJL8=; b=QG33t5Dg4g8MqdKv++ALJQSUGmXDQqJ8oKLyhKiuE0QIbDpbNpIJg49s/eqQgDPADq kwYCkZa1GkTeCHY22CXTsrFfD2bWfYD7NyYZPaLZrcXftwm3VS2Ge653dcekaIESuUmo tEO9qR9Cvx10KUk3JWrqXV8op4HnIOS4219IgBNg01KRZWxS8CIAqHflP6fOMcusafcf eOB4chRuH6EI/PeO07Tlqu5kQLy267bei9EpfzS4RNnjkm/lciFh6wCfC7zwNJkeRECS Xyy0lz5KyZy2T6yTzd7Ne1OokTpt+TM0EDIJz5fs/ASFhjdtsYxOnXd1oiPKDSPxFqE4 my/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c20si10323697plo.423.2018.01.09.04.18.29; Tue, 09 Jan 2018 04:18:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753577AbeAIMS1 (ORCPT + 28 others); Tue, 9 Jan 2018 07:18:27 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:39864 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751642AbeAIMSK (ORCPT ); Tue, 9 Jan 2018 07:18:10 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AB5445CD4DC36; Tue, 9 Jan 2018 20:18:05 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.361.1; Tue, 9 Jan 2018 20:18:00 +0800 From: Xiongfeng Wang To: , CC: , , Subject: [PATCH] HID: uhid: use strlcpy() instead of strncpy() Date: Tue, 9 Jan 2018 20:23:32 +0800 Message-ID: <1515500612-191425-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/hid/uhid.c: In function 'uhid_dev_create2': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may be truncated copying 127 bytes from a string of length 127 [-Wstringop-truncation] The compiler require that the input param 'len' of strncpy() should be greater than the length of the src string, so that '\0' is copied as well. We can just use strlcpy() to avoid this warning. Signed-off-by: Xiongfeng Wang --- drivers/hid/uhid.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 1.8.3.1 diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 6f819f1..0315ddd 100644 --- a/drivers/hid/uhid.c +++ b/drivers/hid/uhid.c @@ -496,12 +496,12 @@ static int uhid_dev_create2(struct uhid_device *uhid, goto err_free; } - len = min(sizeof(hid->name), sizeof(ev->u.create2.name)) - 1; - strncpy(hid->name, ev->u.create2.name, len); - len = min(sizeof(hid->phys), sizeof(ev->u.create2.phys)) - 1; - strncpy(hid->phys, ev->u.create2.phys, len); - len = min(sizeof(hid->uniq), sizeof(ev->u.create2.uniq)) - 1; - strncpy(hid->uniq, ev->u.create2.uniq, len); + len = min(sizeof(hid->name), sizeof(ev->u.create2.name)); + strlcpy(hid->name, ev->u.create2.name, len); + len = min(sizeof(hid->phys), sizeof(ev->u.create2.phys)); + strlcpy(hid->phys, ev->u.create2.phys, len); + len = min(sizeof(hid->uniq), sizeof(ev->u.create2.uniq)); + strlcpy(hid->uniq, ev->u.create2.uniq, len); hid->ll_driver = &uhid_hid_driver; hid->bus = ev->u.create2.bus;