From patchwork Fri Jan 12 07:45:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 124256 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1742784qgn; Thu, 11 Jan 2018 23:39:44 -0800 (PST) X-Google-Smtp-Source: ACJfBosLC3M8RLGzVQHFldMg44FCS7QXhUn1ZVdrf0owHe/3vUQC0OZRaPSTwahNuYVn14unV49Y X-Received: by 10.98.91.193 with SMTP id p184mr22349138pfb.16.1515742784296; Thu, 11 Jan 2018 23:39:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515742784; cv=none; d=google.com; s=arc-20160816; b=Xt2be0I2p0jRRAD/TtvKEOOfTFGzvPoyI6DmLSO6tb9P/5kOWN0l1lt6+y0Y0O+MpZ MdKDlMBhurwlmv3fj12RNRHhShLI7rFLhPHrTvqJ5OT+o5QJnwiMxc3sRhHafWyIXtYJ 9PD/dbBtccUlmtl2YWc3kQCn9Su8ygO9C1HrBK/Txvt/0OTMAp36O1r9UlRLeaqVUuOc AhWXjwgKxkmwE6UFs1mBDDuQG2c+7g2oFn1dzb1Scs/IJU0Wi0J/ZQT7erFZO2NiNsHP 8PpfwYTMOO8LM2ZlZQnSmQ5TGDqQ1z+acl43p/Ab9WU8oBxwAdRsexwpHLKmSEppkl8S oQAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=SztjYL8cd79IZFi9WiqeieNnzgMo5Sw7GPlPVLcnKOs=; b=hCq68g6qn9S8rHW6HHBRUn09c6dU9FxJ0T8orZ+7vmDU1iExUlr6TI57yg/mjyly92 hIjbRQlQeGmC01CNmqEMStTeOucuL8E0qcl9EJBIS7opRQF8tMVWlhdNUOBFq3r6Za/A fkGU6zWKeI+rjuecmdJpLnx6r1x7YQE79e0tKC9L0T9Vx6smKbUvYWS3LtxzXWtTUZps 4gzVmqhgr4P+owMOJqnUlD70z8icfV1kDjxmz4RY6Ym7OAyBcuWnL8uLZJ79JOSXY0da +vRywIDqOVf0hDiLD7Me3kdpwK76zWcWwKB4rGxBVOIc4ySbx8h9kvXVZW+/T8OUZ5Xw FoLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a80si152111pfa.6.2018.01.11.23.39.43; Thu, 11 Jan 2018 23:39:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932432AbeALHjl (ORCPT + 28 others); Fri, 12 Jan 2018 02:39:41 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:4171 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750714AbeALHjk (ORCPT ); Fri, 12 Jan 2018 02:39:40 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 956CBA31DB603; Fri, 12 Jan 2018 15:39:23 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.361.1; Fri, 12 Jan 2018 15:39:14 +0800 From: Xiongfeng Wang To: , , CC: , , Subject: [PATCH] iio: accel: use strlcpy() instead of strncpy() Date: Fri, 12 Jan 2018 15:45:38 +0800 Message-ID: <1515743138-94480-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/iio/accel/st_accel_i2c.c: In function 'st_accel_i2c_probe': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 20 equals destination size [-Wstringop-truncation] The compiler require that the length of the dest string is greater than the length we want to copy to make sure the dest string is nul-terminated. We can just use strlcpy() to avoid this warning. Signed-off-by: Xiongfeng Wang --- drivers/iio/accel/st_accel_i2c.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.8.3.1 diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c index 363429b..6bdec8c 100644 --- a/drivers/iio/accel/st_accel_i2c.c +++ b/drivers/iio/accel/st_accel_i2c.c @@ -159,9 +159,8 @@ static int st_accel_i2c_probe(struct i2c_client *client, if ((ret < 0) || (ret >= ST_ACCEL_MAX)) return -ENODEV; - strncpy(client->name, st_accel_id_table[ret].name, + strlcpy(client->name, st_accel_id_table[ret].name, sizeof(client->name)); - client->name[sizeof(client->name) - 1] = '\0'; } else if (!id) return -ENODEV;