From patchwork Tue May 15 12:29:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 135876 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp950787lji; Tue, 15 May 2018 05:29:55 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpg7dJwYfHBQeNcPJJP/LpkzsIgntbdB36ucp2UN+Fc744o6kYFF8FWtrLn6RJ1NCVBJswi X-Received: by 2002:aa7:828c:: with SMTP id s12-v6mr14968251pfm.136.1526387395358; Tue, 15 May 2018 05:29:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526387395; cv=none; d=google.com; s=arc-20160816; b=qBnBZwz+LPvuRrlA3SPGoESVN7p6H9iMf3G7zwl6p8JWlsiaTa+8d5xspjw7lXQtLU pubMfkKNDCH9efTVCa0t4gCh9vmh1tQ/r4jzSii3CFXxyH0OJBhUptoMJFzvYKoTn+pL adTnyGrgmMXY5zYd5GznDv9C74+qPtZKIp2LC0Q+RqhdD8kxkf4gB4+/ZtGx2zubmqYf FdFj6AlnFeS8bCFPP23fD/MrHBw5ti0VuPePvRwgKd/F+lu9YwFRtzfvCnnhYOKzW0n8 3pd+QczRKfFe8wFvHRoRnIJYWNRpoeWBGnO9OCqve6/P6rU99XBPbolsew8txt2t1oiD 30zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=3r8X911ehDpNAVNJcyjFxMx3TTSsupKAYYa82wUYlTw=; b=stLGF3cGkRYZqpyL9ciVjp1p03snVmXLeYRNByIs4FX+LMe5aw1D2mLgxCCqO8G5gJ r8kuHgHytokO7yUYW3JR1a+vs8yz6sHKHVDSj9pZcj7k+W9un3qwrLbWTBqZf10MOXUi 5xhwcVbpaB24J9jWem9W3RUIIZs1YgG/49zFtSW2xrkq5QehMtcvGenraaOCN62SACdG uMsCb3FsKIPlr1jAlH3fzTdd2GAhPZmZBBXGyOHOWDlQXetvXrZWbpJ8ZmvbsLJwPjbm 2VJnQvKJxof++FB2o0zjBvoMI+hiiGGtLv/EQVuLsicG14pA7HoCPUB4rcc4f1G/1SBX 3pyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6-v6si12254576plo.534.2018.05.15.05.29.54; Tue, 15 May 2018 05:29:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbeEOM3v (ORCPT + 29 others); Tue, 15 May 2018 08:29:51 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:59684 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753300AbeEOM3r (ORCPT ); Tue, 15 May 2018 08:29:47 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E50BA15AB; Tue, 15 May 2018 05:29:46 -0700 (PDT) Received: from sugar.kfn.arm.com (unknown [10.45.48.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB1453F25D; Tue, 15 May 2018 05:29:42 -0700 (PDT) From: Gilad Ben-Yossef To: Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Herbert Xu , "David S. Miller" Cc: Ofir Drang , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org Subject: [PATCH 1/3] crypto: ccree: drop signature register check Date: Tue, 15 May 2018 13:29:27 +0100 Message-Id: <1526387370-17142-2-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1526387370-17142-1-git-send-email-gilad@benyossef.com> References: <1526387370-17142-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We were using the content of the signature register as a sanity check for the hardware functioning but it turns out not all implementers use the same values so the check is giving false negative on certain SoCs and so we drop it. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/ccree/cc_driver.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) -- 2.7.4 diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c index 89ce013..f8ff358 100644 --- a/drivers/crypto/ccree/cc_driver.c +++ b/drivers/crypto/ccree/cc_driver.c @@ -38,21 +38,20 @@ MODULE_PARM_DESC(cc_dump_bytes, "Dump buffers to kernel log as debugging aid"); struct cc_hw_data { char *name; enum cc_hw_rev rev; - u32 sig; }; /* Hardware revisions defs. */ static const struct cc_hw_data cc712_hw = { - .name = "712", .rev = CC_HW_REV_712, .sig = 0xDCC71200U + .name = "712", .rev = CC_HW_REV_712 }; static const struct cc_hw_data cc710_hw = { - .name = "710", .rev = CC_HW_REV_710, .sig = 0xDCC63200U + .name = "710", .rev = CC_HW_REV_710 }; static const struct cc_hw_data cc630p_hw = { - .name = "630P", .rev = CC_HW_REV_630, .sig = 0xDCC63000U + .name = "630P", .rev = CC_HW_REV_630 }; static const struct of_device_id arm_ccree_dev_of_match[] = { @@ -186,7 +185,6 @@ static int init_cc_resources(struct platform_device *plat_dev) struct cc_drvdata *new_drvdata; struct device *dev = &plat_dev->dev; struct device_node *np = dev->of_node; - u32 signature_val; u64 dma_mask; const struct cc_hw_data *hw_rev; const struct of_device_id *dev_id; @@ -275,16 +273,6 @@ static int init_cc_resources(struct platform_device *plat_dev) return rc; } - /* Verify correct mapping */ - signature_val = cc_ioread(new_drvdata, CC_REG(HOST_SIGNATURE)); - if (signature_val != hw_rev->sig) { - dev_err(dev, "Invalid CC signature: SIGNATURE=0x%08X != expected=0x%08X\n", - signature_val, hw_rev->sig); - rc = -EINVAL; - goto post_clk_err; - } - dev_dbg(dev, "CC SIGNATURE=0x%08X\n", signature_val); - /* Display HW versions */ dev_info(dev, "ARM CryptoCell %s Driver: HW version 0x%08X, Driver version %s\n", hw_rev->name, cc_ioread(new_drvdata, CC_REG(HOST_VERSION)),