From patchwork Thu Jul 26 11:23:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 142959 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp334975ljj; Thu, 26 Jul 2018 04:24:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd/wcnRmya8/zxInB3d2OUXVb5tj+EvFQwNFgd+yjwsVUmSssZCndJ9EnUJahQ0Ex+nBN92 X-Received: by 2002:a63:3246:: with SMTP id y67-v6mr1498485pgy.399.1532604278873; Thu, 26 Jul 2018 04:24:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532604278; cv=none; d=google.com; s=arc-20160816; b=BIyg+ypoCBRdEIif0K4o9yXgmBar1NgBDnMo2tkMaQ8++HqprZhs4S82kAmcHz/MI8 T9YJTVazA4Z8joo9ALYe4m3T+pdwvcVt/GMAhbrmcRLD/4XgaG9A9Ig5K2RWpTIPgxj0 uoK9ZQ0Va3nwH78N+fEkn18jGiBvfrIgHwIwdZkhR2pPrQiOd9JfpxGe5Z99HZYZEW5u yq4QVHh8P6LvcrZfD/DajyztGpP0FT1ZBgK2AHSGQCymvYJZiLwfv0o9QLOyMTz4noH2 RD6v76fLPav21rRsxBmkVdLnLUra7DfAWVTC9cooOyw/4b402j0AoQly2XLax7suugqC sdhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=H6xOxJLqcxZ1291t6fLqw6VZjOYoWca+jcfBjYcmn0o=; b=xXWZByrOj7WOAj10wvsiONykTyC0ZisO12GZkJ57xc6bUO6TKmXY0JomWFTFyzFpEA gDtcbGSQL/VRk7iADB65eLIPKke9TJGz8qBVFXtsQdl9o1g9fJ660qme7wV5McnK1NkX RgXf/KPA9KD4j74Tl+xrtx0lHQiPJwMiISFkPa/STNK83jsKCvfQFYXxdtezxxcv/Il1 X8Tf3i/J+ruRmGTMi70L5lcbhVt3OWCvD/83tvyPKev9a1oLxXRwyJeV2+xeQAq3Vy3Q NeV8cYqWoY7tUDhEE8nx/0b5X2itimtfYu2r+kR2F+crepG9Re92Ly0hC8FUiRv81Oax Rjbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w65-v6si1136379pfw.95.2018.07.26.04.24.38; Thu, 26 Jul 2018 04:24:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729399AbeGZMku (ORCPT + 31 others); Thu, 26 Jul 2018 08:40:50 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53250 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729255AbeGZMku (ORCPT ); Thu, 26 Jul 2018 08:40:50 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82A5580D; Thu, 26 Jul 2018 04:24:27 -0700 (PDT) Received: from usa.arm.com (e107155-lin.emea.arm.com [10.4.12.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 73FB13F575; Thu, 26 Jul 2018 04:24:26 -0700 (PDT) From: Sudeep Holla To: linux-kernel@vger.kernel.org Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland Subject: [PATCH] drivers/perf: arm-ccn: Use devm_ioremap_resource() to map memory Date: Thu, 26 Jul 2018 12:23:31 +0100 Message-Id: <1532604211-28609-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of checking the return value of platform_get_resource(), we can use devm_ioremap_resource() which has the NULL pointer check and the memory region requesting. devm_ioremap_resource is designed to replace calls to devm_request_mem_region followed by devm_ioremap, so let's use the same. Cc: Will Deacon Cc: Mark Rutland Signed-off-by: Sudeep Holla --- drivers/perf/arm-ccn.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) Hi Will, Just came across this when I was trying to use devm_ioremap_resource for vexpress-syscfg instead of adding a patch that adds more unnecessary NULL ptr checks based on coccinelle warnings. All other perf drivers seem to do the same except this one. I changed this too along with vexpress-syscfg, but forgot to send. Regards, Sudeep -- 2.7.4 diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c index b416ee18e6bb..4b15c36f4631 100644 --- a/drivers/perf/arm-ccn.c +++ b/drivers/perf/arm-ccn.c @@ -1485,17 +1485,9 @@ static int arm_ccn_probe(struct platform_device *pdev) platform_set_drvdata(pdev, ccn); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -EINVAL; - - if (!devm_request_mem_region(ccn->dev, res->start, - resource_size(res), pdev->name)) - return -EBUSY; - - ccn->base = devm_ioremap(ccn->dev, res->start, - resource_size(res)); - if (!ccn->base) - return -EFAULT; + ccn->base = devm_ioremap_resource(ccn->dev, res); + if (IS_ERR(ccn->base)) + return PTR_ERR(ccn->base); res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); if (!res)