From patchwork Wed Aug 8 02:14:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 143599 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp269820ljj; Tue, 7 Aug 2018 19:15:06 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxJuzw6uFNZjO2Ygb5v1x4+WmynqYylJSFUEVJNkaGo3dF4fhFWUmIvexzsxcKJl6brXjPW X-Received: by 2002:a62:b20c:: with SMTP id x12-v6mr853112pfe.64.1533694506239; Tue, 07 Aug 2018 19:15:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533694506; cv=none; d=google.com; s=arc-20160816; b=UctZ03QybXfiiQPmBvQgVZSHr5GJT+OowPMcdLIA7wBLgeBHBeedDcrUzmHqp3yN8V YYvSvVceaVJd6QRKU++81Zosd1fMim9rM4xdo+ALceqqelc/bYhLIFuy4xgC0Lhh+bUL Y7T3tB0ZyNEXIc8AkDq+pQDR+DNvNMTYOtvS9HnF2QdARZ/Y7XJ9f+zA/vE3ciZaRJA7 JgEtkqHhKPsQUOXCoc0i3Bkirzn+9XoHNhJi18ectQCdfDDj8kAL8PnWTuRo5UP47czU SN3JforGj8ibO3dBonOunyWeju80piHNr0d1nYSoDPfbEtmrySNQeNebIHC81Ij4gso4 6niA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=lz55LlsaXOwcAuOwTiLk3BFAF92eA/fNIvzieH95kvw=; b=pGJb1eUQ5Wq7d7gKwknoE1i/6ZBoQbBujAS71b7lpxpm/72Nv8HztHCe7aoBVIoQqG oPOelyhTKM7qVNN+nr/3nsA3Z41EtAr1e62Ji9Itd4e3SwKsTjYpgWvKsFAUt2LBAA+U dSoYnGKDtMbvaVhEKYblcDP8yvCq4p18CNTnrg5Fpox2zRLcYIO6oXa1MA3DfQKDMQGe XWGkZC6XDUFfk/m1FB34qXlsU9CZAd5/bF35kxNgWQXBNLSG6ENeG16pZ/ftFAupcFZ5 r7PT2gclBc+7bHT4CfYla12abKrG8scDvN5daRSeFyVU1ydWhhyc4xxg27Br6lMzCUT2 5YqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=GO1LCVSL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a75-v6si3349170pfc.106.2018.08.07.19.15.05; Tue, 07 Aug 2018 19:15:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=GO1LCVSL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbeHHEcT (ORCPT + 31 others); Wed, 8 Aug 2018 00:32:19 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:37728 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbeHHEcS (ORCPT ); Wed, 8 Aug 2018 00:32:18 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id w782EIlo004152; Wed, 8 Aug 2018 11:14:18 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com w782EIlo004152 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1533694459; bh=lz55LlsaXOwcAuOwTiLk3BFAF92eA/fNIvzieH95kvw=; h=From:To:Cc:Subject:Date:From; b=GO1LCVSLWopwYoCoiJZX8oZIBU7+wyXtGE5M94hh+4WZmxWofcE3koPRtxGHeBFvx R7Sd3AtjKhNxl2Fvmb1YLukqkppsw5qqqhby0ApJ9dK5CI+Lf/h5AgUcGgxLWHsoNE IzG2fCNbB1ZSBphDh3CkjI77cHAPFcz89BRd4rgDHBELuVmKf71/lUT3Tsp7MfRwk4 Cq3YZegLyGdACCMpHqws4H7hqWDY42s5g09odQa/2I3YncB6qbLE5ggqkYOuDvMYG/ lQwUk32H8w6gFWP/MsCiCubofBDbYm6XY1j66RnxBxwAFDimCnfcUSeuP1H5Qb6HjC hCn1eJ0QbOjMg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: David Howells Cc: Stephen Rothwell , Arnd Bergmann , linux-kbuild@vger.kernel.org, Al Viro , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH v2] kbuild: make samples really depend on headers_install Date: Wed, 8 Aug 2018 11:14:14 +0900 Message-Id: <1533694454-7086-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kernel headers must be installed into $(objtree)/usr/include to avoid the build failure of samples. Commit ddea05fa148b ("kbuild: make samples depend on headers_install") addressed this, but "samples/" is only used for the single target build. "make samples/" properly installs kernel headers, but it does not work for general building because a phony target "sample" (no trailing slash) is used. Reported-by: David Howells Signed-off-by: Masahiro Yamada --- Changes in v2: - Correct commit log (backslash -> slash) - Fix a typo Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.7.4 Tested-by: David Howells diff --git a/Makefile b/Makefile index 7a3c454..1e47d13 100644 --- a/Makefile +++ b/Makefile @@ -1009,9 +1009,10 @@ ifdef CONFIG_GDB_SCRIPTS endif +$(call if_changed,link-vmlinux) -# Build samples along the rest of the kernel +# Build samples along the rest of the kernel. This needs headers_install. ifdef CONFIG_SAMPLES vmlinux-dirs += samples +samples: headers_install endif # The actual objects are generated when descending,