| Message ID | 1542589336-13925-1-git-send-email-sugaya.taichi@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hi Sugaya-san On Mon, Nov 19, 2018 at 10:01 AM Sugaya Taichi <sugaya.taichi@socionext.com> wrote: > > Add Milbeaut M10V pinctrl. > The M10V has the pins that can be used GPIOs or take multiple other > functions. > > Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com> This patch was sent to: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Unfortunately, the most important ML linux-gpio@vger.kernel.org was not addressed. The pinctrl maintainer may not notice this patch. > diff --git a/drivers/pinctrl/pinctrl-m10v.c b/drivers/pinctrl/pinctrl-m10v.c > new file mode 100644 > index 0000000..d4ca713 > --- /dev/null > +++ b/drivers/pinctrl/pinctrl-m10v.c > @@ -0,0 +1,765 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2018 Socionext Ltd. > + * Copyright (C) 2015 Linaro Ltd. > + * Author: Jassi Brar <jaswinder.singh@linaro.org> My company name is "Socionext Inc." instead of "Socionext Ltd." > +static struct platform_driver m10v_pinctrl_driver = { > + .probe = m10v_pinctrl_probe, > + .driver = { > + .name = "m10v-pinctrl", > + .of_match_table = m10v_pmatch, > + }, > +}; > + > +static int __init m10v_pinctrl_init(void) > +{ > + return platform_driver_register(&m10v_pinctrl_driver); > +} > +arch_initcall(m10v_pinctrl_init); Can't it be builtin_platform_driver()? Which device requires this to be arch_initcall()? -- Best Regards Masahiro Yamada
diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.txt new file mode 100644 index 0000000..7469189 --- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.txt @@ -0,0 +1,33 @@ +Milbeaut SoCs pin controller + +Required properties: +- compatible: should be one of the following: + "socionext,milbeaut-m10v-pinctrl" - for m10v SoC +- reg: offset and length of the register set. +- reg-names: should be "pinctrl", "exiu". +- gpio-cells; should be 2. +- interrupt-cells: should be 2. +- clocks: phandle to the input clock. +- interrupts: three interrupts specifer. +- interrupt-names: corresponds "interrupts" factor. + +Example: + pinctrl: pinctrl@1d022000 { + compatible = "socionext,milbeaut-m10v-pinctrl"; + reg = <0x1d022000 0x1000>, + <0x1c26f000 0x1000>; + reg-names = "pinctrl", "exiu"; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + clocks = <&dummy_clk>; + interrupts = <0 54 4>, <0 55 4>, <0 56 4>, <0 57 4>, + <0 58 4>, <0 59 4>, <0 60 4>, <0 61 4>, + <0 62 4>, <0 63 4>, <0 64 4>, <0 65 4>, + <0 66 4>, <0 67 4>, <0 68 4>, <0 69 4>; + interrupt-names = "pin-48", "pin-49", "pin-50", "pin-51", + "pin-52", "pin-53", "pin-54", "pin-55", + "pin-56", "pin-57", "pin-58", "pin-59", + "pin-60", "pin-61", "pin-62", "pin-63"; + }
Add DT bindings document for Milbeaut M10V pinctrl. Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com> --- .../pinctrl/socionext,milbeaut-pinctrl.txt | 33 ++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.txt -- 1.9.1