From patchwork Mon Dec 3 07:50:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 152679 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6512461ljp; Sun, 2 Dec 2018 23:52:12 -0800 (PST) X-Google-Smtp-Source: AFSGD/VJ+JzriafXwKmC1RcP4rXxUOGRIR1XUpWFUniNGj6eaZlWtsII933CN3LGRWQArn1CDVaR X-Received: by 2002:a63:b54f:: with SMTP id u15mr12329025pgo.420.1543823531979; Sun, 02 Dec 2018 23:52:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543823531; cv=none; d=google.com; s=arc-20160816; b=IqMawwZmciKW6TwAxefq5spRQwXhiDHiTa0Py+0C35XWeT3PHdnUQkKPD9ERJpKNnu owON8nQ9HSNVJSAAEspmAcWjuVhHCTJrEO0Qj5jwsS2IhEzK/NHxZBdAGhEJkZLabHHo aII21UWv7olVjtn7Fh+qrysuMYQdLcaZMxGO49f8XQMHcb9chv12pz47DtkhAmG29BYW QnmDlB+k2b5Q2b5aK7EpOxi/xsJ1XXJjOJ2H+4sp3E49xurb4lChy3m02sj8zkP9kNd2 4QknJlCf20vBp1ITJTTCzssHGJGhaxiBEBTmAX7CpXZv6hRq9cq3wGPNjWMYJAV0UmNE +pOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=XuSq2PAyWJ8SgmLhjLsNRYQS3C416oLEGtt8Uth20Ws=; b=oWoHFuS6R7beGFus7P8c0AbXBhetHhB9Hw9gIh98yGaxOySf76+vv8nA0tkQtl7qHz 1DNckxe/CS580w/UDT+jfLBF0vGp8/dGnBVbYq/pC428HZOs0JcHkAZO2P3+9n4uN9G/ bNN7+kaA6UPajiChqS3wZE3JciyHr5UEba7utZ8tyHF5b4zGAtstWnCjBeThAwHweVDI uwxIOHiM+QL0YB1FNIUv64SicH8Ey6Zz251uqyZr+n16aNKa0tvEDVDZG2gSsjWu1+fF 7Z+y5xtqrrgOFS6qpI1wFVKwHm4XJf+ZPgVuaO890XroPlhRRtNmO+LhSHpzuwkISNgz PwAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=04NndtQR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y188si14094698pfb.59.2018.12.02.23.52.11; Sun, 02 Dec 2018 23:52:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=04NndtQR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726002AbeLCHwO (ORCPT + 32 others); Mon, 3 Dec 2018 02:52:14 -0500 Received: from conuserg-09.nifty.com ([210.131.2.76]:60442 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbeLCHvx (ORCPT ); Mon, 3 Dec 2018 02:51:53 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id wB37p4O8009296; Mon, 3 Dec 2018 16:51:08 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com wB37p4O8009296 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1543823469; bh=XuSq2PAyWJ8SgmLhjLsNRYQS3C416oLEGtt8Uth20Ws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=04NndtQRfn4Vvm379KZRYQyu4MK14Ijbe2qNkcqGdnRPsy5kp2Q15g70bWu42T6BW PcHvZyDCLiFseO6EGGwFCGXC+GQamCYTZgXZagRiE7Y15PUleK3zLehToQc95MuyUP xwWA/NpwqFsencduPmhhTvakyZ7Q21bLFGz8TTnhpmC9nEVrmeLkwAJ9EqH6VZg5e1 E2081oIsFdTvME92rIllLNtwsfj15ZJILi6wQXvDqfEiENu2hGMVIDPCd7OnmYoP5E PCOG9hMkczMVKcLMHlPMc6hW2zMp4nTy9Y1APwD/Tc4Ewo0MbFMxJL7xMrjIr6Dbbe 4qcs8YH2RgHHQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Michal Simek Cc: linux-kbuild@vger.kernel.org, Masahiro Yamada , devicetree@vger.kernel.org, Mark Rutland , Rob Herring , linux-kernel@vger.kernel.org Subject: [PATCH 7/7] microblaze: remove the unneeded code just in case file copy fails Date: Mon, 3 Dec 2018 16:50:57 +0900 Message-Id: <1543823457-32478-8-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1543823457-32478-1-git-send-email-yamada.masahiro@socionext.com> References: <1543823457-32478-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I guess || (rm -f $@ && echo false) ... should be || (rm -f $@ && false) since printing the string "false" on the console has no point. Moreover, no Makefile needs to delete a target on error explicitly since commit 9c2af1c7377a ("kbuild: add .DELETE_ON_ERROR special target"). Reuse equivalent cmd_shipped from scripts/Makefile.lib. Signed-off-by: Masahiro Yamada --- arch/microblaze/boot/dts/Makefile | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.7.4 diff --git a/arch/microblaze/boot/dts/Makefile b/arch/microblaze/boot/dts/Makefile index c7324e7..ef00dd3 100644 --- a/arch/microblaze/boot/dts/Makefile +++ b/arch/microblaze/boot/dts/Makefile @@ -12,12 +12,9 @@ $(obj)/linked_dtb.o: $(obj)/system.dtb # Generate system.dtb from $(DTB).dtb ifneq ($(DTB),system) $(obj)/system.dtb: $(obj)/$(DTB).dtb - $(call if_changed,cp) + $(call if_changed,shipped) endif endif -quiet_cmd_cp = CP $< $@$2 - cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false) - # Rule to build device tree blobs DTC_FLAGS := -p 1024