From patchwork Tue Dec 18 05:25:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 154072 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3294152ljp; Mon, 17 Dec 2018 21:26:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/XgzrXby1bWLIwsCxZjdklNvUpn5d1YWBXvpE5X/HGJc6VqBiOXWlxLZuiQeHMatE6l6ajP X-Received: by 2002:a17:902:28c1:: with SMTP id f59mr15201641plb.37.1545110794142; Mon, 17 Dec 2018 21:26:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545110794; cv=none; d=google.com; s=arc-20160816; b=mu/aC9AjvUykMOkmz7MBOrXal6DT/ilxzhoJisEx1smyWnOZymqbQd24lNWv7xSz3r xPH9YuZep8kxfspEAxgpyXvLAl0IEU3vqaHV521djLGkn/88rgQRlJAc2n4Ea0gC0Eyp MmXfl0f3SJm2w35D2XgEcp336JD9gwY9hOdagXwoQOzsRfouSgRb5c00nq5n5si09ucH 8Fk3NZDIyyVy2gleO5zaeMrCMJt/zN03UXsIiNF3pukmcXwVZ6fz/zs76JQTdQHvJYNI qDCsFOMI9rz7MMKmG/XXHN2hcpuCziOrRknP3hrdPA+2Oz5PLn0OnZzSng2gDiaufyxw B53A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=WhkTIvnxrA5Lys7ML7oerDPj21OzgOyOFM6M3SRkHao=; b=ScsTi19ggBwULr8qmDN2Y5yzoi3HHEzgSCDf79nFGXtR3Dj3W3Yvoiq49z1APu/0vc /90n9K5762+CRAxJqJHnC+w2taapX1FdVF18TH+whLBG87/Rh0UYKrOoePN+X9QFNCG8 DbvBEzTvJE8CX+ukFUlSx7Kucs8mpCwuBVxIZBgICw6GTnvwavvL1W+AfVaJ+K+/kHTF oMQlcJF9yGSbvMLWmJctgNRO0VwP8WIBgHErYeF1TX+J9Iqd0rgUOCdyh3lc8xySjbpl h5ATzsv06ezVy/bTRORjHMmyQ9D157dibvZpnBjfOVz83gdt2xjh+Syc0uNaoC20hxlS xffw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=t4H5J+WP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f34si10347641ple.280.2018.12.17.21.26.33; Mon, 17 Dec 2018 21:26:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=t4H5J+WP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726387AbeLRF0c (ORCPT + 31 others); Tue, 18 Dec 2018 00:26:32 -0500 Received: from conuserg-10.nifty.com ([210.131.2.77]:59785 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbeLRF0b (ORCPT ); Tue, 18 Dec 2018 00:26:31 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id wBI5PoZA030731; Tue, 18 Dec 2018 14:25:50 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com wBI5PoZA030731 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1545110751; bh=WhkTIvnxrA5Lys7ML7oerDPj21OzgOyOFM6M3SRkHao=; h=From:To:Cc:Subject:Date:From; b=t4H5J+WPWqoXvf2Ha5nwqAQEXDYAg3OkpZt/GhwZbxJQemC5UYsnWJgflCUX+R5+E V2Bq7uM4708naZmMbT3qKW9alVE3304bOnucYT6vW7NG88YyhsUO14aWrl0hp6U1aK SQKHpaFvzKTlt/8ntrQ+LOLUNSwE/8bdXBq13S5q15hPVa7baLb0F3luZZt5s4hNLV oTCmy/ElNiGGB62LIPaR1b9Q1p5DqS9Y1kysLDc1dlmneyt9Dfk8XhIFw4IB2B/I/8 1PnKYJqU3y9nH6e7ZTvjvhTRpCY5nRdJuiunhRDKrBLuBMpvfuTGPe2FJUTFk8RQ9u mCHEglNA+rmcw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Paul Gortmaker , Bernd Edlinger , Qian Cai , Masahiro Yamada , Josh Poimboeuf , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH] kbuild: fix false positive warning/error about missing libelf Date: Tue, 18 Dec 2018 14:25:41 +0900 Message-Id: <1545110741-10761-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For the same reason as commit 25896d073d8a ("x86/build: Fix compiler support check for CONFIG_RETPOLINE"), you cannot put this $(error ...) into the parse stage of the top Makefile. Perhaps I'd propose a more sophisticated solution later, but this is the best I can do for now. Link: https://lkml.org/lkml/2017/12/25/211 Reported-by: Paul Gortmaker Reported-by: Bernd Edlinger Reported-by: Qian Cai Cc: Josh Poimboeuf Signed-off-by: Masahiro Yamada --- Makefile | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) -- 2.7.4 Tested-by: Qian Cai diff --git a/Makefile b/Makefile index 56d5270..d45856f 100644 --- a/Makefile +++ b/Makefile @@ -962,11 +962,6 @@ ifdef CONFIG_STACK_VALIDATION ifeq ($(has_libelf),1) objtool_target := tools/objtool FORCE else - ifdef CONFIG_UNWINDER_ORC - $(error "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel") - else - $(warning "Cannot use CONFIG_STACK_VALIDATION=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel") - endif SKIP_STACK_VALIDATION := 1 export SKIP_STACK_VALIDATION endif @@ -1125,6 +1120,14 @@ uapi-asm-generic: PHONY += prepare-objtool prepare-objtool: $(objtool_target) +ifeq ($(SKIP_STACK_VALIDATION),1) +ifdef CONFIG_UNWINDER_ORC + @echo "error: Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel" >&2 + @false +else + @echo "warning: Cannot use CONFIG_STACK_VALIDATION=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel" >&2 +endif +endif # Generate some files # ---------------------------------------------------------------------------