From patchwork Thu Apr 17 16:28:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 28584 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f70.google.com (mail-qa0-f70.google.com [209.85.216.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0EEE220674 for ; Thu, 17 Apr 2014 16:31:33 +0000 (UTC) Received: by mail-qa0-f70.google.com with SMTP id m5sf1693625qaj.5 for ; Thu, 17 Apr 2014 09:31:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=aDIIsPe1H4E2hVMCANDa0t9ooLY/dGWO6eM6rFqLux4=; b=BFTPxaiuRkK+KbHsrnQ3HZj316d0GhFvPm8UMMqmL3RO3rgBMQKPIf7uk2TBWSgrfi meUMDTSWx5bgfZf+hA95wVlY7l4cQrOuUgf+kVVBPy2lcTJXTjMs9Xn2DkYTKqcEbCyl p0sbaF5KPmaCmsyzex85TkAZCKgrpZMiHYXz8F4jfkzSUF1ytkrrqsYKoTL5ds995duL JLPBW5MVp+vHgQYGWkep0VvDnfAsIw9S+wClxLXbUQDq1rL+V9E6GxfYvuKe0jX/bt6Y dUrojaiLeZwxDV3D5Jg9hLzBEtfV2sDwwuHzvjlBUfFIJEM52FTPq2A+rFqneCk/E/4B TSNg== X-Gm-Message-State: ALoCoQnkomgxFVCg77VRHuwK39fXvWMdPDrI/nn2mtZW+ZnDCxWenhu9j7yCSUCsH4vIbGJn4VCJ X-Received: by 10.236.92.204 with SMTP id j52mr6790777yhf.26.1397752293745; Thu, 17 Apr 2014 09:31:33 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.83.115 with SMTP id i106ls1183897qgd.97.gmail; Thu, 17 Apr 2014 09:31:33 -0700 (PDT) X-Received: by 10.220.249.6 with SMTP id mi6mr1215379vcb.33.1397752293628; Thu, 17 Apr 2014 09:31:33 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id ui2si4527867vdc.136.2014.04.17.09.31.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Apr 2014 09:31:33 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id jz11so776660veb.11 for ; Thu, 17 Apr 2014 09:31:33 -0700 (PDT) X-Received: by 10.52.15.132 with SMTP id x4mr6757561vdc.31.1397752293546; Thu, 17 Apr 2014 09:31:33 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp48745vcb; Thu, 17 Apr 2014 09:31:32 -0700 (PDT) X-Received: by 10.66.163.2 with SMTP id ye2mr16766806pab.110.1397752291476; Thu, 17 Apr 2014 09:31:31 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pu6si12794884pac.348.2014.04.17.09.31.30; Thu, 17 Apr 2014 09:31:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbaDQQb0 (ORCPT + 3 others); Thu, 17 Apr 2014 12:31:26 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:60702 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbaDQQbZ (ORCPT ); Thu, 17 Apr 2014 12:31:25 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s3HGVBnx024540; Thu, 17 Apr 2014 11:31:11 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3HGVBY2025965; Thu, 17 Apr 2014 11:31:11 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Thu, 17 Apr 2014 11:31:10 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3HGVAqS029074; Thu, 17 Apr 2014 11:31:10 -0500 Date: Thu, 17 Apr 2014 11:28:56 -0500 From: Felipe Balbi To: Paul Bolle CC: , Greg Kroah-Hartman , Richard Weinberger , , , Subject: Re: [PATCH] usb: phy: mv_u3d: Remove usb phy driver for mv_u3d Message-ID: <20140417162855.GB22861@saruman.home> Reply-To: References: <1397561783.1985.55.camel@x220> <20140415172310.GD16002@saruman.home> <1397585312.8212.13.camel@x220> <20140416043450.GB15056@saruman.home> <1397721028.24336.13.camel@x220> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1397721028.24336.13.camel@x220> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Thu, Apr 17, 2014 at 09:50:28AM +0200, Paul Bolle wrote: > On Tue, 2014-04-15 at 23:34 -0500, Felipe Balbi wrote: > > $ make drivers/usb/phy/phy-mv-u3d-usb.o > > CHK include/config/kernel.release > > CHK include/generated/uapi/linux/version.h > > CHK include/generated/utsrelease.h > > make[1]: `include/generated/mach-types.h' is up to date. > > CALL scripts/checksyscalls.sh > > CC drivers/usb/phy/phy-mv-u3d-usb.o > > (On x86_64 this manual make command triggers the error Greg reported in > https://lkml.org/lkml/2014/2/11/693 .) > > > yup, builds just fine. Even if the ARCH support isn't in place, this > > driver is *not* breaking anything, it's not preventing anyone from > > getting work done and it might be helping Marvell decrease the amount of > > changes they keep out of tree. > > > > I don't see any problems this driver in tree as long as there are people > > working on it and I see the latest commit was 10 days ago, it wouldn't > > be fair to Marvell to delete their driver if they're still finding ways > > to make it useful one way or another. > > Wouldn't it then be better if this driver is at least hooked into the > build system? Like, say, this: > config MV_U3D_PHY > bool "Marvell USB 3.0 PHY controller Driver" > # XXX should depend on CPU_MMP3 when support for MMP3 lands > depends on ARM && COMPILE_TEST > select USB_PHY > help > Enable this to support Marvell USB 3.0 phy controller for Marvell > SoC. > > (Or perhaps only ARCH_MMP && COMPILE_TEST.) That should give it build > coverage by the automated tests people appear to run, while work is done > on adding MMP3 support. I guess we should make it depend on BROKEN instead, or we just apply the patch below: 8<--------------------------------------------------------------------- >From 60e524d7db4ed04624850fcb84a844c609a960e3 Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Thu, 17 Apr 2014 11:24:27 -0500 Subject: [PATCH] usb: phy: mv-u3d: switch over to writel/readl by removing the _relaxed suffix, we can build this driver in other architectures. Signed-off-by: Felipe Balbi --- drivers/usb/phy/phy-mv-u3d-usb.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/phy/phy-mv-u3d-usb.c b/drivers/usb/phy/phy-mv-u3d-usb.c index d317903..d342175 100644 --- a/drivers/usb/phy/phy-mv-u3d-usb.c +++ b/drivers/usb/phy/phy-mv-u3d-usb.c @@ -39,8 +39,8 @@ static u32 mv_u3d_phy_read(void __iomem *base, u32 reg) addr = base; data = base + 0x4; - writel_relaxed(reg, addr); - return readl_relaxed(data); + writel(reg, addr); + return readl(data); } static void mv_u3d_phy_set(void __iomem *base, u32 reg, u32 value) @@ -51,10 +51,10 @@ static void mv_u3d_phy_set(void __iomem *base, u32 reg, u32 value) addr = base; data = base + 0x4; - writel_relaxed(reg, addr); - tmp = readl_relaxed(data); + writel(reg, addr); + tmp = readl(data); tmp |= value; - writel_relaxed(tmp, data); + writel(tmp, data); } static void mv_u3d_phy_clear(void __iomem *base, u32 reg, u32 value) @@ -65,10 +65,10 @@ static void mv_u3d_phy_clear(void __iomem *base, u32 reg, u32 value) addr = base; data = base + 0x4; - writel_relaxed(reg, addr); - tmp = readl_relaxed(data); + writel(reg, addr); + tmp = readl(data); tmp &= ~value; - writel_relaxed(tmp, data); + writel(tmp, data); } static void mv_u3d_phy_write(void __iomem *base, u32 reg, u32 value) @@ -78,8 +78,8 @@ static void mv_u3d_phy_write(void __iomem *base, u32 reg, u32 value) addr = base; data = base + 0x4; - writel_relaxed(reg, addr); - writel_relaxed(value, data); + writel(reg, addr); + writel(value, data); } static void mv_u3d_phy_shutdown(struct usb_phy *phy)